Changeset 32829 in osm for applications/editors/josm/plugins/wikipedia

Timestamp:

2016-08-18T07:21:04+02:00 (8 years ago)

Author:

simon04

Message:

JOSM/wikipedia: fix unit tests - #josm13372

Location:

applications/editors/josm/plugins/wikipedia

Files:

• src/org/wikipedia/WikidataTagCellRenderer.java (modified) (1 diff)
• src/org/wikipedia/WikipediaApp.java (modified) (8 diffs)
• test/unit/org/wikipedia/WikidataTagCellRendererTest.java (modified) (1 diff)

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikidataTagCellRenderer.java

@@ -24 +24 @@
 public class WikidataTagCellRenderer extends DefaultTableCellRenderer {
 
-    private final Map<String, CompletableFuture<String>> labelCache = new ConcurrentHashMap<>();
+    final Map<String, CompletableFuture<String>> labelCache = new ConcurrentHashMap<>();
 
     @Override

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java

@@ -43 +43 @@
 
     public static final Pattern WIKIDATA_PATTERN = Pattern.compile("Q\\d+");
-    private static final DocumentBuilder DOCUMENT_BUILDER = newDocumentBuilder();
     private static final XPath X_PATH = XPath.getInstance();
 
@@ -76 +75 @@
             // parse XML document
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document doc = DOCUMENT_BUILDER.parse(in);
+                final Document doc = newDocumentBuilder().parse(in);
                 final List<WikipediaEntry> entries = X_PATH.evaluateNodes("//gs", doc).stream()
                         .map(node -> {
@@ -110 +109 @@
                     "&format=xml";
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document xml = DOCUMENT_BUILDER.parse(in);
+                final Document xml = newDocumentBuilder().parse(in);
                 final List<WikidataEntry> r = X_PATH.evaluateNodes("//entity", xml).stream()
                         .map(node -> new WikidataEntry(X_PATH.evaluateString("@id", node), null, null, null))
@@ -213 +212 @@
             final Map<String, String> r = new TreeMap<>();
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document xml = DOCUMENT_BUILDER.parse(in);
+                final Document xml = newDocumentBuilder().parse(in);
                 X_PATH.evaluateNodes("//entity", xml).forEach(node -> {
                     final String wikidata = X_PATH.evaluateString("./@id", node);
@@ -237 +236 @@
             // parse XML document
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document doc = DOCUMENT_BUILDER.parse(in);
+                final Document doc = newDocumentBuilder().parse(in);
                 return X_PATH.evaluateNodes("//ps/@title", doc).stream()
                         .map(Node::getNodeValue)
@@ -281 +280 @@
             final List<WikidataEntry> r = new ArrayList<>(entries.size());
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document xml = DOCUMENT_BUILDER.parse(in);
+                final Document xml = newDocumentBuilder().parse(in);
                 for (final WikipediaEntry entry : entries) {
                     final Node entity = X_PATH.evaluateNode("//entity[@id='" + entry.wikipediaArticle + "']", xml);
+                    if (entity == null) {
+                        continue;
+                    }
                     r.add(new WikidataEntry(
                             entry.wikipediaArticle,
@@ -317 +319 @@
                     "&format=xml";
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document xml = DOCUMENT_BUILDER.parse(in);
+                final Document xml = newDocumentBuilder().parse(in);
                 return X_PATH.evaluateNodes("//ll", xml).stream()
                         .map(node -> {
@@ -338 +340 @@
                     "&format=xml";
             try (final InputStream in = HttpClient.create(new URL(url)).setReasonForRequest("Wikipedia").connect().getContent()) {
-                final Document xml = DOCUMENT_BUILDER.parse(in);
+                final Document xml = newDocumentBuilder().parse(in);
                 final Node node = X_PATH.evaluateNode("//coordinates/co", xml);
                 if (node == null) {

applications/editors/josm/plugins/wikipedia/test/unit/org/wikipedia/WikidataTagCellRendererTest.java

@@ -27 +27 @@
         final WikidataTagCellRenderer renderer = new WikidataTagCellRenderer();
         renderer.renderValues(ids, new JTable(), new JLabel());
-        Main.worker.submit(new Runnable() {
-            @Override
-            public void run() {
-            }
-        }).get(); // wait for labels to be fetched
+        for (String id : ids) {
+            // wait for labels to be fetched
+            renderer.labelCache.get(id).get();
+        }
         final JLabel label = renderer.renderValues(ids, new JTable(), new JLabel());
         assertNotNull(label);