Changeset 32649 in osm for applications/editors/josm/plugins

Timestamp:

2016-07-13T08:41:57+02:00 (8 years ago)

Author:

donvip

Message:

checkstyle

Location:

applications/editors/josm/plugins/globalsat

Files:

• .checkstyle (added)
• .project (modified) (1 diff)
• .settings/org.eclipse.jdt.ui.prefs (added)
• src/org/openstreetmap/josm/plugins/globalsat/GlobalsatConfigDialog.java (modified) (24 diffs)
• src/org/openstreetmap/josm/plugins/globalsat/GlobalsatDg100.java (modified) (20 diffs)
• src/org/openstreetmap/josm/plugins/globalsat/GlobalsatImportDialog.java (modified) (11 diffs)
• src/org/openstreetmap/josm/plugins/globalsat/GlobalsatPlugin.java (modified) (8 diffs)
• src/org/openstreetmap/josm/plugins/globalsat/SingleSegmentGpxTrack.java (modified) (2 diffs)

applications/editors/josm/plugins/globalsat/.project

@@ -16 +16 @@
                         </arguments>
                 </buildCommand>
+                <buildCommand>
+                        <name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+                        <arguments>
+                        </arguments>
+                </buildCommand>
         </buildSpec>
         <natures>
                 <nature>org.eclipse.jdt.core.javanature</nature>
+                <nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
         </natures>
 </projectDescription>

applications/editors/josm/plugins/globalsat/src/org/openstreetmap/josm/plugins/globalsat/GlobalsatConfigDialog.java

@@ -1 @@
-// License: GPL v2 or later (v3 preferred). Copyright 2008 by Raphael Mack
+// License: GPL. For details, see LICENSE file.
 
 //TODO: check input for numbers in text fields
@@ -28 +28 @@
  * Configuration download dialog.
  *
- * @author Raphael Mack <ramack@raphael-mack.de>
- *
+ * @author Raphael Mack &lt;ramack@raphael-mack.de&gt;
  */
 public class GlobalsatConfigDialog extends JPanel {
 
-
     public class IntegerTextField extends JTextField {
 
-        final static String badchars = "-`~!@#$%^&*()_+=\\|\"':;?/>.<, ";
-
+        static final String badchars = "-`~!@#$%^&*()_+=\\|\"':;?/>.<, ";
+
+        @Override
         public void processKeyEvent(KeyEvent ev) {
 
             char c = ev.getKeyChar();
-            if((Character.isLetter(c) && !ev.isAltDown())
+            if ((Character.isLetter(c) && !ev.isAltDown())
                || badchars.indexOf(c) > -1) {
                 ev.consume();
@@ -79 +78 @@
 
         Dimension xx = aSeconds.getPreferredSize();
-        aSeconds.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        aSeconds.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         aSeconds.setHorizontalAlignment(JTextField.RIGHT);
-        aMeters.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        aMeters.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         aMeters.setHorizontalAlignment(JTextField.RIGHT);
-        bSeconds.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        bSeconds.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         bSeconds.setHorizontalAlignment(JTextField.RIGHT);
-        bMeters.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        bMeters.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         bMeters.setHorizontalAlignment(JTextField.RIGHT);
-        cSeconds.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        cSeconds.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         cSeconds.setHorizontalAlignment(JTextField.RIGHT);
-        cMeters.setPreferredSize(new Dimension((int)xx.getWidth() + 50, (int)xx.getHeight()));
+        cMeters.setPreferredSize(new Dimension((int) xx.getWidth() + 50, (int) xx.getHeight()));
         cMeters.setHorizontalAlignment(JTextField.RIGHT);
 
@@ -106 +105 @@
         logPanel.add(formatPosTDSA);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1.8;
@@ -116 +115 @@
 
         disableLogSpeed = new JCheckBox(tr("Disable data logging if speed falls below"));
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 0.8;
@@ -127 +126 @@
         minLogSpeed = new IntegerTextField();
         minLogSpeed.setHorizontalAlignment(JTextField.RIGHT);
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1.5;
@@ -135 +134 @@
         add(minLogSpeed, c);
 
-        disableLogSpeed.addActionListener(new ActionListener(){
-                public void actionPerformed(java.awt.event.ActionEvent e){
+        disableLogSpeed.addActionListener(new ActionListener() {
+                @Override
+                public void actionPerformed(java.awt.event.ActionEvent e) {
                     minLogSpeed.setEnabled(disableLogSpeed.isSelected());
                 }
@@ -142 +142 @@
 
         disableLogDist = new JCheckBox(tr("Disable data logging if distance falls below"));
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridwidth = 1;
         c.weightx = 0.8;
@@ -152 +152 @@
         minLogDist = new IntegerTextField();
         minLogDist.setHorizontalAlignment(JTextField.RIGHT);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridwidth = 1;
         c.weightx = 1.5;
@@ -160 +160 @@
         add(minLogDist, c);
         Dimension x = minLogDist.getPreferredSize();
-        minLogDist.setPreferredSize(new Dimension((int)x.getWidth() + 50, (int)x.getHeight()));
-
-        disableLogDist.addActionListener(new ActionListener(){
-                public void actionPerformed(java.awt.event.ActionEvent e){
+        minLogDist.setPreferredSize(new Dimension((int) x.getWidth() + 50, (int) x.getHeight()));
+
+        disableLogDist.addActionListener(new ActionListener() {
+                @Override
+                public void actionPerformed(java.awt.event.ActionEvent e) {
                     minLogDist.setEnabled(disableLogDist.isSelected());
                 }
@@ -180 +181 @@
         group.add(aDist);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -187 +188 @@
         c.gridy = 3;
         add(aTime, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 4;
         add(aDist, c);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -198 +199 @@
         c.gridy = 3;
         add(aSeconds, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 4;
         add(aMeters, c);
@@ -206 +207 @@
         group.add(bDist);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -213 +214 @@
         c.gridy = 5;
         add(bTime, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 6;
         add(bDist, c);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -224 +225 @@
         c.gridy = 5;
         add(bSeconds, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 6;
         add(bMeters, c);
@@ -232 +233 @@
         group.add(cDist);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -239 +240 @@
         c.gridy = 7;
         add(cTime, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 8;
         add(cDist, c);
 
-        c.insets = new Insets(4,4,0,4);
+        c.insets = new Insets(4, 4, 0, 4);
         c.gridwidth = 1;
         c.weightx = 1;
@@ -250 +251 @@
         c.gridy = 7;
         add(cSeconds, c);
-        c.insets = new Insets(0,4,4,4);
+        c.insets = new Insets(0, 4, 4, 4);
         c.gridy = 8;
         add(cMeters, c);
@@ -258 +259 @@
         //add ID textbox
 
-
-
-        switch(conf.getLogFormat()){
+        switch(conf.getLogFormat()) {
         case 0:
             formatPosOnly.setSelected(true);
@@ -274 +273 @@
         }
 
-        if(conf.getSwATimeOrDist() == 0){
+        if (conf.getSwATimeOrDist() == 0) {
             aTime.setSelected(true);
             aDist.setSelected(false);
-        }else{
+        } else {
             aTime.setSelected(false);
             aDist.setSelected(true);
         }
 
-        if(conf.getSwBTimeOrDist() == 0){
+        if (conf.getSwBTimeOrDist() == 0) {
             bTime.setSelected(true);
             bDist.setSelected(false);
-        }else{
+        } else {
             bTime.setSelected(false);
             bDist.setSelected(true);
         }
 
-        if(conf.getSwCTimeOrDist() == 0){
+        if (conf.getSwCTimeOrDist() == 0) {
             cTime.setSelected(true);
             cDist.setSelected(false);
-        }else{
+        } else {
             cTime.setSelected(false);
             cDist.setSelected(true);
@@ -306 +305 @@
         cSeconds.setText("" + conf.getSwCTime() / 1000);
         cMeters.setText("" + conf.getSwCDist());
-
     }
 
@@ -312 +310 @@
      * Get the selected configuration.
      */
-    public Dg100Config getConfig(){
+    public Dg100Config getConfig() {
         conf.setDisableLogDist(disableLogDist.isSelected());
         conf.setDisableLogSpeed(disableLogSpeed.isSelected());
@@ -318 +316 @@
         conf.setSpeedThres(Integer.parseInt(minLogSpeed.getText()));
 
-        if(formatPosOnly.isSelected()){
-            conf.setLogFormat((byte)0);
-        }else if(formatPosTDS.isSelected()){
-            conf.setLogFormat((byte)1);
-        }else if(formatPosTDSA.isSelected()){
-            conf.setLogFormat((byte)2);
-        }
-
-        conf.setSwATimeOrDist((byte)(aDist.isSelected() ? 1 : 0));
-        conf.setSwBTimeOrDist((byte)(bDist.isSelected() ? 1 : 0));
-        conf.setSwCTimeOrDist((byte)(cDist.isSelected() ? 1 : 0));
+        if (formatPosOnly.isSelected()) {
+            conf.setLogFormat((byte) 0);
+        } else if (formatPosTDS.isSelected()) {
+            conf.setLogFormat((byte) 1);
+        } else if (formatPosTDSA.isSelected()) {
+            conf.setLogFormat((byte) 2);
+        }
+
+        conf.setSwATimeOrDist((byte) (aDist.isSelected() ? 1 : 0));
+        conf.setSwBTimeOrDist((byte) (bDist.isSelected() ? 1 : 0));
+        conf.setSwCTimeOrDist((byte) (cDist.isSelected() ? 1 : 0));
 
         conf.setSwATime(Integer.parseInt(aSeconds.getText()) * 1000);

applications/editors/josm/plugins/globalsat/src/org/openstreetmap/josm/plugins/globalsat/GlobalsatDg100.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 /**
  * Communicate with a GlobalSat DG-100 GPS mouse and data logger.
@@ -5 +6 @@
  */
 package org.openstreetmap.josm.plugins.globalsat;
-
-import gnu.io.CommPortIdentifier;
-import gnu.io.PortInUseException;
-import gnu.io.SerialPort;
-import gnu.io.UnsupportedCommOperationException;
 
 import java.io.IOException;
@@ -31 +27 @@
 import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 
+import gnu.io.CommPortIdentifier;
+import gnu.io.PortInUseException;
+import gnu.io.SerialPort;
+import gnu.io.UnsupportedCommOperationException;
+
 /**
  * @author ramack
  *
  */
-public class GlobalsatDg100
-{
-    public class ConnectionException extends Exception{
-        ConnectionException(Exception cause){
+public class GlobalsatDg100 {
+
+    public class ConnectionException extends Exception {
+        ConnectionException(Exception cause) {
             super(cause);
         }
-        ConnectionException(String msg){
+
+        ConnectionException(String msg) {
             super(msg);
         }
@@ -65 +67 @@
     };*/
     /** delete file: A0 A2 00 03 BA FF FF 02 B8 B0 B3 */
-    private static byte dg100CmdDelFile[] =
-    { (byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xBA
-      , (byte) 0xFF, (byte) 0xFF, (byte) 0x02, (byte) 0xB8, (byte) 0xB0, (byte) 0xB3
+    private static byte[] dg100CmdDelFile =
+    {(byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xBA,
+     (byte) 0xFF, (byte) 0xFF, (byte) 0x02, (byte) 0xB8, (byte) 0xB0, (byte) 0xB3
     };
     /** get file info: A0 A2 00 03 BB 00 00 00 BB B0 B3 */
-    private static byte dg100CmdGetFileInfo[] =
-    { (byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xBB
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0xBB, (byte) 0xB0, (byte) 0xB3
+    private static byte[] dg100CmdGetFileInfo =
+    {(byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xBB,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0xBB, (byte) 0xB0, (byte) 0xB3
     };
     /** get gps recs: A0 A2 00 03 B5 00 02 00 B7 B0 B3 */
-    private static byte dg100CmdGetGpsRecs[] =
-    { (byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xB5
-      , (byte) 0x00, (byte) 0x02, (byte) 0x00, (byte) 0xB7, (byte) 0xB0, (byte) 0xB3
+    private static byte[] dg100CmdGetGpsRecs =
+    {(byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x03, (byte) 0xB5,
+     (byte) 0x00, (byte) 0x02, (byte) 0x00, (byte) 0xB7, (byte) 0xB0, (byte) 0xB3
     };
     /** read config: A0 A2 00 01 B7 00 B7 B0 B3 */
-    private static byte dg100CmdGetConfig[] =
-    { (byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x01, (byte) 0xB7
-      , (byte) 0x00, (byte) 0xB7, (byte) 0xB0, (byte) 0xB3 };
+    private static byte[] dg100CmdGetConfig =
+    {(byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x01, (byte) 0xB7,
+     (byte) 0x00, (byte) 0xB7, (byte) 0xB0, (byte) 0xB3 };
     /** set config: A0 A2 00 2A B8 jj kk ll ll ll ll mm nn nn nn nn
         aa aa aa aa bb bb bb bb cc cc cc cc 00 00 gg hh
         ii dd dd dd dd ee ee ee ee ff ff ff ff 01 xx xx
         B0 B3 */
-    private static byte dg100CmdSetConfig[] =
-    { (byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x2A, (byte) 0xB8
-      , (byte) 0x02
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8
-      , (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8
-      , (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8
-      , (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00
-      , (byte) 0x01
-      , (byte) 0x00, (byte) 0x00, (byte) 0xB0, (byte) 0xB3
+    private static byte[] dg100CmdSetConfig =
+    {(byte) 0xA0, (byte) 0xA2, (byte) 0x00, (byte) 0x2A, (byte) 0xB8,
+     (byte) 0x02,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8,
+     (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8,
+     (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0xE8,
+     (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x00, (byte) 0x00, (byte) 0x00, (byte) 0x00,
+     (byte) 0x01,
+     (byte) 0x00, (byte) 0x00, (byte) 0xB0, (byte) 0xB3
     };
     /** read config: A0 A2 00 01 BF 00 BF B0 B3 */
@@ -121 +123 @@
     private boolean canceled = false;
 
-    public GlobalsatDg100(CommPortIdentifier portId){
+    public GlobalsatDg100(CommPortIdentifier portId) {
         this.portIdentifier = portId;
     }
 
-    public void cancel(){
+    public void cancel() {
         canceled = true;
         disconnect();
@@ -139 +141 @@
             GpxData result = null;
             canceled = false;
-            if(port == null){
+            if (port == null) {
                 connect();
             }
@@ -147 +149 @@
 
             progressMonitor.setTicksCount(gpsRecList.size());
-            if(gpsRecList.size() > 0){
+            if (gpsRecList.size() > 0) {
                 GpsRec last = null;
                 result = new GpxData();
                 Collection<WayPoint> seg = new ArrayList<>(100);
-                for(GpsRec r:gpsRecList){
-                    if(canceled){
+                for (GpsRec r:gpsRecList) {
+                    if (canceled) {
                         return result;
                     }
                     WayPoint p = wayPointFrom(r);
-                    if(r.equals(last)){
+                    if (r.equals(last)) {
                         result.waypoints.add(p);
-                    }else{
+                    } else {
                         seg.add(p);
                     }
@@ -172 +174 @@
     }
 
-    private WayPoint wayPointFrom(GpsRec r){
+    private WayPoint wayPointFrom(GpsRec r) {
         LatLon l = new LatLon(r.getLatitude(), r.getLongitude());
         WayPoint result = new WayPoint(l);
         result.attr.put("time", "" + r.getStringZuluTime());
         result.attr.put("speed", "" + r.getSpeed());
-        if(r.getDg100TypeOfCurRec() > 1)
+        if (r.getDg100TypeOfCurRec() > 1)
             result.attr.put("ele", "" + r.getAltitude());
         return result;
     }
 
-    public void deleteData() throws ConnectionException{
-        if(port == null){
+    public void deleteData() throws ConnectionException {
+        if (port == null) {
             connect();
         }
-        try{
+        try {
             sendCmdDelFiles();
-        }catch(Exception e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    public void disconnect(){
-        if(port != null){
+        } catch (Exception e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    public void disconnect() {
+        if (port != null) {
             port.close();
             port = null;
@@ -200 +202 @@
     }
 
-    private void connect() throws ConnectionException{
-        try{
-            port = (SerialPort)portIdentifier.open("DG100", TIMEOUT);
+    private void connect() throws ConnectionException {
+        try {
+            port = (SerialPort) portIdentifier.open("DG100", TIMEOUT);
             port.setSerialPortParams(115200, SerialPort.DATABITS_8,
                                      SerialPort.STOPBITS_2, SerialPort.PARITY_NONE);
             port.notifyOnOutputEmpty(false);
 
-        }catch(PortInUseException e){
-            throw new ConnectionException(e);
-        }catch(UnsupportedCommOperationException e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    private List<FileInfoRec> readFileInfoList() throws ConnectionException
-    {
+        } catch (PortInUseException e) {
+            throw new ConnectionException(e);
+        } catch (UnsupportedCommOperationException e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    private List<FileInfoRec> readFileInfoList() throws ConnectionException {
         int nextIdx = 0;
         List<FileInfoRec> result = new ArrayList<>(64);
-        try{
-            do{
+        try {
+            do {
                 Response<FileInfoRec> response = sendCmdGetFileInfo(nextIdx);
                 nextIdx = response.getNextIdx();
@@ -225 +226 @@
             } while (nextIdx > 0);
             return result;
-        }catch(Exception e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    public List<GpsRec> readGpsRecList(List<FileInfoRec> fileInfoList) throws ConnectionException
-    {
+        } catch (Exception e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    public List<GpsRec> readGpsRecList(List<FileInfoRec> fileInfoList) throws ConnectionException {
         List<GpsRec> result = new ArrayList<>(200);
 
-        try{
-            for(FileInfoRec fileInfoRec:fileInfoList){
+        try {
+            for (FileInfoRec fileInfoRec:fileInfoList) {
                 Response<GpsRec> response = sendCmdGetGpsRecs(fileInfoRec.getIdx());
                 result.addAll(response.getRecs());
             }
             return result;
-        }catch(Exception e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    private Response<?> sendCmdDelFiles() throws IOException, UnsupportedCommOperationException
-    {
+        } catch (Exception e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    private Response<?> sendCmdDelFiles() throws IOException, UnsupportedCommOperationException {
         System.out.println("deleting data...");
         int len = sendCmd(dg100CmdDelFile, response, -1);
@@ -253 +252 @@
 
     @SuppressWarnings("unchecked")
-    private Response<FileInfoRec> sendCmdGetFileInfo(int idx) throws IOException, UnsupportedCommOperationException
-    {
+    private Response<FileInfoRec> sendCmdGetFileInfo(int idx) throws IOException, UnsupportedCommOperationException {
         byte[] src = dg100CmdGetFileInfo;
         ByteBuffer buf = ByteBuffer.wrap(src);
         buf.position(5);
-        buf.putShort((short)idx); // index of first file info rec to be read
+        buf.putShort((short) idx); // index of first file info rec to be read
         updateCheckSum(buf);
         int len = sendCmd(src, response, -1);
@@ -264 +262 @@
     }
 
-    private Response<?> sendCmdGetConfig() throws IOException, UnsupportedCommOperationException
-    {
+    private Response<?> sendCmdGetConfig() throws IOException, UnsupportedCommOperationException {
         byte[] src = dg100CmdGetConfig;
         int len = sendCmd(src, response, -1);
@@ -271 +268 @@
     }
 
-    public Dg100Config getConfig() throws ConnectionException{
-        try{
-            if(port == null){
+    public Dg100Config getConfig() throws ConnectionException {
+        try {
+            if (port == null) {
                 connect();
             }
             return sendCmdGetConfig().getConfig();
-        }catch(Exception e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    private void sendCmdSetConfig(Dg100Config config) throws IOException, UnsupportedCommOperationException
-    {
+        } catch (Exception e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    private void sendCmdSetConfig(Dg100Config config) throws IOException, UnsupportedCommOperationException {
         byte[] src = dg100CmdSetConfig;
         ByteBuffer buf = ByteBuffer.wrap(src);
-        if (config != null){
+        if (config != null) {
             config.write(buf);
         }
@@ -295 +291 @@
     }
 
-    public void setConfig(Dg100Config conf) throws ConnectionException{
-        try{
+    public void setConfig(Dg100Config conf) throws ConnectionException {
+        try {
             sendCmdSetConfig(conf);
-        }catch(Exception e){
-            throw new ConnectionException(e);
-        }
-    }
-
-    public boolean isCanceled(){
+        } catch (Exception e) {
+            throw new ConnectionException(e);
+        }
+    }
+
+    public boolean isCanceled() {
         return canceled;
     }
 
     @SuppressWarnings("unchecked")
-    private Response<GpsRec> sendCmdGetGpsRecs(int idx) throws IOException, UnsupportedCommOperationException
-    {
+    private Response<GpsRec> sendCmdGetGpsRecs(int idx) throws IOException, UnsupportedCommOperationException {
         byte[] src = dg100CmdGetGpsRecs;
         ByteBuffer buf = ByteBuffer.wrap(src);
         buf.position(5);
-        buf.putShort((short)idx); // index of first chunk of gps recs to be read
+        buf.putShort((short) idx); // index of first chunk of gps recs to be read
         updateCheckSum(buf);
         int len = sendCmd(src, response, 2074);
@@ -319 +314 @@
     }
 
-    /**
-     *
-     * @param buf
-     */
-    private void updateCheckSum(ByteBuffer buf)
-    {
+    private void updateCheckSum(ByteBuffer buf) {
         buf.position(2);
         short len = buf.getShort();
         int sum = 0;
-        for (int ii = 0 ; ii < len ; ++ii){
+        for (int ii = 0; ii < len; ++ii) {
             sum += ByteHelper.byte2IntUnsigned(buf.get());
         }
         sum = sum & 0x7FFF;
-        buf.putShort((short)sum);
-    }
-
-    private int sendCmd(byte cmdAndArgs[], byte response[], int bytesToRead) throws IOException, UnsupportedCommOperationException
-    {
+        buf.putShort((short) sum);
+    }
+
+    private int sendCmd(byte[] cmdAndArgs, byte[] response, int bytesToRead) throws IOException, UnsupportedCommOperationException {
 
         int cntBytTot = 0;
@@ -349 +338 @@
     }
 
-
-    private int readResponse(byte[] response, int bytesToRead) throws IOException, UnsupportedCommOperationException
-    {
+    private int readResponse(byte[] response, int bytesToRead) throws IOException, UnsupportedCommOperationException {
         byte[] readBuffer = new byte[200];
         int responsePos = 0;
@@ -359 +346 @@
         int cntBytTot = 0;
         InputStream inputStream = port.getInputStream();
-        if (inputStream != null){
+        if (inputStream != null) {
             ByteBuffer buf = ByteBuffer.wrap(response);
             port.enableReceiveThreshold(2); // read at least 2 byte
             boolean a0A2Received = false;
-            while (! a0A2Received){
+            while (!a0A2Received) {
                 response[0] = response[1];
                 int rcvd = inputStream.read(response, 1, 1);
-                if (rcvd == 0){
+                if (rcvd == 0) {
                     return 0;
                 }
-                a0A2Received = (response[0] == (byte)0xa0 && response[1] == (byte)0xa2);
+                a0A2Received = (response[0] == (byte) 0xa0 && response[1] == (byte) 0xa2);
             }
             // we already have read 2 bytes
@@ -376 +363 @@
             // read interesting data
             port.enableReceiveThreshold(2); // read at least 2 bytes
-            while (bytesToRead < 0 || (bytesToRead >= 0 && cntBytTot < bytesToRead)){
+            while (bytesToRead < 0 || (bytesToRead >= 0 && cntBytTot < bytesToRead)) {
                 int cntBytAct = 0;
                 cntBytAct = inputStream.read(readBuffer);
@@ -382 +369 @@
                 // copy readBuffer to response
                 responsePos = ByteHelper.copyByteArr2ByteArr(readBuffer, 0, cntBytAct, response, responsePos);
-                if (!headerReceived && cntBytTot >= 4){
+                if (!headerReceived && cntBytTot >= 4) {
                     // do we have enough bytes to extract bytesToRead
-                    if (bytesToRead == -1){
+                    if (bytesToRead == -1) {
                         // get bytesToRead from response
                         buf.position(2); // here starts length of payload
@@ -392 +379 @@
                     headerReceived = true;
                 }
-                if (cntBytAct == 0){
+                if (cntBytAct == 0) {
                     break;
                 }

applications/editors/josm/plugins/globalsat/src/org/openstreetmap/josm/plugins/globalsat/GlobalsatImportDialog.java

@@ -1 @@
-// License: GPL v2 or later. Copyright 2007 by Raphael Mack, Immanuel Scholz and others
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.globalsat;
 
 import static org.openstreetmap.josm.tools.I18n.tr;
-import gnu.io.CommPortIdentifier;
 
 import java.awt.GridBagConstraints;
@@ -23 +22 @@
 import org.openstreetmap.josm.Main;
 
+import gnu.io.CommPortIdentifier;
+
 /**
  * Main download dialog.
  *
- * @author Raphael Mack <ramack@raphael-mack.de>
+ * @author Raphael Mack &lt;ramack@raphael-mack.de&gt;
  *
  */
@@ -41 +42 @@
 
         portCombo = new JComboBox<>();
-        portCombo.setRenderer(new ListCellRenderer<CommPortIdentifier>(){
-                public java.awt.Component getListCellRendererComponent(JList<? extends CommPortIdentifier> list, CommPortIdentifier o, int x, boolean a, boolean b){
+        portCombo.setRenderer(new ListCellRenderer<CommPortIdentifier>() {
+                @Override
+                public java.awt.Component getListCellRendererComponent(JList<? extends CommPortIdentifier> list,
+                        CommPortIdentifier o, int x, boolean a, boolean b) {
                     String value = o.getName();
-                    if(value == null){
+                    if (value == null) {
                         value = "null";
                     }
@@ -50 +53 @@
                 }
             });
-        portCombo.addActionListener(new ActionListener(){
-                public void actionPerformed(java.awt.event.ActionEvent e){
+        portCombo.addActionListener(new ActionListener() {
+                @Override
+                public void actionPerformed(java.awt.event.ActionEvent e) {
                     Object i = portCombo.getSelectedItem();
-                    if(i instanceof CommPortIdentifier){
-                        GlobalsatPlugin.setPortIdent((CommPortIdentifier)i);
-                        Main.pref.put("globalsat.portIdentifier", ((CommPortIdentifier)i).getName());
+                    if (i instanceof CommPortIdentifier) {
+                        GlobalsatPlugin.setPortIdent((CommPortIdentifier) i);
+                        Main.pref.put("globalsat.portIdentifier", ((CommPortIdentifier) i).getName());
                     }
                 }
@@ -61 +65 @@
 
         refreshPorts();
-        c.insets = new Insets(4,4,4,4);
+        c.insets = new Insets(4, 4, 4, 4);
         c.gridwidth = 1;
         c.weightx = 0.8;
@@ -76 +80 @@
 
         refreshBtn = new JButton(tr("Refresh"));
-        refreshBtn.addActionListener(new ActionListener(){
-                public void actionPerformed(java.awt.event.ActionEvent e){
+        refreshBtn.addActionListener(new ActionListener() {
+                @Override
+                public void actionPerformed(java.awt.event.ActionEvent e) {
                     refreshPorts();
                 }
@@ -90 +95 @@
 
         configBtn = new JButton(tr("Configure"));
-        configBtn.addActionListener(new ActionListener(){
-                public void actionPerformed(java.awt.event.ActionEvent e){
+        configBtn.addActionListener(new ActionListener() {
+                @Override
+                public void actionPerformed(java.awt.event.ActionEvent e) {
                     System.out.println("configureing the device");
-                    try{
+                    try {
 
                         GlobalsatConfigDialog dialog = new GlobalsatConfigDialog(GlobalsatPlugin.dg100().getConfig());
@@ -99 +105 @@
                         JDialog dlg = pane.createDialog(Main.parent, tr("Configure Device"));
                         dlg.setVisible(true);
-                        if(((Integer)pane.getValue()) == JOptionPane.OK_OPTION){
+                        if (((Integer) pane.getValue()) == JOptionPane.OK_OPTION) {
                             GlobalsatPlugin.dg100().setConfig(dialog.getConfig());
                         }
                         dlg.dispose();
 
-                    }catch(GlobalsatDg100.ConnectionException ex){
+                    } catch (GlobalsatDg100.ConnectionException ex) {
                         JOptionPane.showMessageDialog(Main.parent, tr("Connection Error.") + " " + ex.toString());
                     }
@@ -129 +135 @@
     }
 
-    public void refreshPorts(){
+    public void refreshPorts() {
         String sel = Main.pref.get("globalsat.portIdentifier");
         portCombo.setVisible(false);
@@ -135 +141 @@
 
         Enumeration<?> e = CommPortIdentifier.getPortIdentifiers();
-        for(e = CommPortIdentifier.getPortIdentifiers(); e.hasMoreElements(); ){
-            CommPortIdentifier port = (CommPortIdentifier)e.nextElement();
-            if(port.getPortType() == CommPortIdentifier.PORT_SERIAL){
+        for (e = CommPortIdentifier.getPortIdentifiers(); e.hasMoreElements();) {
+            CommPortIdentifier port = (CommPortIdentifier) e.nextElement();
+            if (port.getPortType() == CommPortIdentifier.PORT_SERIAL) {
                 portCombo.addItem(port);
-                if(sel != null && port.getName() == sel){
+                if (sel != null && port.getName() == sel) {
                     portCombo.setSelectedItem(port);
                     GlobalsatPlugin.setPortIdent(port);
@@ -150 +156 @@
     }
 
-    public boolean deleteFilesAfterDownload(){
+    public boolean deleteFilesAfterDownload() {
         return delete.isSelected();
     }
 
-    public CommPortIdentifier getPort(){
-        return (CommPortIdentifier)portCombo.getSelectedItem();
+    public CommPortIdentifier getPort() {
+        return (CommPortIdentifier) portCombo.getSelectedItem();
     }
 }

applications/editors/josm/plugins/globalsat/src/org/openstreetmap/josm/plugins/globalsat/GlobalsatPlugin.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.globalsat;
 /// @author Raphael Mack <ramack@raphael-mack.de>
 import static org.openstreetmap.josm.tools.I18n.tr;
-import gnu.io.CommPortIdentifier;
 
 import java.awt.GraphicsEnvironment;
@@ -23 +23 @@
 import org.xml.sax.SAXException;
 
+import gnu.io.CommPortIdentifier;
+
 public class GlobalsatPlugin extends Plugin {
     private static GlobalsatDg100 device = null;
-    public static GlobalsatDg100 dg100(){
+    public static GlobalsatDg100 dg100() {
         return device;
     }
 
-    public static void setPortIdent(CommPortIdentifier port){
-        if(device != null){
+    public static void setPortIdent(CommPortIdentifier port) {
+        if (device != null) {
             device.disconnect();
         }
@@ -41 +43 @@
         private boolean deleteAfter;
 
-        public ImportTask(boolean delete){
+        ImportTask(boolean delete) {
             super(tr("Importing data from device."));
             deleteAfter = delete;
@@ -48 +50 @@
         @Override public void realRun() throws IOException, SAXException {
             progressMonitor.subTask(tr("Importing data from DG100..."));
-            try{
+            try {
                 data = GlobalsatPlugin.dg100().readData(progressMonitor.createSubTaskMonitor(ProgressMonitor.ALL_TICKS, true));
-            }catch(Exception e){
+            } catch (Exception e) {
                 eee = e;
             }
@@ -56 +58 @@
 
         @Override protected void finish() {
-            if(deleteAfter && GlobalsatPlugin.dg100().isCanceled() == false){
+            if (deleteAfter && GlobalsatPlugin.dg100().isCanceled() == false) {
                 Main.pref.put("globalsat.deleteAfterDownload", true);
-                try{
+                try {
                     GlobalsatPlugin.dg100().deleteData();
-                }catch(Exception ex){
+                } catch (Exception ex) {
                     JOptionPane.showMessageDialog(Main.parent, tr("Error deleting data.") + " " + ex.toString());
                 }
-            }else{
+            } else {
                 Main.pref.put("globalsat.deleteAfterDownload", false);
             }
-            if(data != null && data.hasTrackPoints()){
+            if (data != null && data.hasTrackPoints()) {
                 Main.getLayerManager().addLayer(new GpxLayer(data, tr("imported data from {0}", "DG 100")));
                 Main.map.repaint();
-            }else{
+            } else {
                 JOptionPane.showMessageDialog(Main.parent, tr("No data found on device."));
             }
-            if(eee != null){
+            if (eee != null) {
                 eee.printStackTrace();
                 System.out.println(eee.getMessage());
@@ -94 +96 @@
         } catch (UnsatisfiedLinkError e) {
             error = true;
+            // CHECKSTYLE.OFF: LineLength
             String msg = tr("Cannot load library rxtxSerial. If you need support to install it try Globalsat homepage at http://www.raphael-mack.de/josm-globalsat-gpx-import-plugin/");
+            // CHECKSTYLE.ON: LineLength
             Main.error(msg);
             if (!GraphicsEnvironment.isHeadless()) {
-                JOptionPane.showMessageDialog(Main.parent, "<html>" + msg + "</html>");
+                JOptionPane.showMessageDialog(Main.parent, "<html>" + msg + "</html>");
             }
         }
@@ -106 +110 @@
     }
 
-    class GlobalsatImportAction extends JosmAction{
-        public GlobalsatImportAction(){
+    class GlobalsatImportAction extends JosmAction {
+        GlobalsatImportAction() {
             super(tr("Globalsat Import"), "globalsatImport",
             tr("Import Data from Globalsat Datalogger DG100 into GPX layer."),
@@ -113 +117 @@
             KeyEvent.VK_G, Shortcut.ALT_CTRL), false);
         }
-        public void actionPerformed(ActionEvent e){
+
+        @Override
+        public void actionPerformed(ActionEvent e) {
             GlobalsatImportDialog dialog = new GlobalsatImportDialog();
             JOptionPane pane = new JOptionPane(dialog, JOptionPane.PLAIN_MESSAGE, JOptionPane.OK_CANCEL_OPTION);
             JDialog dlg = pane.createDialog(Main.parent, tr("Import"));
             dlg.setVisible(true);
-            if(((Integer)pane.getValue()) == JOptionPane.OK_OPTION){
+            if (((Integer) pane.getValue()) == JOptionPane.OK_OPTION) {
                 setPortIdent(dialog.getPort());
                 ImportTask task = new ImportTask(dialog.deleteFilesAfterDownload());

applications/editors/josm/plugins/globalsat/src/org/openstreetmap/josm/plugins/globalsat/SingleSegmentGpxTrack.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.globalsat;
 
@@ -19 +20 @@
     }
 
+    @Override
     public Map<String, Object> getAttributes() {
         return attr;
     }
 
+    @Override
     public Bounds getBounds() {
         return trackSegment.getBounds();
     }
 
+    @Override
     public Collection<GpxTrackSegment> getSegments() {
         return Collections.singleton(trackSegment);
     }
 
+    @Override
     public double length() {
         return trackSegment.length();