Changeset 32644 in osm for applications/editors/josm/plugins/waypoint_search

Timestamp:

2016-07-12T21:19:35+02:00 (8 years ago)

Author:

donvip

Message:

fix #josm13136 - ArrayIndexOutOfBoundsException

File:

• applications/editors/josm/plugins/waypoint_search/src/org/openstreetmap/josm/plugins/waypointSearch/SelectWaypointDialog.java (modified) (4 diffs)

applications/editors/josm/plugins/waypoint_search/src/org/openstreetmap/josm/plugins/waypointSearch/SelectWaypointDialog.java

@@ -31 +31 @@
     private DefaultListModel<String> listModel = new DefaultListModel<>();
     private JList<String> searchResult = new JList<>(listModel);
-    private List<Marker> searchResultObjectCache = new ArrayList<>();
+    private transient List<Marker> searchResultObjectCache = new ArrayList<>();
     private boolean firstTimeSearch = true;
 
@@ -81 +81 @@
 
     @Override
-    public void keyPressed(KeyEvent arg0) {
+    public void keyPressed(KeyEvent e) {
         // Do nothing
     }
 
     @Override
-    public void keyReleased(KeyEvent arg0) {
+    public void keyReleased(KeyEvent e) {
         updateSearchResults();
     }
 
     @Override
-    public void keyTyped(KeyEvent arg0) {
+    public void keyTyped(KeyEvent e) {
         firstTimeSearch = false;
     }
@@ -99 +99 @@
         if (e.getSource() == searchResult) {
             //click on the search result box
-            Marker marker = searchResultObjectCache.get(searchResult.getSelectedIndex());
-            Main.map.mapView.zoomTo(marker.getCoor());
+            int idx = searchResult.getSelectedIndex();
+            if (idx >= 0) {
+                Marker marker = searchResultObjectCache.get(idx);
+                Main.map.mapView.zoomTo(marker.getCoor());
+            }
         }
     }
 
     @Override
-    public void mouseEntered(MouseEvent arg0) {
+    public void mouseEntered(MouseEvent e) {
         // Do nothing
     }
 
     @Override
-    public void mouseExited(MouseEvent arg0) {
+    public void mouseExited(MouseEvent e) {
         // Do nothing
     }
 
     @Override
-    public void mousePressed(MouseEvent arg0) {
+    public void mousePressed(MouseEvent e) {
         if (searchPattern.getSelectedText() == null) {
             searchPattern.selectAll();
@@ -122 +125 @@
 
     @Override
-    public void mouseReleased(MouseEvent arg0) {
+    public void mouseReleased(MouseEvent e) {
         // Do nothing
     }