Changeset 32634 in osm

Timestamp:

2016-07-11T19:31:32+02:00 (9 years ago)

Author:

simon04

Message:

JOSM/wikipedia: propose specified wikidata keys, only wikidata keys - #josm12039

File:

• applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikidataItemSearchDialog.java (modified) (5 diffs)

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikidataItemSearchDialog.java

@@ -9 +9 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
+import java.util.Collection;
 import java.util.Collections;
+import java.util.HashSet;
 import java.util.List;
 import java.util.Locale;
+import java.util.TreeSet;
 import java.util.concurrent.Executors;
 import java.util.concurrent.TimeUnit;
@@ -22 +25 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.JosmAction;
+import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Tag;
 import org.openstreetmap.josm.gui.ExtendedDialog;
@@ -29 +33 @@
 import org.openstreetmap.josm.gui.widgets.SearchTextResultListPanel;
 import org.openstreetmap.josm.tools.GBC;
+import org.openstreetmap.josm.tools.Predicate;
 import org.openstreetmap.josm.tools.Utils;
 
@@ -47 +52 @@
         });
         this.targetKey = new AutoCompletingComboBox();
+        this.targetKey.setEditable(true);
         this.targetKey.setSelectedItem(new AutoCompletionListItem("wikidata"));
 
@@ -77 +83 @@
 
     private void initTargetKeys() {
-        final List<AutoCompletionListItem> keys = Main.getLayerManager().getEditLayer().data.getAutoCompletionManager().getKeys();
+        final DataSet editDataSet = Main.getLayerManager().getEditDataSet();
+        if (editDataSet == null) {
+            return;
+        }
+        final Collection<AutoCompletionListItem> keys = new TreeSet<>();
+        // from http://wiki.openstreetmap.org/wiki/Proposed_features/Wikidata#Tagging
+        keys.add(new AutoCompletionListItem("wikidata"));
+        keys.add(new AutoCompletionListItem("operator:wikidata"));
+        keys.add(new AutoCompletionListItem("brand:wikidata"));
+        keys.add(new AutoCompletionListItem("architect:wikidata"));
+        keys.add(new AutoCompletionListItem("artist:wikidata"));
+        keys.add(new AutoCompletionListItem("subject:wikidata"));
+        keys.add(new AutoCompletionListItem("name:etymology:wikidata"));
+        keys.addAll(Utils.filter(editDataSet.getAutoCompletionManager().getKeys(), new Predicate<AutoCompletionListItem>() {
+            @Override
+            public boolean evaluate(AutoCompletionListItem object) {
+                return object.getValue().contains("wikidata");
+            }
+        }));
         targetKey.setPossibleACItems(keys);
-        targetKey.setEditable(true);
     }