Changeset 32549 in osm for applications/editors/josm/plugins/namemanager

Timestamp:

2016-07-04T09:23:54+02:00 (8 years ago)

Author:

donvip

Message:

checkstyle

Location:

applications/editors/josm/plugins/namemanager

Files:

• .checkstyle (added)
• .project (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/namemanager/NameManagerPlugin.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/namemanager/countryData/Country.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/namemanager/countryData/CountryDataMemory.java (modified) (2 diffs)
• src/org/openstreetmap/josm/plugins/namemanager/dialog/NameManagerDialog.java (modified) (6 diffs)
• src/org/openstreetmap/josm/plugins/namemanager/listeners/NameManagerAction.java (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/namemanager/utils/NameManagerUtils.java (modified) (2 diffs)

applications/editors/josm/plugins/namemanager/.project

@@ -16 +16 @@
                         </arguments>
                 </buildCommand>
+                <buildCommand>
+                        <name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
+                        <arguments>
+                        </arguments>
+                </buildCommand>
         </buildSpec>
         <natures>
                 <nature>org.eclipse.jdt.core.javanature</nature>
+                <nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
         </natures>
 </projectDescription>

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/NameManagerPlugin.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager;
 

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/countryData/Country.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager.countryData;
 

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/countryData/CountryDataMemory.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager.countryData;
 
@@ -4 +5 @@
 import java.util.Map;
 
-public class CountryDataMemory {
+public final class CountryDataMemory {
 
     private static Map<String, Country> countryCache;
+    
+    private CountryDataMemory() {
+        // Hide default constructor for utilities classes
+    }
 
     public static void instantiateCountryCache() {

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/dialog/NameManagerDialog.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager.dialog;
 
@@ -55 +56 @@
  * 
  */
-public class NameManagerDialog extends JDialog {
+public final class NameManagerDialog extends JDialog {
 
     private static final String TAG_NAME = "Tag name";
@@ -382 +383 @@
     class AddModifyAction extends AbstractAction {
 
-        public AddModifyAction() {
+        AddModifyAction() {
             putValue(Action.NAME, tr(ADD) + "/" + tr(EDIT));
             ImageIcon addModifyIcon = ImageProvider.get("", "addnode");
@@ -408 +409 @@
     class DeleteAction extends AbstractAction {
 
-        public DeleteAction() {
+        DeleteAction() {
             putValue(Action.NAME, tr(DELETE));
             ImageIcon deleteIcon = ImageProvider.get("", "purge");
@@ -434 +435 @@
     class CancelAction extends AbstractAction {
 
-        public CancelAction() {
+        CancelAction() {
             putValue(Action.NAME, tr("Cancel"));
             putValue(Action.ACCELERATOR_KEY, KeyStroke.getKeyStroke(KeyEvent.VK_ESCAPE, 0));
@@ -451 +452 @@
     class SaveAction extends AbstractAction {
 
-        public SaveAction() {
+        SaveAction() {
             putValue(Action.NAME, tr("Save"));
             putValue(Action.ACCELERATOR_KEY, KeyStroke.getKeyStroke(KeyEvent.VK_ENTER, 0));

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/listeners/NameManagerAction.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager.listeners;
 

applications/editors/josm/plugins/namemanager/src/org/openstreetmap/josm/plugins/namemanager/utils/NameManagerUtils.java

@@ +1 @@
+// License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.plugins.namemanager.utils;
 
@@ -26 +27 @@
 import org.xml.sax.SAXException;
 
-public class NameManagerUtils {
+public final class NameManagerUtils {
+
+    private NameManagerUtils() {
+        // Hide default constructor for utilities classes
+    }
+
     /**
      * @return the top {@link Window} of the JOSM application.