Changeset 32382 in osm

Timestamp:

2016-06-23T17:42:36+02:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Fix bug in MapillaryAbstractImage.isModified()

Turned images were labeled unmodified and unturned images on the other hand were labeled modified.

This patch has been supplied by peterneubauer<peter@…>.

Location:

applications/editors/josm/plugins/mapillary

Files:

• src/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImage.java (modified) (1 diff)
• test/unit/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImageTest.java (modified) (2 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImage.java

@@ -168 +168 @@
    */
   public boolean isModified() {
-    return !this.getLatLon().equals(this.latLon) || Math.abs(this.getCa() - this.ca) < EPSILON;
+    return !this.getLatLon().equals(this.latLon) || Math.abs(this.getCa() - this.ca) > EPSILON;
   }
 

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImageTest.java

@@ -5 +5 @@
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
 
 import java.util.TimeZone;
@@ -51 +53 @@
   }
 
+  @Test
+  public void testIsModified() {
+    MapillaryImage img = new MapillaryImage("key___________________", new LatLon(0, 0), 0);
+    assertFalse(img.isModified());
+    img.turn(1e-4);
+    img.stopMoving();
+    assertTrue(img.isModified());
+    img.turn(-1e-4);
+    img.stopMoving();
+    assertFalse(img.isModified());
+    img.move(1e-4, 1e-4);
+    img.stopMoving();
+    assertTrue(img.isModified());
+    img.move(-1e-4, -1e-4);
+    img.stopMoving();
+    assertFalse(img.isModified());
+  }
 }