Changeset 3223 in josm for trunk/src/org/openstreetmap

Timestamp:

2010-05-08T19:29:43+02:00 (15 years ago)

Author:

jttt

Message:

Fix #4846 emptying toolbar causes autimatic refill

File:

• trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java (modified) (13 diffs)

trunk/src/org/openstreetmap/josm/gui/preferences/ToolbarPreferences.java

@@ -21 +21 @@
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedList;
@@ -46 +47 @@
 import javax.swing.event.ListSelectionEvent;
 import javax.swing.event.ListSelectionListener;
+import javax.swing.event.TreeSelectionEvent;
+import javax.swing.event.TreeSelectionListener;
 import javax.swing.table.AbstractTableModel;
 import javax.swing.tree.DefaultMutableTreeNode;
@@ -61 +64 @@
 
 public class ToolbarPreferences implements PreferenceSettingFactory {
+
+
+    private static final String EMPTY_TOOLBAR_MARKER = "<!-empty-!>";
 
     public static class ActionDefinition {
@@ -283 +289 @@
                         } else if (node.getUserObject() instanceof Action) {
                             selected.add(leadItem++, new ActionDefinition((Action)node.getUserObject()));
+
                         }
                     }
@@ -346 +353 @@
         private JButton upButton;
         private JButton downButton;
+        private JButton removeButton;
+        private JButton addButton;
 
         private String movingComponent;
@@ -366 +375 @@
             b.setActionCommand(name);
             return b;
+        }
+
+        private void updateEnabledState() {
+            int index = selectedList.getSelectedIndex();
+            upButton.setEnabled(index > 0);
+            downButton.setEnabled(index < selectedList.getModel().getSize() - 1);
+            removeButton.setEnabled(index != -1);
+            addButton.setEnabled(actionsTree.getSelectionCount() > 0);
         }
 
@@ -416 +433 @@
                         actionParametersPanel.setVisible(actionParametersModel.getRowCount() > 0);
                     }
-                    upButton.setEnabled(sel);
-                    downButton.setEnabled(sel);
+                    updateEnabledState();
                 }
             });
@@ -461 +477 @@
                         int dataLength = draggedData.size();
 
+
                         if (leadItem != null) {
                             for (Object o: draggedData) {
                                 if (leadItem.equals(o))
                                     return false;
+
                             }
                         }
@@ -553 +571 @@
             });
             actionsTree.setDragEnabled(true);
+            actionsTree.getSelectionModel().addTreeSelectionListener(new TreeSelectionListener() {
+                public void valueChanged(TreeSelectionEvent e) {
+                    updateEnabledState();
+                }
+            });
 
             final JPanel left = new JPanel(new GridBagLayout());
@@ -564 +587 @@
             final JPanel buttons = new JPanel(new GridLayout(6,1));
             buttons.add(upButton = createButton("up"));
-            buttons.add(createButton("<"));
-            buttons.add(createButton(">"));
+            buttons.add(addButton = createButton("<"));
+            buttons.add(removeButton = createButton(">"));
             buttons.add(downButton = createButton("down"));
-            upButton.setEnabled(false);
-            downButton.setEnabled(false);
+            updateEnabledState();
 
             final JPanel p = new JPanel();
@@ -621 +643 @@
             for (int i = 0; i < selected.size(); ++i) {
                 if (selected.get(i) == ActionDefinition.SEPARATOR) {
+
                     t.add("|");
+
                 } else {
                     t.add(parser.saveAction((ActionDefinition)(selected.get(i))));
                 }
+            }
+            if (t.isEmpty()) {
+                t = Collections.singletonList(EMPTY_TOOLBAR_MARKER);
             }
             Main.pref.putCollection("toolbar", t);
@@ -685 +712 @@
 
     private static Collection<String> getToolString() {
+
         Collection<String> toolStr = Main.pref.getCollection("toolbar", Arrays.asList(deftoolbar));
         if (toolStr == null || toolStr.size() == 0) {
@@ -735 +763 @@
             if (action == ActionDefinition.SEPARATOR) {
                 control.addSeparator();
+
             } else {
                 Action a = action.getParametrizedAction();