Changeset 32211 in osm for applications/editors/josm/plugins/cadastre-fr

Timestamp:

2016-06-01T00:55:28+02:00 (9 years ago)

Author:

donvip

Message:

sonar - fix many issues

Location:

applications/editors/josm/plugins/cadastre-fr

Files:

• .settings/org.eclipse.jdt.core.prefs (modified) (1 diff)
• .settings/org.eclipse.jdt.ui.prefs (added)
• src/cadastre_fr/Address.java (modified) (17 diffs)
• src/cadastre_fr/CacheControl.java (modified) (9 diffs)
• src/cadastre_fr/CacheFileLambert4ZoneFilter.java (modified) (4 diffs)
• src/cadastre_fr/CadastreGrabber.java (modified) (3 diffs)
• src/cadastre_fr/CadastreInterface.java (modified) (30 diffs)
• src/cadastre_fr/CadastreSessionImporter.java (modified) (1 diff)
• src/cadastre_fr/DownloadSVGBuilding.java (modified) (8 diffs)
• src/cadastre_fr/DownloadSVGTask.java (modified) (9 diffs)
• src/cadastre_fr/MenuActionLoadFromCache.java (modified) (3 diffs)
• src/cadastre_fr/WMSLayer.java (modified) (21 diffs)

applications/editors/josm/plugins/cadastre-fr/.settings/org.eclipse.jdt.core.prefs

@@ -112 +112 @@
 org.eclipse.jdt.core.compiler.problem.varargsArgumentNeedCast=warning
 org.eclipse.jdt.core.compiler.source=1.7
+org.eclipse.jdt.core.javaFormatter=org.eclipse.jdt.core.defaultJavaFormatter

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/Address.java

@@ -14 +14 @@
 import java.awt.event.KeyEvent;
 import java.awt.event.MouseEvent;
-import java.awt.event.MouseListener;
-import java.awt.event.MouseMotionListener;
+import java.awt.event.WindowAdapter;
 import java.awt.event.WindowEvent;
-import java.awt.event.WindowListener;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -63 +61 @@
 import org.openstreetmap.josm.tools.Shortcut;
 
-public class Address extends MapMode implements MouseListener, MouseMotionListener, ActionListener {
+public class Address extends MapMode {
 
     // perhaps make all these tags configurable in the future
@@ -76 +74 @@
     private String relationMemberHouse = "house";
 
-    private JRadioButton plus_one = new JRadioButton("+1", false);
-    private JRadioButton plus_two = new JRadioButton("+2", true); // enable this by default
-    private JRadioButton minus_one = new JRadioButton("-1", false);
-    private JRadioButton minus_two = new JRadioButton("-2", false);
+    private JRadioButton plusOne = new JRadioButton("+1", false);
+    private JRadioButton plusTwo = new JRadioButton("+2", true); // enable this by default
+    private JRadioButton minusOne = new JRadioButton("-1", false);
+    private JRadioButton minusTwo = new JRadioButton("-2", false);
     final JCheckBox tagPolygon = new JCheckBox(tr("on polygon"));
 
-    JDialog dialog = null;
-    JButton clearButton = null;
+    JDialog dialog;
+    JButton clearButton;
     final JTextField inputNumber = new JTextField();
     final JTextField inputStreet = new JTextField();
     JLabel link = new JLabel();
-    private Way selectedWay;
+    private transient Way selectedWay;
     private boolean shift;
     private boolean ctrl;
@@ -114 +112 @@
 //        dialog.setVisible(false);
         // kill the window completely to fix an issue on some linux distro and full screen mode.
-        if(dialog != null)
-        {
+        if(dialog != null) {
             dialog.dispose();
             dialog = null;
@@ -131 +128 @@
         List<Way> mouseOnExistingWays = new ArrayList<>();
         List<Way> mouseOnExistingBuildingWays = new ArrayList<>();
-        mouseOnExistingWays = new ArrayList<>();
         Node currentMouseNode = mv.getNearestNode(mousePos, OsmPrimitive.isSelectablePredicate);
         if (currentMouseNode != null) {
@@ -140 +136 @@
                     && currentMouseNode.get(tagHouseStreet) == null
                     && findWayInRelationAddr(currentMouseNode) == null
-                    && !inputStreet.getText().equals("")) {
+                    && !inputStreet.getText().isEmpty()) {
                 // house number already present but not linked to a street
                 Collection<Command> cmds = new LinkedList<>();
@@ -199 +195 @@
                 inputNumber.setText("");
                 setNewSelection(mouseOnExistingWays.get(0));
-            } else if (mouseOnExistingWays.size() == 0) {
+            } else if (mouseOnExistingWays.isEmpty()) {
                 // clicked a non highway and not a node => add the new address
-                if (inputStreet.getText().equals("") || inputNumber.getText().equals("")) {
+                if (inputStreet.getText().isEmpty() || inputNumber.getText().isEmpty()) {
                     Toolkit.getDefaultToolkit().beep();
                 } else {
@@ -217 +213 @@
             }
         }
-
     }
 
@@ -297 +292 @@
     }
 
-    private Node createNewNode(MouseEvent e, Collection<Command> cmds) {
+    private static Node createNewNode(MouseEvent e, Collection<Command> cmds) {
         // DrawAction.mouseReleased() but without key modifiers
         Node n = new Node(Main.map.mapView.getLatLon(e.getX(), e.getY()));
@@ -398 +393 @@
 
     private static void pruneSuccsAndReverse(List<Integer> is) {
-        //if (is.size() < 2) return;
-
         HashSet<Integer> is2 = new HashSet<>();
         for (int i : is) {
@@ -415 +408 @@
         try {
             return ImageProvider.getCursor("crosshair", null);
-        } catch (Exception e) {
+        } catch (RuntimeException e) {
+            Main.warn(e);
         }
         return Cursor.getPredefinedCursor(Cursor.CROSSHAIR_CURSOR);
@@ -422 +416 @@
     private void applyInputNumberChange() {
         Integer num = Integer.parseInt(inputNumber.getText());
-        if (plus_one.isSelected())
+        if (plusOne.isSelected())
             num = num + 1;
-        if (plus_two.isSelected())
+        if (plusTwo.isSelected())
             num = num + 2;
-        if (minus_one.isSelected() && num > 1)
+        if (minusOne.isSelected() && num > 1)
             num = num - 1;
-        if (minus_two.isSelected() && num > 2)
+        if (minusTwo.isSelected() && num > 2)
             num = num - 2;
         inputNumber.setText(num.toString());
@@ -435 +429 @@
     private void revertInputNumberChange() {
         Integer num = Integer.parseInt(inputNumber.getText());
-        if (plus_one.isSelected())
+        if (plusOne.isSelected())
             num = num - 1;
-        if (plus_two.isSelected())
+        if (plusTwo.isSelected())
             num = num - 2;
-        if (minus_one.isSelected() && num > 1)
+        if (minusOne.isSelected() && num > 1)
             num = num + 1;
-        if (minus_two.isSelected() && num > 2)
+        if (minusTwo.isSelected() && num > 2)
             num = num + 2;
         inputNumber.setText(num.toString());
@@ -471 +465 @@
         });
         ButtonGroup bgIncremental = new ButtonGroup();
-        bgIncremental.add(plus_one);
-        bgIncremental.add(plus_two);
-        bgIncremental.add(minus_one);
-        bgIncremental.add(minus_two);
-        p.add(minus_one, GBC.std().insets(10, 0, 10, 0));
-//        p.add(plus_one, GBC.eol().fill(GBC.HORIZONTAL).insets(10, 0, 0, 0));
-        p.add(plus_one, GBC.std().insets(0, 0, 10, 0));
+        bgIncremental.add(plusOne);
+        bgIncremental.add(plusTwo);
+        bgIncremental.add(minusOne);
+        bgIncremental.add(minusTwo);
+        p.add(minusOne, GBC.std().insets(10, 0, 10, 0));
+        p.add(plusOne, GBC.std().insets(0, 0, 10, 0));
         tagPolygon.setSelected(Main.pref.getBoolean("cadastrewms.addr.onBuilding", false));
         tagPolygon.addChangeListener(new ChangeListener() {
@@ -486 +479 @@
         });
         p.add(tagPolygon, GBC.eol().fill(GBC.HORIZONTAL).insets(0, 0, 0, 0));
-        p.add(minus_two, GBC.std().insets(10, 0, 10, 0));
-        p.add(plus_two, GBC.std().insets(0, 0, 10, 0));
+        p.add(minusTwo, GBC.std().insets(10, 0, 10, 0));
+        p.add(plusTwo, GBC.std().insets(0, 0, 10, 0));
         p.add(clearButton, GBC.eol().fill(GBC.HORIZONTAL).insets(0, 0, 0, 0));
 
@@ -508 +501 @@
             }
         });
-        dialog.addWindowListener(new WindowListener() {
+        dialog.addWindowListener(new WindowAdapter() {
             @Override
-            public void windowClosing(WindowEvent arg0) {
+            public void windowClosing(WindowEvent arg) {
                 exitMode();
                 Main.map.selectMapMode((MapMode)Main.map.getDefaultButtonAction());
             }
-            @Override
-            public void windowClosed(WindowEvent e) {}
-            @Override
-            public void windowActivated(WindowEvent arg0) {}
-            @Override
-            public void windowDeactivated(WindowEvent arg0) {}
-            @Override
-            public void windowDeiconified(WindowEvent arg0) {}
-            @Override
-            public void windowIconified(WindowEvent arg0) {}
-            @Override
-            public void windowOpened(WindowEvent arg0) {}
         });
         String bounds = Main.pref.get("cadastrewms.addr.bounds",null);
@@ -544 +525 @@
     }
 
-    private void setNewSelection(OsmPrimitive osm) {
+    private static void setNewSelection(OsmPrimitive osm) {
         Collection<OsmPrimitive> newSelection = new LinkedList<>(Main.main.getCurrentDataSet().getSelected());
         newSelection.clear();

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/CacheControl.java

@@ -13 +13 @@
 import java.io.OutputStream;
 import java.util.ArrayList;
+import java.util.concurrent.Callable;
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
@@ -33 +34 @@
 public class CacheControl implements Runnable {
 
-    public static final String cLambertCC9Z = "CC";
-
-    public static final String cUTM20N = "UTM";
-
-    public class ObjectOutputStreamAppend extends ObjectOutputStream {
+    public static final String C_LAMBERT_CC_9Z = "CC";
+
+    public static final String C_UTM20N = "UTM";
+
+    public static class ObjectOutputStreamAppend extends ObjectOutputStream {
         public ObjectOutputStreamAppend(OutputStream out) throws IOException {
             super(out);
@@ -51 +52 @@
     public static int cacheSize = 500;
 
-    public WMSLayer wmsLayer = null;
+    public WMSLayer wmsLayer;
 
     private ArrayList<GeorefImage> imagesToSave = new ArrayList<>();
@@ -79 +80 @@
     }
 
-    private void checkDirSize(File path) {
+    private static void checkDirSize(File path) {
         if (cacheSize != 0) {
             long size = 0;
@@ -105 +106 @@
             CadastrePlugin.askToChangeProjection();
         }
-        try {
-            File file = new File(CadastrePlugin.cacheDir + wmsLayer.getName() + "." + WMSFileExtension());
-            if (file.exists()) {
-                JOptionPane pane = new JOptionPane(
-                        tr("Location \"{0}\" found in cache.\n"+
-                        "Load cache first ?\n"+
-                        "(No = new cache)", wmsLayer.getName()),
-                        JOptionPane.QUESTION_MESSAGE, JOptionPane.YES_NO_OPTION, null);
-                // this below is a temporary workaround to fix the "always on top" issue
-                JDialog dialog = pane.createDialog(Main.parent, tr("Select Feuille"));
-                CadastrePlugin.prepareDialog(dialog);
-                dialog.setVisible(true);
-                int reply = (Integer)pane.getValue();
-                // till here
-
-                if (reply == JOptionPane.OK_OPTION && loadCache(file, wmsLayer.getLambertZone())) {
-                    return true;
-                } else {
-                    delete(file);
-                }
-            }
-        } catch (Exception e) {
-            Main.error(e);
+        File file = new File(CadastrePlugin.cacheDir + wmsLayer.getName() + "." + WMSFileExtension());
+        if (file.exists()) {
+            int reply = GuiHelper.runInEDTAndWaitAndReturn(new Callable<Integer>() {
+                @Override
+                public Integer call() throws Exception {
+                    JOptionPane pane = new JOptionPane(
+                            tr("Location \"{0}\" found in cache.\n"+
+                            "Load cache first ?\n"+
+                            "(No = new cache)", wmsLayer.getName()),
+                            JOptionPane.QUESTION_MESSAGE, JOptionPane.YES_NO_OPTION, null);
+                    // this below is a temporary workaround to fix the "always on top" issue
+                    JDialog dialog = pane.createDialog(Main.parent, tr("Select Feuille"));
+                    CadastrePlugin.prepareDialog(dialog);
+                    dialog.setVisible(true);
+                    return (Integer)pane.getValue();
+                    // till here
+                }
+            });
+
+            if (reply == JOptionPane.OK_OPTION && loadCache(file, wmsLayer.getLambertZone())) {
+                return true;
+            } else {
+                delete(file);
+            }
         }
         return false;
@@ -133 +135 @@
 
     public void deleteCacheFile() {
-        try {
-            delete(new File(CadastrePlugin.cacheDir + wmsLayer.getName() + "." + WMSFileExtension()));
-        } catch (Exception e) {
-            Main.error(e);
-        }
-    }
-
-    private void delete(File file) {
+        delete(new File(CadastrePlugin.cacheDir + wmsLayer.getName() + "." + WMSFileExtension()));
+    }
+
+    private static void delete(File file) {
         Main.info("Delete file "+file);
         if (file.exists())
@@ -155 +153 @@
         ) {
             successfulRead = wmsLayer.read(file, ois, currentLambertZone);
-        } catch (Exception ex) {
+        } catch (IOException | ClassNotFoundException ex) {
             Main.error(ex);
             GuiHelper.runInEDTAndWait(new Runnable() {
@@ -176 +174 @@
         imagesLock.lock();
         this.imagesToSave.add(image);
-        this.notify();
+        this.notifyAll();
         imagesLock.unlock();
     }
@@ -224 +222 @@
 
     private String WMSFileExtension() {
-        String ext = String.valueOf((wmsLayer.getLambertZone() + 1));
+        String ext = String.valueOf(wmsLayer.getLambertZone() + 1);
         if (CadastrePlugin.isLambert_cc9())
-            ext = cLambertCC9Z + ext;
+            ext = C_LAMBERT_CC_9Z + ext;
         else if (CadastrePlugin.isUtm_france_dom())
-            ext = cUTM20N + ext;
+            ext = C_UTM20N + ext;
         return ext;
     }

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/CacheFileLambert4ZoneFilter.java

@@ -3 +3 @@
 
 import static org.openstreetmap.josm.tools.I18n.tr;
+
 import java.io.File;
+import java.util.Locale;
+
 import javax.swing.filechooser.FileFilter;
 
-public class CacheFileLambert4ZoneFilter extends FileFilter {
+public final class CacheFileLambert4ZoneFilter extends FileFilter {
 
     /**
@@ -14 +17 @@
     private final String description;
 
-    public static CacheFileLambert4ZoneFilter[] filters = {
+    static final CacheFileLambert4ZoneFilter[] filters = {
         new CacheFileLambert4ZoneFilter("1", tr("Lambert Zone {0} cache file (.{0})", 1)),
         new CacheFileLambert4ZoneFilter("2", tr("Lambert Zone {0} cache file (.{0})", 2)),
@@ -31 +34 @@
 
     public boolean acceptName(String filename) {
-        String name = filename.toLowerCase();
+        String name = filename.toLowerCase(Locale.FRANCE);
         for (String ext : extension.split(","))
             if (name.endsWith("." + ext))
@@ -49 +52 @@
         return description;
     }
-
 }

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/CadastreGrabber.java

@@ -43 +43 @@
     }
 
-    private URL getURLRaster(WMSLayer wmsLayer, EastNorth lambertMin, EastNorth lambertMax) throws MalformedURLException {
+    private static URL getURLRaster(WMSLayer wmsLayer, EastNorth lambertMin, EastNorth lambertMax) throws MalformedURLException {
         // GET /scpc/wms?version=1.1&request=GetMap&layers=CDIF:PMC@QH4480001701&format=image/png&bbox=-1186,0,13555,8830&width=576&height=345&exception=application/vnd.ogc.se_inimage&styles= HTTP/1.1
         final int cRasterX = CadastrePlugin.imageWidth; // keep width constant and adjust width to original image proportions
-        String str = new String(wmsInterface.baseURL+"/scpc/wms?version=1.1&request=GetMap");
+        String str = CadastreInterface.BASE_URL+"/scpc/wms?version=1.1&request=GetMap";
         str += "&layers=CDIF:PMC@";
         str += wmsLayer.getCodeCommune();
@@ -60 +60 @@
     }
 
-    private URL buildURLVector(String layers, String styles,
+    private static URL buildURLVector(String layers, String styles,
             int width, int height,
             EastNorth lambertMin, EastNorth lambertMax) throws MalformedURLException {
-        String str = new String(wmsInterface.baseURL+"/scpc/wms?version=1.1&request=GetMap");
+        String str = CadastreInterface.BASE_URL+"/scpc/wms?version=1.1&request=GetMap";
         str += "&layers="+ layers;
         str += "&format=image/png";
-        //str += "&format=image/jpeg";
         str += "&bbox="+lambertMin.east()+",";
         str += lambertMin.north() + ",";
@@ -78 +77 @@
     }
 
-    private URL getURLVector(EastNorth lambertMin, EastNorth lambertMax) throws MalformedURLException {
+    private static URL getURLVector(EastNorth lambertMin, EastNorth lambertMax) throws MalformedURLException {
         return buildURLVector(CadastrePlugin.grabLayers, CadastrePlugin.grabStyles,
                 CadastrePlugin.imageWidth, CadastrePlugin.imageHeight,

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/CadastreInterface.java

@@ -12 +12 @@
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
+import java.util.ArrayList;
 import java.util.Date;
-import java.util.Vector;
+import java.util.List;
 
 import javax.swing.JComboBox;
@@ -26 +28 @@
 
 public class CadastreInterface {
-    public boolean downloadCanceled = false;
-    public HttpURLConnection urlConn = null;
+    public boolean downloadCanceled;
+    public HttpURLConnection urlConn;
 
     private String cookie;
-    private String interfaceRef = null;
-    private String lastWMSLayerName = null;
+    private String interfaceRef;
+    private String lastWMSLayerName;
     private URL searchFormURL;
-    private Vector<String> listOfCommunes = new Vector<>();
-    private Vector<String> listOfTA = new Vector<>();
-    class PlanImage {
+    private List<String> listOfCommunes = new ArrayList<>();
+    private List<String> listOfTA = new ArrayList<>();
+    static class PlanImage {
         String name;
         String ref;
@@ -43 +45 @@
         }
     }
-    private Vector<PlanImage> listOfFeuilles = new Vector<>();
+    private List<PlanImage> listOfFeuilles = new ArrayList<>();
     private long cookieTimestamp;
 
-    final String baseURL = "http://www.cadastre.gouv.fr";
-    final String cImageFormat = "Cette commune est au format ";
-    final String cCommuneListStart = "<select name=\"codeCommune\"";
-    final String cCommuneListEnd = "</select>";
-    final String c0ptionListStart = "<option value=\"";
-    final String cOptionListEnd = "</option>";
-    final String cBBoxCommunStart = "new GeoBox(";
-    final String cBBoxCommunEnd = ")";
-
-    final String cInterfaceVector = "afficherCarteCommune.do";
-    final String cInterfaceRasterTA = "afficherCarteTa.do";
-    final String cInterfaceRasterFeuille = "afficherCarteFeuille.do";
-    final String cImageLinkStart = "<a href=\"#\" class=\"raster\" onClick=\"popup('afficherCarteFeuille.do?f=";
-    final String cTAImageLinkStart = "<a href=\"#\" class=\"raster\" onClick=\"popup('afficherCarteTa.do?f=";
-    final String cImageNameStart = ">Feuille ";
-    final String cTAImageNameStart = "Tableau d'assemblage <strong>";
-
-    final static long cCookieExpiration = 30 * 60 * 1000; // 30 minutes expressed in milliseconds
-
-    final  int cRetriesGetCookie = 10; // 10 times every 3 seconds means 30 seconds trying to get a cookie
+    static final String BASE_URL = "http://www.cadastre.gouv.fr";
+    static final String C_IMAGE_FORMAT = "Cette commune est au format ";
+    static final String C_COMMUNE_LIST_START = "<select name=\"codeCommune\"";
+    static final String C_COMMUNE_LIST_END = "</select>";
+    static final String C_OPTION_LIST_START = "<option value=\"";
+    static final String C_OPTION_LIST_END = "</option>";
+    static final String C_BBOX_COMMUN_START = "new GeoBox(";
+    static final String C_BBOX_COMMUN_END = ")";
+
+    static final String C_INTERFACE_VECTOR = "afficherCarteCommune.do";
+    static final String C_INTERFACE_RASTER_TA = "afficherCarteTa.do";
+    static final String C_INTERFACE_RASTER_FEUILLE = "afficherCarteFeuille.do";
+    static final String C_IMAGE_LINK_START = "<a href=\"#\" class=\"raster\" onClick=\"popup('afficherCarteFeuille.do?f=";
+    static final String C_TA_IMAGE_LINK_START = "<a href=\"#\" class=\"raster\" onClick=\"popup('afficherCarteTa.do?f=";
+    static final String C_IMAGE_NAME_START = ">Feuille ";
+    static final String C_TA_IMAGE_NAME_START = "Tableau d'assemblage <strong>";
+
+    static final long COOKIE_EXPIRATION = 30 * 60 * 1000L; // 30 minutes expressed in milliseconds
+
+    static final int RETRIES_GET_COOKIE = 10; // 10 times every 3 seconds means 30 seconds trying to get a cookie
 
     public boolean retrieveInterface(WMSLayer wmsLayer) throws DuplicateLayerException, WMSException {
-        if (wmsLayer.getName().equals(""))
+        if (wmsLayer.getName().isEmpty())
             return false;
         boolean isCookieExpired = isCookieExpired();
@@ -90 +92 @@
             openInterface();
         } catch (IOException e) {
+            Main.error(e);
             JOptionPane.showMessageDialog(Main.parent,
                     tr("Town/city {0} not found or not available\n" +
@@ -105 +108 @@
      */
     private void getCookie() throws IOException {
-        boolean sucess = false;
-        int retries = cRetriesGetCookie;
+        boolean success = false;
+        int retries = RETRIES_GET_COOKIE;
         try {
-            searchFormURL = new URL(baseURL + "/scpc/accueil.do");
-            while (sucess == false && retries > 0) {
+            searchFormURL = new URL(BASE_URL + "/scpc/accueil.do");
+            while (!success && retries > 0) {
                 urlConn = (HttpURLConnection)searchFormURL.openConnection();
                 urlConn.setRequestProperty("Connection", "close");
@@ -116 +119 @@
                 if (urlConn.getResponseCode() == HttpURLConnection.HTTP_OK) {
                     Main.info("GET "+searchFormURL);
-                    BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream()));
-                    while(in.readLine() != null) {}  // read the buffer otherwise we sent POST too early
-                    sucess = true;
+                    BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream(), StandardCharsets.UTF_8));
+                    while(in.readLine() != null) {
+                        // read the buffer otherwise we sent POST too early
+                    }
+                    success = true;
                     String headerName;
                     for (int i=1; (headerName = urlConn.getHeaderFieldKey(i))!=null; i++) {
@@ -155 +160 @@
     public boolean isCookieExpired() {
         long now = new Date().getTime();
-        if ((now - cookieTimestamp) > cCookieExpiration) {
+        if ((now - cookieTimestamp) > COOKIE_EXPIRATION) {
             Main.info("cookie received at "+new Date(cookieTimestamp)+" expired (now is "+new Date(now)+")");
             return true;
@@ -182 +187 @@
         // second attempt either from known codeCommune (e.g. from cache) or from ComboBox
         if (interfaceRef == null) {
-            if (!wmsLayer.getCodeCommune().equals("")) {
+            if (!wmsLayer.getCodeCommune().isEmpty()) {
                 // codeCommune is already known (from previous request or from cache on disk)
                 interfaceRef = postForm(wmsLayer, wmsLayer.getCodeCommune());
             } else {
                 if (listOfCommunes.size() > 1) {
-                    // commune unknown, prompt the list of communes from
-                    // server and try with codeCommune
-                    String selected = selectMunicipalityDialog(wmsLayer);
+                    // commune unknown, prompt the list of communes from server and try with codeCommune
+                    String selected = selectMunicipalityDialog();
                     if (selected != null) {
-                        String newCodeCommune = selected.substring(1, selected.indexOf(">")-2);
-                        String newLocation = selected.substring(selected.indexOf(">")+1, selected.lastIndexOf(" - "));
+                        String newCodeCommune = selected.substring(1, selected.indexOf('>') - 2);
+                        String newLocation = selected.substring(selected.indexOf('>') + 1, selected.lastIndexOf(" - "));
                         wmsLayer.setCodeCommune(newCodeCommune);
                         wmsLayer.setLocation(newLocation);
@@ -205 +209 @@
                     int res = selectFeuilleDialog();
                     if (res != -1) {
-                        wmsLayer.setCodeCommune(listOfFeuilles.elementAt(res).name);
+                        wmsLayer.setCodeCommune(listOfFeuilles.get(res).name);
                         checkLayerDuplicates(wmsLayer);
                         interfaceRef = buildRasterFeuilleInterfaceRef(wmsLayer.getCodeCommune());
@@ -220 +224 @@
         try {
             // finally, open the interface on server side giving access to the wms server
-            String lines = null;
-            String ln = null;
-            URL interfaceURL = new URL(baseURL + "/scpc/"+interfaceRef);
+            URL interfaceURL = new URL(BASE_URL + "/scpc/"+interfaceRef);
             urlConn = (HttpURLConnection)interfaceURL.openConnection();
             urlConn.setRequestMethod("GET");
@@ -231 +233 @@
             }
             Main.info("GET "+interfaceURL);
-            BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream()));
+            BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream(), StandardCharsets.UTF_8));
             // read the buffer otherwise we sent POST too early
+            StringBuilder lines = new StringBuilder();
+            String ln;
             while ((ln = in.readLine()) != null) {
-                lines += ln;
+                if (Main.isDebugEnabled()) {
+                    lines.append(ln);
+                }
             }
             if (Main.isDebugEnabled()) {
-                Main.debug(lines);
+                Main.debug(lines.toString());
             }
         } catch (MalformedURLException e) {
@@ -267 +273 @@
     private String postForm(WMSLayer wmsLayer, String codeCommune) throws IOException {
         try {
-            String ln = null;
-            String lines = null;
             listOfCommunes.clear();
             listOfTA.clear();
@@ -276 +280 @@
             content += "&nomvoie=";
             content += "&lieuDit=";
-            if (codeCommune == "") {
-                content += "&ville=" + new String(java.net.URLEncoder.encode(wmsLayer.getLocation(), "UTF-8"));
+            if (codeCommune.isEmpty()) {
+                content += "&ville=" + java.net.URLEncoder.encode(wmsLayer.getLocation(), "UTF-8");
                 content += "&codePostal=";
             } else {
@@ -286 +290 @@
             content += "&nbResultatParPage=10";
             content += "&x=0&y=0";
-            searchFormURL = new URL(baseURL + "/scpc/rechercherPlan.do");
+            searchFormURL = new URL(BASE_URL + "/scpc/rechercherPlan.do");
             urlConn = (HttpURLConnection)searchFormURL.openConnection();
             urlConn.setRequestMethod("POST");
@@ -293 +297 @@
             setCookie();
             try (OutputStream wr = urlConn.getOutputStream()) {
-                wr.write(content.getBytes());
+                wr.write(content.getBytes(StandardCharsets.UTF_8));
                 Main.info("POST "+content);
                 wr.flush();
             }
-            try (BufferedReader rd = new BufferedReader(new InputStreamReader(urlConn.getInputStream()))) {
+            String ln;
+            StringBuilder sb = new StringBuilder();
+            try (BufferedReader rd = new BufferedReader(new InputStreamReader(urlConn.getInputStream(), StandardCharsets.UTF_8))) {
                 while ((ln = rd.readLine()) != null) {
-                    lines += ln;
-                }
-            }
+                    sb.append(ln);
+                }
+            }
+            String lines = sb.toString();
             urlConn.disconnect();
             if (lines != null) {
-                if (lines.indexOf(cImageFormat) != -1) {
-                    int i = lines.indexOf(cImageFormat);
-                    int j = lines.indexOf(".", i);
-                    wmsLayer.setRaster(lines.substring(i+cImageFormat.length(), j).equals("image"));
-                }
-                if (!wmsLayer.isRaster() && lines.indexOf(cInterfaceVector) != -1) {  // "afficherCarteCommune.do"
+                if (lines.indexOf(C_IMAGE_FORMAT) != -1) {
+                    int i = lines.indexOf(C_IMAGE_FORMAT);
+                    int j = lines.indexOf('.', i);
+                    wmsLayer.setRaster("image".equals(lines.substring(i+C_IMAGE_FORMAT.length(), j)));
+                }
+                if (!wmsLayer.isRaster() && lines.indexOf(C_INTERFACE_VECTOR) != -1) {  // "afficherCarteCommune.do"
                     // shall be something like: interfaceRef = "afficherCarteCommune.do?c=X2269";
-                    lines = lines.substring(lines.indexOf(cInterfaceVector),lines.length());
-                    lines = lines.substring(0, lines.indexOf("'"));
+                    lines = lines.substring(lines.indexOf(C_INTERFACE_VECTOR),lines.length());
+                    lines = lines.substring(0, lines.indexOf('\''));
                     Main.info("interface ref.:"+lines);
                     return lines;
-                } else if (wmsLayer.isRaster() && lines.indexOf(cInterfaceRasterTA) != -1) { // "afficherCarteTa.do"
+                } else if (wmsLayer.isRaster() && lines.indexOf(C_INTERFACE_RASTER_TA) != -1) { // "afficherCarteTa.do"
                     // list of values parsed in listOfFeuilles (list all non-georeferenced images)
                     lines = getFeuillesList();
                     if (!downloadCanceled) {
                         parseFeuillesList(lines);
-                        if (listOfFeuilles.size() > 0) {
+                        if (!listOfFeuilles.isEmpty()) {
                             int res = selectFeuilleDialog();
                             if (res != -1) {
-                                wmsLayer.setCodeCommune(listOfFeuilles.elementAt(res).name);
+                                wmsLayer.setCodeCommune(listOfFeuilles.get(res).name);
                                 checkLayerDuplicates(wmsLayer);
                                 interfaceRef = buildRasterFeuilleInterfaceRef(wmsLayer.getCodeCommune());
-                                wmsLayer.setCodeCommune(listOfFeuilles.elementAt(res).ref);
-                                lines = buildRasterFeuilleInterfaceRef(listOfFeuilles.elementAt(res).ref);
+                                wmsLayer.setCodeCommune(listOfFeuilles.get(res).ref);
+                                lines = buildRasterFeuilleInterfaceRef(listOfFeuilles.get(res).ref);
                                 Main.info("interface ref.:"+lines);
                                 return lines;
@@ -334 +341 @@
                     }
                     return null;
-                } else if (lines.indexOf(cCommuneListStart) != -1 && lines.indexOf(cCommuneListEnd) != -1) {
+                } else if (lines.indexOf(C_COMMUNE_LIST_START) != -1 && lines.indexOf(C_COMMUNE_LIST_END) != -1) {
                     // list of values parsed in listOfCommunes
-                    int i = lines.indexOf(cCommuneListStart);
-                    int j = lines.indexOf(cCommuneListEnd, i);
+                    int i = lines.indexOf(C_COMMUNE_LIST_START);
+                    int j = lines.indexOf(C_COMMUNE_LIST_END, i);
                     parseCommuneList(lines.substring(i, j));
                 }
             }
         } catch (MalformedURLException e) {
-            throw (IOException) new IOException(
-                "Illegal url.").initCause(e);
-        } catch (Exception e){
-            e.printStackTrace();
+            throw (IOException) new IOException("Illegal url.").initCause(e);
+        } catch (DuplicateLayerException e){
+            Main.error(e);
         }
         return null;
@@ -351 +357 @@
 
     private void parseCommuneList(String input) {
-        if (input.indexOf(c0ptionListStart) != -1) {
+        if (input.indexOf(C_OPTION_LIST_START) != -1) {
             while (input.indexOf("<option value=\"") != -1) {
-                int i = input.indexOf(c0ptionListStart);
-                int j = input.indexOf(cOptionListEnd, i+c0ptionListStart.length());
-                int k = input.indexOf("\"", i+c0ptionListStart.length());
-                if (j != -1 && k > (i + c0ptionListStart.length())) {
-                    String lov = new String(input.substring(i+c0ptionListStart.length()-1, j));
-                    if (lov.indexOf(">") != -1) {
+                int i = input.indexOf(C_OPTION_LIST_START);
+                int j = input.indexOf(C_OPTION_LIST_END, i+C_OPTION_LIST_START.length());
+                int k = input.indexOf('"', i+C_OPTION_LIST_START.length());
+                if (j != -1 && k > (i + C_OPTION_LIST_START.length())) {
+                    String lov = input.substring(i+C_OPTION_LIST_START.length()-1, j);
+                    if (lov.indexOf('>') != -1) {
                         Main.info("parse "+lov);
                         listOfCommunes.add(lov);
@@ -364 +370 @@
                         Main.error("unable to parse commune string:"+lov);
                 }
-                input = input.substring(j+cOptionListEnd.length());
+                input = input.substring(j+C_OPTION_LIST_END.length());
             }
         }
@@ -372 +378 @@
         // get all images in one html page
         String ln = null;
-        String lines = null;
+        StringBuilder lines = new StringBuilder();
         HttpURLConnection urlConn2 = null;
         try {
-            URL getAllImagesURL = new URL(baseURL + "/scpc/listerFeuillesParcommune.do?keepVolatileSession=&offset=2000");
+            URL getAllImagesURL = new URL(BASE_URL + "/scpc/listerFeuillesParcommune.do?keepVolatileSession=&offset=2000");
             urlConn2 = (HttpURLConnection)getAllImagesURL.openConnection();
             setCookie(urlConn2);
             urlConn2.connect();
             Main.info("GET "+getAllImagesURL);
-            try (BufferedReader rd = new BufferedReader(new InputStreamReader(urlConn2.getInputStream()))) {
+            try (BufferedReader rd = new BufferedReader(new InputStreamReader(urlConn2.getInputStream(), StandardCharsets.UTF_8))) {
                 while ((ln = rd.readLine()) != null) {
-                    lines += ln;
+                    lines.append(ln);
                 }
             }
@@ -390 +396 @@
             Main.error(e);
         }
-        return lines;
+        return lines.toString();
     }
 
@@ -398 +404 @@
         String inputTA = input;
         if (Main.pref.getBoolean("cadastrewms.useTA", false)) {
-            while (inputTA.indexOf(cTAImageLinkStart) != -1) {
-                inputTA = inputTA.substring(inputTA.indexOf(cTAImageLinkStart) + cTAImageLinkStart.length());
-                String refTA = inputTA.substring(0, inputTA.indexOf("'"));
-                String nameTA = inputTA.substring(inputTA.indexOf(cTAImageNameStart) + cTAImageNameStart.length());
-                nameTA = nameTA.substring(0, nameTA.indexOf("<"));
+            while (inputTA.indexOf(C_TA_IMAGE_LINK_START) != -1) {
+                inputTA = inputTA.substring(inputTA.indexOf(C_TA_IMAGE_LINK_START) + C_TA_IMAGE_LINK_START.length());
+                String refTA = inputTA.substring(0, inputTA.indexOf('\''));
+                String nameTA = inputTA.substring(inputTA.indexOf(C_TA_IMAGE_NAME_START) + C_TA_IMAGE_NAME_START.length());
+                nameTA = nameTA.substring(0, nameTA.indexOf('<'));
                 listOfFeuilles.add(new PlanImage(nameTA, refTA));
             }
         }
         // get "Feuilles"
-        while (input.indexOf(cImageLinkStart) != -1) {
-            input = input.substring(input.indexOf(cImageLinkStart)+cImageLinkStart.length());
-            String refFeuille = input.substring(0, input.indexOf("'"));
+        while (input.indexOf(C_IMAGE_LINK_START) != -1) {
+            input = input.substring(input.indexOf(C_IMAGE_LINK_START)+C_IMAGE_LINK_START.length());
+            String refFeuille = input.substring(0, input.indexOf('\''));
             String nameFeuille = input.substring(
-                    input.indexOf(cImageNameStart)+cImageNameStart.length(),
+                    input.indexOf(C_IMAGE_NAME_START)+C_IMAGE_NAME_START.length(),
                     input.indexOf(" -"));
             listOfFeuilles.add(new PlanImage(nameFeuille, refFeuille));
@@ -417 +423 @@
     }
 
-    private String selectMunicipalityDialog(WMSLayer wmsLayer) {
+    private String selectMunicipalityDialog() {
         JPanel p = new JPanel(new GridBagLayout());
         String[] communeList = new String[listOfCommunes.size() + 1];
         communeList[0] = tr("Choose from...");
         for (int i = 0; i < listOfCommunes.size(); i++) {
-            communeList[i + 1] = listOfCommunes.elementAt(i).substring(listOfCommunes.elementAt(i).indexOf(">")+1);
+            communeList[i + 1] = listOfCommunes.get(i).substring(listOfCommunes.get(i).indexOf('>')+1);
         }
         JComboBox<String> inputCommuneList = new JComboBox<>(communeList);
         p.add(inputCommuneList, GBC.eol().fill(GBC.HORIZONTAL).insets(10, 0, 0, 0));
         JOptionPane pane = new JOptionPane(p, JOptionPane.INFORMATION_MESSAGE, JOptionPane.OK_CANCEL_OPTION, null);
-        //pane.createDialog(Main.parent, tr("Select commune")).setVisible(true);
         // this below is a temporary workaround to fix the "always on top" issue
         JDialog dialog = pane.createDialog(Main.parent, tr("Select commune"));
@@ -435 +440 @@
         if (!Integer.valueOf(JOptionPane.OK_OPTION).equals(pane.getValue()))
             return null;
-        return listOfCommunes.elementAt(inputCommuneList.getSelectedIndex()-1);
+        return listOfCommunes.get(inputCommuneList.getSelectedIndex()-1);
     }
 
     private int selectFeuilleDialog() {
         JPanel p = new JPanel(new GridBagLayout());
-        Vector<String> imageNames = new Vector<>();
+        List<String> imageNames = new ArrayList<>();
         for (PlanImage src : listOfFeuilles) {
             imageNames.add(src.name);
         }
-        JComboBox<String> inputFeuilleList = new JComboBox<>(imageNames);
+        JComboBox<String> inputFeuilleList = new JComboBox<>(imageNames.toArray(new String[]{}));
         p.add(inputFeuilleList, GBC.eol().fill(GBC.HORIZONTAL).insets(10, 0, 0, 0));
         JOptionPane pane = new JOptionPane(p, JOptionPane.INFORMATION_MESSAGE, JOptionPane.OK_CANCEL_OPTION, null);
-        //pane.createDialog(Main.parent, tr("Select Feuille")).setVisible(true);
         // this below is a temporary workaround to fix the "always on top" issue
         JDialog dialog = pane.createDialog(Main.parent, tr("Select Feuille"));
@@ -455 +459 @@
         if (!Integer.valueOf(JOptionPane.OK_OPTION).equals(pane.getValue()))
             return -1;
-        int result = inputFeuilleList.getSelectedIndex();
-        return result;
-    }
-
-    private String buildRasterFeuilleInterfaceRef(String codeCommune) {
-        return cInterfaceRasterFeuille + "?f=" + codeCommune;
+        return inputFeuilleList.getSelectedIndex();
+    }
+
+    private static String buildRasterFeuilleInterfaceRef(String codeCommune) {
+        return C_INTERFACE_RASTER_FEUILLE + "?f=" + codeCommune;
     }
 
@@ -474 +477 @@
         if (interfaceRef == null)
             return;
-        String ln = null;
-        String line = null;
         // send GET opening normally the small window with the commune overview
-        String content = baseURL + "/scpc/" + interfaceRef;
+        String content = BASE_URL + "/scpc/" + interfaceRef;
         content += "&dontSaveLastForward&keepVolatileSession=";
         searchFormURL = new URL(content);
@@ -488 +489 @@
         }
         Main.info("GET "+searchFormURL);
-        try (BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream()))) {
+        String ln;
+        StringBuilder sb = new StringBuilder();
+        try (BufferedReader in = new BufferedReader(new InputStreamReader(urlConn.getInputStream(), StandardCharsets.UTF_8))) {
             while ((ln = in.readLine()) != null) {
-                line += ln;
+                sb.append(ln);
             }
         }
         urlConn.disconnect();
+        String line = sb.toString();
         parseBBoxCommune(wmsLayer, line);
         if (wmsLayer.isRaster() && !wmsLayer.isAlreadyGeoreferenced()) {
@@ -500 +504 @@
     }
 
-    private void parseBBoxCommune(WMSLayer wmsLayer, String input) {
-        if (input.indexOf(cBBoxCommunStart) != -1) {
-            input = input.substring(input.indexOf(cBBoxCommunStart));
-            int i = input.indexOf(",");
-            double minx = Double.parseDouble(input.substring(cBBoxCommunStart.length(), i));
-            int j = input.indexOf(",", i+1);
+    private static void parseBBoxCommune(WMSLayer wmsLayer, String input) {
+        if (input.indexOf(C_BBOX_COMMUN_START) != -1) {
+            input = input.substring(input.indexOf(C_BBOX_COMMUN_START));
+            int i = input.indexOf(',');
+            double minx = Double.parseDouble(input.substring(C_BBOX_COMMUN_START.length(), i));
+            int j = input.indexOf(',', i+1);
             double miny = Double.parseDouble(input.substring(i+1, j));
-            int k = input.indexOf(",", j+1);
+            int k = input.indexOf(',', j+1);
             double maxx = Double.parseDouble(input.substring(j+1, k));
-            int l = input.indexOf(cBBoxCommunEnd, k+1);
+            int l = input.indexOf(C_BBOX_COMMUN_END, k+1);
             double maxy = Double.parseDouble(input.substring(k+1, l));
             wmsLayer.setCommuneBBox( new EastNorthBound(new EastNorth(minx,miny), new EastNorth(maxx,maxy)));
@@ -515 +519 @@
     }
 
-    private void parseGeoreferences(WMSLayer wmsLayer, String input) {
+    private static void parseGeoreferences(WMSLayer wmsLayer, String input) {
         /* commented since cadastre WMS changes mid july 2013
          * until new GeoBox coordinates parsing is solved */
@@ -547 +551 @@
 //                wmsLayer.Y0 = Y0;
 //            }
-//            Main.info("parse georef:"+unknown_yet+","+angle+","+scale_origin+","+dpi+","+fX+","+
-//                    fY+","+X0+","+Y0);
+//            Main.info("parse georef:"+unknown_yet+","+angle+","+scale_origin+","+dpi+","+fX+","+fY+","+X0+","+Y0);
 //        }
     }
 
-    private void checkLayerDuplicates(WMSLayer wmsLayer) throws DuplicateLayerException {
+    private static void checkLayerDuplicates(WMSLayer wmsLayer) throws DuplicateLayerException {
         if (Main.map != null) {
             for (Layer l : Main.map.mapView.getAllLayers()) {
-                if (l instanceof WMSLayer && l.getName().equals(wmsLayer.getName()) && (l != wmsLayer)) {
+                if (l instanceof WMSLayer && l.getName().equals(wmsLayer.getName()) && (!l.equals(wmsLayer))) {
                     Main.info("Try to grab into a new layer when "+wmsLayer.getName()+" is already opened.");
                     // remove the duplicated layer
@@ -569 +572 @@
             urlConn.setConnectTimeout(1);
             urlConn.setReadTimeout(1);
-            //urlConn.disconnect();
         }
         downloadCanceled = true;

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/CadastreSessionImporter.java

@@ -41 +41 @@
             fileStr = URLDecoder.decode(fileStr, "UTF-8");
             fileStr = fileStr.substring(fileStr.indexOf(":/")+2);
-            String filename = fileStr.substring(fileStr.lastIndexOf("/")+1,fileStr.length());
-            String ext = (filename.lastIndexOf(".")==-1)?"":filename.substring(filename.lastIndexOf(".")+1,filename.length());
+            String filename = fileStr.substring(fileStr.lastIndexOf('/')+1,fileStr.length());
+            String ext = (filename.lastIndexOf('.')==-1)?"":filename.substring(filename.lastIndexOf('.')+1,filename.length());
             // create layer and load cache
-            if (ext.length() == 3 && ext.substring(0, CacheControl.cLambertCC9Z.length()).equals(CacheControl.cLambertCC9Z))
+            if (ext.length() == 3 && ext.substring(0, CacheControl.C_LAMBERT_CC_9Z.length()).equals(CacheControl.C_LAMBERT_CC_9Z))
                 ext = ext.substring(2);
-            else if (ext.length() == 4 && ext.substring(0, CacheControl.cUTM20N.length()).equals(CacheControl.cUTM20N))
+            else if (ext.length() == 4 && ext.substring(0, CacheControl.C_UTM20N.length()).equals(CacheControl.C_UTM20N))
                 ext = ext.substring(3);
             else if (ext.length() == 2 || ext.length() > 4)

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/DownloadSVGBuilding.java

@@ -14 +14 @@
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -38 +39 @@
     private WMSLayer wmsLayer;
     private CadastreInterface wmsInterface;
-    private String svg = null;
-    private static EastNorthBound currentView = null;
-    private EastNorthBound viewBox = null;
+    private String svg;
+    private static EastNorthBound currentView;
+    private EastNorthBound viewBox;
     private static String errorMessage;
 
@@ -82 +83 @@
     @Override
     protected void finish() {
+        // Do nothing
     }
 
@@ -119 +121 @@
                 // check if new node is not already created by another new path
                 Node nearestNewNode = checkNearestNode(nodeToAdd, svgDataSet.getNodes());
-                if (nearestNewNode == nodeToAdd)
+                if (nodeToAdd.equals(nearestNewNode))
                     svgDataSet.addPrimitive(nearestNewNode);
                 wayToAdd.addNode(nearestNewNode); // either a new node or an existing one
@@ -175 +177 @@
         double dy = Double.parseDouble(coor[2]);
         for (int i=3; i<coor.length; i+=2){
-            if (coor[i].equals("")) {
+            if (coor[i].isEmpty()) {
                 eastNorth.clear(); // some paths are just artifacts
                 return;
@@ -197 +199 @@
      * @return the already existing node (if any), otherwise the new node candidate.
      */
-    private Node checkNearestNode(Node nodeToAdd, Collection<Node> nodes) {
+    private static Node checkNearestNode(Node nodeToAdd, Collection<Node> nodes) {
         double epsilon = 0.05; // smallest distance considering duplicate node
         for (Node n : nodes) {
@@ -220 +222 @@
     }
 
-    private URL getURLsvg(EastNorthBound bbox) throws MalformedURLException {
-        String str = new String(wmsInterface.baseURL+"/scpc/wms?version=1.1&request=GetMap");
+    private static URL getURLsvg(EastNorthBound bbox) throws MalformedURLException {
+        String str = CadastreInterface.BASE_URL+"/scpc/wms?version=1.1&request=GetMap";
         str += "&layers=";
         str += "CDIF:LS2";
@@ -243 +245 @@
         wmsInterface.setCookie();
         File file = new File(CadastrePlugin.cacheDir + "building.svg");
-        String svg = new String();
+        String svg = "";
         try (InputStream is = new ProgressInputStream(wmsInterface.urlConn, NullProgressMonitor.INSTANCE)) {
             if (file.exists())
                 file.delete();
             try (BufferedOutputStream bos = new BufferedOutputStream(new FileOutputStream(file, true));
-                 InputStreamReader isr = new InputStreamReader(is);
+                 InputStreamReader isr = new InputStreamReader(is, StandardCharsets.UTF_8);
                  BufferedReader br = new BufferedReader(isr)) {
-                String line="";
+                String line;
                 while ( null!=(line=br.readLine())){
                     line += "\n";
-                    bos.write(line.getBytes());
+                    bos.write(line.getBytes(StandardCharsets.UTF_8));
                     svg += line;
                 }

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/DownloadSVGTask.java

@@ -14 +14 @@
 import java.net.MalformedURLException;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.util.ArrayList;
 import java.util.Collection;
@@ -43 +44 @@
     private WMSLayer wmsLayer;
     private CadastreInterface wmsInterface;
-    private String svg = null;
-    private EastNorthBound viewBox = null;
+    private String svg;
+    private EastNorthBound viewBox;
     private static String errorMessage;
 
@@ -88 +89 @@
     @Override
     protected void finish() {
+        // Do nothing
     }
 
@@ -168 +170 @@
     private String grabBoundary(EastNorthBound bbox) throws IOException, OsmTransferException {
         try {
-            URL url = null;
-            url = getURLsvg(bbox);
-            return grabSVG(url);
+            return grabSVG(getURLsvg(bbox));
         } catch (MalformedURLException e) {
             throw (IOException) new IOException(tr("CadastreGrabber: Illegal url.")).initCause(e);
@@ -176 +176 @@
     }
 
-    private URL getURLsvg(EastNorthBound bbox) throws MalformedURLException {
-        String str = new String(wmsInterface.baseURL+"/scpc/wms?version=1.1&request=GetMap");
+    private static URL getURLsvg(EastNorthBound bbox) throws MalformedURLException {
+        String str = CadastreInterface.BASE_URL+"/scpc/wms?version=1.1&request=GetMap";
         str += "&layers=";
         str += "CDIF:COMMUNE";
@@ -198 +198 @@
         wmsInterface.setCookie();
         File file = new File(CadastrePlugin.cacheDir + "boundary.svg");
-        String svg = new String();
+        String svg = "";
         try (InputStream is = new ProgressInputStream(wmsInterface.urlConn, NullProgressMonitor.INSTANCE)) {
             if (file.exists())
@@ -205 +205 @@
                  InputStreamReader isr =new InputStreamReader(is);
                  BufferedReader br = new BufferedReader(isr)) {
-                String line="";
+                String line;
                 while ( null!=(line=br.readLine())){
                     line += "\n";
-                    bos.write(line.getBytes());
+                    bos.write(line.getBytes(StandardCharsets.UTF_8));
                     svg += line;
                 }
@@ -219 +219 @@
 
     public static void download(WMSLayer wmsLayer) {
-        if (CadastrePlugin.autoSourcing == false) {
+        if (!CadastrePlugin.autoSourcing) {
             JOptionPane.showMessageDialog(Main.parent,
                     tr("Please, enable auto-sourcing and check cadastre millesime."));
@@ -228 +228 @@
             JOptionPane.showMessageDialog(Main.parent, errorMessage);
     }
-
 }

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/MenuActionLoadFromCache.java

@@ -18 +18 @@
     private static final long serialVersionUID = 1L;
 
-    public static String name = marktr("Load layer from cache");
+    public static final String name = marktr("Load layer from cache");
 
+    /**
+     * Constructs a new {@code MenuActionLoadFromCache}.
+     */
     public MenuActionLoadFromCache() {
         super(tr(name), "cadastre_small", tr("Load location from cache (only if cache is enabled)"), null, false, "cadastrefr/loadfromcache", true);
@@ -36 +39 @@
             if (file.exists()) {
                 String filename = file.getName();
-                String ext = (filename.lastIndexOf(".")==-1)?"":filename.substring(filename.lastIndexOf(".")+1,filename.length());
-                if ((ext.length() == 3 && ext.substring(0, CacheControl.cLambertCC9Z.length()).equals(CacheControl.cLambertCC9Z) &&
+                String ext = (filename.lastIndexOf('.')==-1)?"":filename.substring(filename.lastIndexOf('.')+1,filename.length());
+                if ((ext.length() == 3 && ext.substring(0, CacheControl.C_LAMBERT_CC_9Z.length()).equals(CacheControl.C_LAMBERT_CC_9Z) &&
                     !(CadastrePlugin.isLambert_cc9()))
-                    || (ext.length() == 4 && ext.substring(0, CacheControl.cUTM20N.length()).equals(CacheControl.cUTM20N) &&
+                    || (ext.length() == 4 && ext.substring(0, CacheControl.C_UTM20N.length()).equals(CacheControl.C_UTM20N) &&
                             !(CadastrePlugin.isUtm_france_dom()))
                     || (ext.length() == 1) && !(CadastrePlugin.isLambert())) {
@@ -45 +48 @@
                         continue;
                 } else {
-                    String location = filename.substring(0, filename.lastIndexOf("."));
-                    if (ext.length() == 3 && ext.substring(0, CacheControl.cLambertCC9Z.length()).equals(CacheControl.cLambertCC9Z))
+                    String location = filename.substring(0, filename.lastIndexOf('.'));
+                    if (ext.length() == 3 && ext.substring(0, CacheControl.C_LAMBERT_CC_9Z.length()).equals(CacheControl.C_LAMBERT_CC_9Z))
                         ext = ext.substring(2);
-                    else if (ext.length() == 4 && ext.substring(0, CacheControl.cUTM20N.length()).equals(CacheControl.cUTM20N))
+                    else if (ext.length() == 4 && ext.substring(0, CacheControl.C_UTM20N.length()).equals(CacheControl.C_UTM20N))
                         ext = ext.substring(3);
                     // check the extension and its compatibility with current projection

applications/editors/josm/plugins/cadastre-fr/src/cadastre_fr/WMSLayer.java

@@ -21 +21 @@
 import java.util.ArrayList;
 import java.util.HashSet;
+import java.util.Locale;
 import java.util.Vector;
 import java.util.concurrent.locks.Lock;
@@ -39 +40 @@
 import org.openstreetmap.josm.gui.dialogs.LayerListPopup;
 import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 
 /**
@@ -77 +79 @@
     public EastNorthBound communeBBox = new EastNorthBound(new EastNorth(0,0), new EastNorth(0,0));
 
-    private boolean isRaster = false;
-    private boolean isAlreadyGeoreferenced = false;
+    private boolean isRaster;
+    private boolean isAlreadyGeoreferenced;
     public double X0, Y0, angle, fX, fY;
 
@@ -87 +89 @@
 
     // offset for vector images temporarily shifted (correcting Cadastre artifacts), in pixels
-    public double deltaEast=0;
-    public double deltaNorth=0;
+    public double deltaEast;
+    public double deltaNorth;
 
     private Action saveAsPng;
@@ -107 +109 @@
             Main.map.mapView.repaint();
         }
-
     }
 
@@ -114 +115 @@
     public GrabThread grabThread;
 
+    /**
+     * Constructs a new {@code WMSLayer}.
+     */
     public WMSLayer() {
         this(tr("Blank Layer"), "", -1);
@@ -142 +146 @@
 
     private static String buildName(String location, String codeCommune) {
-        String ret = location.toUpperCase();
-        if (codeCommune != null && !codeCommune.equals(""))
+        String ret = location.toUpperCase(Locale.FRANCE);
+        if (codeCommune != null && !codeCommune.isEmpty())
             ret += "(" + codeCommune + ")";
         return  ret;
@@ -149 +153 @@
 
     private String rebuildName() {
-        return buildName(this.location.toUpperCase(), this.codeCommune);
+        return buildName(this.location.toUpperCase(Locale.FRANCE), this.codeCommune);
     }
 
@@ -157 +161 @@
         // if it is the first layer, use the communeBBox as grab bbox (and not divided)
         if (Main.map.mapView.getAllLayers().size() == 1 ) {
-            b = this.getCommuneBBox().toBounds();
-            Main.map.mapView.zoomTo(b);
-            divideBbox(b, 1);
+            final Bounds bounds = this.getCommuneBBox().toBounds();
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override
+                public void run() {
+                    Main.map.mapView.zoomTo(bounds);
+                }
+            });
+            divideBbox(bounds, 1);
         } else {
             if (isRaster) {
-                b = new Bounds(Main.getProjection().eastNorth2latlon(rasterMin), Main.getProjection().eastNorth2latlon(rasterMax));
-                divideBbox(b, Integer.parseInt(Main.pref.get("cadastrewms.rasterDivider",
-                        CadastrePreferenceSetting.DEFAULT_RASTER_DIVIDER)));
+                divideBbox(new Bounds(Main.getProjection().eastNorth2latlon(rasterMin), Main.getProjection().eastNorth2latlon(rasterMax)),
+                        Integer.parseInt(Main.pref.get("cadastrewms.rasterDivider", CadastrePreferenceSetting.DEFAULT_RASTER_DIVIDER)));
             } else
-                divideBbox(b, Integer.parseInt(Main.pref.get("cadastrewms.scale", CadastrePreferenceSetting.DEFAULT_GRAB_MULTIPLIER)));
+                divideBbox(b, 
+                        Integer.parseInt(Main.pref.get("cadastrewms.scale", CadastrePreferenceSetting.DEFAULT_GRAB_MULTIPLIER)));
         }
         grabThread.addImages(dividedBbox);
@@ -223 +232 @@
                     j = 0;
                     currDir = (currDir+1)%4;
-                } else if (currDir >= 0 && j >= (currDir == 0 || currDir == 2 ? x-1 : y-1)) {
+                } else if (currDir >= 0 && j >= (currDir == 0 || currDir == 2 ? (x-1) : (y-1))) {
                     // the overall is a rectangle, not a square. Jump to the other side to grab next square.
                     k++;
@@ -251 +260 @@
             str += "\n"+tr("Is not vectorized.");
             str += "\n"+tr("Bounding box: {0}", communeBBox);
-            if(images.size()>0)
+            if(!images.isEmpty())
                 str += "\n"+tr("Image size (px): {0}/{1}", images.get(0).image.getWidth(), images.get(0).image.getHeight());
-        } else
+        } else {
             str += "\n"+tr("Is vectorized.");
             str += "\n"+tr("Commune bbox: {0}", communeBBox);
+        }
         return str;
     }
@@ -266 +276 @@
     @Override
     public void mergeFrom(Layer from) {
+        // Do nothing
     }
 
@@ -318 +329 @@
         refineGeoRef.setEnabled(isRaster && grabThread.getImagesToGrabSize() == 0);
         Action resetOffset = new ResetOffsetActionMenu();
-        resetOffset.setEnabled(!isRaster && images.size() > 0 && (deltaEast!=0.0 || deltaNorth!=0.0));
+        resetOffset.setEnabled(!isRaster && !images.isEmpty() && (deltaEast!=0.0 || deltaNorth!=0.0));
         return new Action[] {
                 LayerListDialog.getInstance().createShowHideLayerAction(),
@@ -328 +339 @@
                 resetOffset,
                 new LayerListPopup.InfoAction(this),
-
         };
     }
@@ -368 +378 @@
         return minX+","+minY+","+maxX+","+maxY;
     }
-
 
     public String getLocation() {
@@ -548 +557 @@
             int newWidth = oldImgWidth*lx.size();
             int newHeight = oldImgHeight*ly.size();
-            BufferedImage new_img = new BufferedImage(newWidth, newHeight, images.get(0).image.getType()/*BufferedImage.TYPE_INT_ARGB*/);
-            Graphics g = new_img.getGraphics();
+            BufferedImage newImg = new BufferedImage(newWidth, newHeight, images.get(0).image.getType()/*BufferedImage.TYPE_INT_ARGB*/);
+            Graphics g = newImg.getGraphics();
             // Coordinate (0,0) is on top,left corner where images are grabbed from bottom left
             int rasterDivider = (int)Math.sqrt(images.size());
@@ -562 +571 @@
             synchronized(this) {
                 images.clear();
-                images.add(new GeorefImage(new_img, min, max, this));
+                images.add(new GeorefImage(newImg, min, max, this));
             }
         }
@@ -586 +595 @@
         rasterMin = adj1;
         rasterMax = adj2;
-        setCommuneBBox(new EastNorthBound(new EastNorth(0,0), new EastNorth(images.get(0).image.getWidth()-1,images.get(0).image.getHeight()-1)));
+        setCommuneBBox(new EastNorthBound(
+                new EastNorth(0,0), 
+                new EastNorth(images.get(0).image.getWidth()-1,images.get(0).image.getHeight()-1)));
         rasterRatio = (rasterMax.getX()-rasterMin.getX())/(communeBBox.max.getX() - communeBBox.min.getX());
     }
@@ -598 +609 @@
             return communeBBox;
         }
-        double min_x = Double.MAX_VALUE;
-        double max_x = Double.MIN_VALUE;
-        double min_y = Double.MAX_VALUE;
-        double max_y = Double.MIN_VALUE;
+        double minX = Double.MAX_VALUE;
+        double maxX = Double.MIN_VALUE;
+        double minY = Double.MAX_VALUE;
+        double maxY = Double.MIN_VALUE;
         for (GeorefImage image:images){
-            min_x = image.min.east() < min_x ? image.min.east() : min_x;
-            max_x = image.max.east() > max_x ? image.max.east() : max_x;
-            min_y = image.min.north() < min_y ? image.min.north() : min_y;
-            max_y = image.max.north() > max_y ? image.max.north() : max_y;
-        }
-        EastNorthBound maxGrabbedBBox = new EastNorthBound(new EastNorth(min_x, min_y), new EastNorth(max_x, max_y));
-        return maxGrabbedBBox;
+            minX = image.min.east() < minX ? image.min.east() : minX;
+            maxX = image.max.east() > maxX ? image.max.east() : maxX;
+            minY = image.min.north() < minY ? image.min.north() : minY;
+            maxY = image.max.north() > maxY ? image.max.north() : maxY;
+        }
+        return new EastNorthBound(new EastNorth(minX, minY), new EastNorth(maxX, maxY));
     }
 
@@ -653 +663 @@
         this.rasterMin = rasterMin.rotate(rasterCenter, angle);
         this.rasterMax = rasterMax.rotate(rasterCenter, angle);
-//        double proportion = dst1.distance(dst2)/org1.distance(org2);
         images.get(0).rotate(rasterCenter, angle);
         this.angle += angle;
@@ -718 +727 @@
         imagesLock.unlock();
     }
-
 }