Changeset 31987 in osm for applications/editors/josm/plugins/mapillary/src

Timestamp:

2016-01-16T15:22:13+01:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Fix some minor issues

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryData.java (modified) (1 diff)
• actions/MapillaryExportAction.java (modified) (1 diff)
• actions/WalkThread.java (modified) (2 diffs)
• history/MapillaryRecord.java (modified) (1 diff)
• io/download/MapillaryDownloader.java (modified) (2 diffs)
• oauth/OAuthUtils.java (modified) (1 diff)
• oauth/UploadUtils.java (modified) (2 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryData.java

@@ -375 +375 @@
   }
 
-  private void fireSelectedImageChanged(MapillaryAbstractImage oldImage,
-                                        MapillaryAbstractImage newImage) {
+  private void fireSelectedImageChanged(MapillaryAbstractImage oldImage, MapillaryAbstractImage newImage) {
     if (this.listeners.isEmpty())
       return;
-    for (MapillaryDataListener lis : this.listeners)
+    for (MapillaryDataListener lis : this.listeners) {
       if (lis != null)
         lis.selectedImageChanged(oldImage, newImage);
+    }
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryExportAction.java

@@ -91 +91 @@
     } else if (this.dialog.group.isSelected(this.dialog.rewrite.getModel())) {
       ArrayList<MapillaryImportedImage> images = new ArrayList<>();
-      for (MapillaryAbstractImage image : MapillaryLayer.getInstance()
-          .getData().getImages())
+      for (MapillaryAbstractImage image : MapillaryLayer.getInstance().getData().getImages()) {
         if (image instanceof MapillaryImportedImage) {
           images.add((MapillaryImportedImage) image);
         }
+      }
       try {
         Main.worker.submit(new Thread(new MapillaryExportManager(images)));

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/WalkThread.java

@@ -58 +58 @@
       while (!this.end && this.data.getSelectedImage().next() != null) {
         MapillaryAbstractImage image = this.data.getSelectedImage();
-        if (image instanceof MapillaryImage) {
+        if (image != null && image.next() instanceof MapillaryImage) {
           // Predownload next 10 thumbnails.
-          for (int i = 0; i < 10; i++) {
-            if (image.next() == null) {
-              break;
-            }
-            image = image.next();
-            CacheUtils.downloadPicture((MapillaryImage) image, CacheUtils.PICTURE.THUMBNAIL);
+          preDownloadImages((MapillaryImage) image.next(), 10, CacheUtils.PICTURE.THUMBNAIL);
+          if (this.waitForFullQuality) {
+            // Start downloading 3 next full images.
+            preDownloadImages((MapillaryImage) image.next(), 3, CacheUtils.PICTURE.FULL_IMAGE);
           }
-          if (this.waitForFullQuality)
-            // Start downloading 3 next full images.
-            for (int i = 0; i < 3; i++) {
-              if (image.next() == null) {
-                break;
-              }
-              image = image.next();
-              CacheUtils.downloadPicture((MapillaryImage) image, CacheUtils.PICTURE.FULL_IMAGE);
-            }
         }
         try {
@@ -117 +106 @@
     }
     end();
+  }
+
+  /**
+   * Downloads n images into the cache beginning from the supplied start-image (including the start-image itself).
+   * @param startImage the image to start with (this and the next n-1 images in the same sequence are downloaded)
+   * @param n the number of images to download
+   * @param type the quality of the image (full or thumbnail)
+   */
+  private void preDownloadImages(MapillaryImage startImage, int n, CacheUtils.PICTURE type) {
+    if (n >= 1 && startImage != null) {
+      CacheUtils.downloadPicture(startImage, type);
+      if (startImage.next() instanceof MapillaryImage && n >= 2) {
+        preDownloadImages((MapillaryImage) startImage.next(), n - 1, type);
+      }
+    }
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/history/MapillaryRecord.java

@@ -122 +122 @@
 
   private void fireRecordChanged() {
-    for (MapillaryRecordListener lis : this.listeners)
+    for (MapillaryRecordListener lis : this.listeners) {
       if (lis != null)
         lis.recordChanged();
+    }
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/download/MapillaryDownloader.java

@@ -26 +26 @@
  *
  */
-public class MapillaryDownloader {
+public final class MapillaryDownloader {
 
   /** Possible download modes. */
@@ -39 +39 @@
   /** Executor that will run the petitions. */
   private static ThreadPoolExecutor executor = new ThreadPoolExecutor(3, 5, 100, TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(100));
+
+  private MapillaryDownloader() {
+    // Private constructor to avoid instantiation
+  }
 
   /**

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/OAuthUtils.java

@@ -19 +19 @@
  *
  */
-public class OAuthUtils {
+public final class OAuthUtils {
+
+  private OAuthUtils() {
+    // Private constructor to avoid instantiation
+  }
 
   /**

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/UploadUtils.java

@@ -33 +33 @@
 import org.apache.commons.imaging.formats.tiff.write.TiffOutputSet;
 import org.apache.http.HttpEntity;
-import org.apache.http.HttpResponse;
-import org.apache.http.client.HttpClient;
+import org.apache.http.client.methods.CloseableHttpResponse;
 import org.apache.http.client.methods.HttpPost;
 import org.apache.http.entity.ContentType;
@@ -260 +259 @@
       HttpEntity entity = entityBuilder.build();
       httpPost.setEntity(entity);
-      HttpResponse response = httpClient.execute(httpPost);
-
-      if (response.getStatusLine().toString().contains("204")) {
-        PluginState.imageUploaded();
-        Main.info(PluginState.getUploadString() + " (Mapillary)");
-      } else {
-        Main.info("Upload error");
+      try (CloseableHttpResponse response = httpClient.execute(httpPost)) {
+        if (response.getStatusLine().toString().contains("204")) {
+          PluginState.imageUploaded();
+          Main.info(PluginState.getUploadString() + " (Mapillary)");
+        } else {
+          Main.info("Upload error");
+        }
       }
     }