Changeset 31976 in osm for applications/editors/josm

Timestamp:

2016-01-11T23:12:52+01:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Minor beauty fixes both codewise and GUI-wise

• Adds mapillary icon to mapillary preferences tab
• Simplify access token parsing

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryPlugin.java (modified) (2 diffs)
• gui/MapillaryPreferenceSetting.java (modified) (2 diffs)
• oauth/OAuthPortListener.java (modified) (3 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryPlugin.java

@@ -2 +2 @@
 package org.openstreetmap.josm.plugins.mapillary;
 
+import java.awt.Image;
 import java.io.IOException;
 
@@ -48 +49 @@
   /** 16x16 icon. */
   public static final ImageIcon ICON16 = new ImageProvider("icon16.png").get();
+  /** 12x12 icon. */
+  public static final ImageIcon ICON12 = new ImageIcon(ICON24.getImage().getScaledInstance(12, 12, Image.SCALE_SMOOTH));
   /** Icon representing an image in the map. */
   public static final ImageIcon MAP_ICON = new ImageProvider("mapicon.png").get();

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryPreferenceSetting.java

@@ -74 +74 @@
     panel.add(this.reverseButtons, GBC.eol());
     // Sets the value of the ComboBox.
-    if (Main.pref.get("mapillary.download-mode").equals(MapillaryDownloader.MODES.Automatic.toString())
-        || Main.pref.get("mapillary.download-mode").equals(MapillaryDownloader.MODES.Semiautomatic.toString())
-        || Main.pref.get("mapillary.download-mode").equals(MapillaryDownloader.MODES.Manual.toString())) {
+    String downloadMode = Main.pref.get("mapillary.download-mode");
+    if (MapillaryDownloader.MODES.Automatic.toString().equals(downloadMode)
+        || MapillaryDownloader.MODES.Semiautomatic.toString().equals(downloadMode)
+        || MapillaryDownloader.MODES.Manual.toString().equals(downloadMode)) {
       this.downloadMode.setSelectedItem(Main.pref.get("mapillary.download-mode"));
     }
@@ -94 +95 @@
     panel.add(Box.createVerticalGlue(), GBC.eol().fill(GridBagConstraints.BOTH));
 
-    gui.getDisplayPreference().addSubTab(this, "Mapillary", new JScrollPane(panel));
+    synchronized (gui.getDisplayPreference().getTabPane()) {
+      gui.getDisplayPreference().addSubTab(this, "Mapillary", new JScrollPane(panel));
+      gui.getDisplayPreference().getTabPane().setIconAt(gui.getDisplayPreference().getTabPane().getTabCount()-1, MapillaryPlugin.ICON12);
+    }
 
     new Thread(new Runnable() {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/OAuthPortListener.java

@@ -10 +10 @@
 import java.net.Socket;
 import java.util.Scanner;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
 
 import org.openstreetmap.josm.Main;
@@ -47 +49 @@
       while (in.hasNextLine() && accessToken == null) {
         s = in.nextLine();
-        if (s.contains("access_token=")) {
-          String[] ss = s.split("&");
-          for (int i = 0; i < ss.length && accessToken == null; i++) {
-            if (ss[i].startsWith("access_token=")) {
-              accessToken = ss[i].substring(ss[i].indexOf("access_token=") + 13, ss[i].length());
-            }
-          }
+        Matcher tokenMatcher = Pattern.compile("^.*&access_token=([^&]+)&.*$").matcher('&'+s+'&');
+        if (tokenMatcher.matches()) {
+          accessToken = tokenMatcher.group(1);
           break;
         } else if (s.contains("keep-alive")) {
@@ -61 +59 @@
 
       writeContent(out);
-
-      out.close();
-      in.close();
-      serverSocket.close();
+      out.flush();
 
       MapillaryUser.reset();