Changeset 31951 in osm for applications/editors/josm/plugins/mapillary/src/org

Timestamp:

2016-01-05T16:54:55+01:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Fix some code style issues

Mainly:

• Avoid if (x != y) ..; else ..;
• Avoid using for/while statements without curly braces

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryData.java (modified) (2 diffs)
• MapillaryLayer.java (modified) (2 diffs)
• history/MapillaryRecord.java (modified) (1 diff)
• io/download/MapillaryDownloader.java (modified) (2 diffs)
• io/download/MapillarySquareDownloadManagerThread.java (modified) (1 diff)
• io/download/MapillaryTrafficSignDownloadThread.java (modified) (1 diff)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryData.java

@@ -139 +139 @@
    */
   public void addMultiSelectedImage(Set<MapillaryAbstractImage> images) {
-    for (MapillaryAbstractImage image : images)
+    for (MapillaryAbstractImage image : images) {
       if (!this.multiSelectedImages.contains(image)) {
-        if (this.getSelectedImage() != null)
+        if (this.getSelectedImage() == null) {
+          this.setSelectedImage(image);
+        } else {
           this.multiSelectedImages.add(image);
-        else
-          this.setSelectedImage(image);
+        }
       }
+    }
     Main.map.mapView.repaint();
   }
@@ -237 +239 @@
     if (this.listeners.isEmpty())
       return;
-    for (MapillaryDataListener lis : this.listeners)
+    for (MapillaryDataListener lis : this.listeners) {
       if (lis != null)
         lis.imagesAdded();
+    }
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryLayer.java

@@ -239 +239 @@
   public void setVisible(boolean visible) {
     super.setVisible(visible);
-    for (MapillaryAbstractImage img : this.data.getImages())
+    for (MapillaryAbstractImage img : this.data.getImages()) {
       img.setVisible(visible);
+    }
     MapillaryFilterDialog.getInstance().refresh();
   }
@@ -347 +348 @@
         MapillaryImage image = (MapillaryImage) imageAbs;
         ImageIcon icon;
-        if (!this.data.getMultiSelectedImages().contains(image))
-          icon = MapillaryPlugin.MAP_ICON;
-        else
-          icon = MapillaryPlugin.MAP_ICON_SELECTED;
+        icon = this.data.getMultiSelectedImages().contains(image) ? MapillaryPlugin.MAP_ICON_SELECTED : MapillaryPlugin.MAP_ICON;
         draw(g, image, icon, p);
         if (!image.getSigns().isEmpty()) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/history/MapillaryRecord.java

@@ -77 +77 @@
     if (this.position != -1) {
       boolean equalSets = true;
-      for (MapillaryAbstractImage img : this.commandList.get(this.position).images)
-        if (!command.images.contains(img))
-          equalSets = false;
-      for (MapillaryAbstractImage img : command.images)
-        if (!this.commandList.get(this.position).images.contains(img))
-          equalSets = false;
-      if (equalSets
-          && this.commandList.get(this.position).getClass() == command
-              .getClass()) {
+      for (MapillaryAbstractImage img : this.commandList.get(this.position).images) {
+        equalSets = command.images.contains(img) && equalSets;
+      }
+      for (MapillaryAbstractImage img : command.images) {
+        equalSets = this.commandList.get(this.position).images.contains(img) && equalSets;
+      }
+      if (equalSets && this.commandList.get(this.position).getClass() == command.getClass()) {
         this.commandList.get(this.position).sum(command);
         fireRecordChanged();

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/download/MapillaryDownloader.java

@@ -182 +182 @@
 
   protected static void tooBigErrorDialog() {
-    if (!SwingUtilities.isEventDispatchThread()) {
+    if (SwingUtilities.isEventDispatchThread()) {
+      MapillaryLayer.getInstance().tempSemiautomatic = true;
+      MapillaryPlugin.setMenuEnabled(MapillaryPlugin.getDownloadViewMenu(), true);
+      JOptionPane
+          .showMessageDialog(
+              Main.parent,
+              tr("The downloaded OSM area is too big. Download mode has been changed to semiautomatic until the layer is restarted."));
+    } else {
       SwingUtilities.invokeLater(new Runnable() {
         @Override
@@ -189 +196 @@
         }
       });
-    } else {
-      MapillaryLayer.getInstance().tempSemiautomatic = true;
-      MapillaryPlugin.setMenuEnabled(MapillaryPlugin.getDownloadViewMenu(), true);
-      JOptionPane
-          .showMessageDialog(
-              Main.parent,
-              tr("The downloaded OSM area is too big. Download mode has been changed to semiautomatic until the layer is restarted."));
     }
   }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/download/MapillarySquareDownloadManagerThread.java

@@ -76 +76 @@
     while (!this.downloadExecutor.isShutdown()) {
       this.downloadExecutor.execute(new MapillarySequenceDownloadThread(this.downloadExecutor, bounds, page));
-      while (this.downloadExecutor.getQueue().remainingCapacity() == 0)
+      while (this.downloadExecutor.getQueue().remainingCapacity() == 0) {
         Thread.sleep(500);
+      }
       page++;
     }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/download/MapillaryTrafficSignDownloadThread.java

@@ -66 +66 @@
             for (int k = 0; k < rects.size(); k++) {
               JsonObject data = rects.getJsonObject(k);
-              for (MapillaryAbstractImage image : MapillaryLayer.getInstance().getData().getImages())
+              for (MapillaryAbstractImage image : MapillaryLayer.getInstance().getData().getImages()) {
                 if (image instanceof MapillaryImage && ((MapillaryImage) image).getKey().equals(key))
                   ((MapillaryImage) image).addSign(data.getString("type"));
+              }
             }
           }