Changeset 31907 in osm for applications/editors/josm/plugins/wikipedia

Timestamp:

2016-01-02T12:10:39+01:00 (9 years ago)

Author:

simon04

Message:

JOSM/wikipedia: fix and test WIWOSM status fetching

Location:

applications/editors/josm/plugins/wikipedia

Files:

• src/org/wikipedia/WikipediaApp.java (modified) (1 diff)
• test/unit/org/wikipedia/WikipediaAppTest.java (modified) (1 diff)

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java

@@ -128 +128 @@
                 final String requestBody = "articles=" + Utils.encodeUrl(Utils.join(",", articleNames));
                 try (final Scanner scanner = new Scanner(
-                        HttpClient.create(new URL(url), "PUT").setReasonForRequest("Wikipedia")
+                        HttpClient.create(new URL(url), "POST").setReasonForRequest("Wikipedia")
+                                .setHeader("Content-Type", "application/x-www-form-urlencoded")
                                 .setRequestBody(requestBody.getBytes(StandardCharsets.UTF_8))
                                 .connect().getContentReader())

applications/editors/josm/plugins/wikipedia/test/unit/org/wikipedia/WikipediaAppTest.java

@@ -155 +155 @@
         WikipediaApp.getLabelForWikidata("Qxyz", "en");
     }
+
+    @Test
+    public void testWIWOSMStatus() throws Exception {
+        final WikipediaEntry entry1 = new WikipediaEntry(null, "en", "Vienna");
+        final WikipediaEntry entry2 = new WikipediaEntry(null, "en", "London");
+        final WikipediaEntry entry3 = new WikipediaEntry(null, "en", "a-non-existing-article");
+        WikipediaApp.updateWIWOSMStatus("en", Arrays.asList(entry1, entry2, entry3));
+        assertThat(entry1.getWiwosmStatus(), is(true));
+        assertThat(entry2.getWiwosmStatus(), is(true));
+        assertThat(entry3.getWiwosmStatus(), is(false));
+    }
 }