Changeset 31857 in osm for applications/editors/josm/plugins/wikipedia

Timestamp:

2015-12-25T20:03:27+01:00 (9 years ago)

Author:

simon04

Message:

JOSM/wikipedia: Demystify Wikidata tags - see #josm9775

Location:

applications/editors/josm/plugins/wikipedia

Files:

• build.xml (modified) (1 diff)
• src/org/wikipedia/WikidataTagCellRenderer.java (added)
• src/org/wikipedia/WikipediaApp.java (modified) (3 diffs)
• src/org/wikipedia/WikipediaPlugin.java (modified) (1 diff)
• test/unit/org/wikipedia/WikipediaAppTest.java (modified) (1 diff)

applications/editors/josm/plugins/wikipedia/build.xml

@@ -5 +5 @@
     <property name="commit.message" value="Commit message"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="7817"/>
+    <property name="plugin.main.version" value="9149"/>
     <property name="plugin.canloadatruntime" value="true"/>
 

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaApp.java

@@ -29 +29 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.data.osm.Tag;
+import org.openstreetmap.josm.tools.CheckParameterUtil;
 import org.openstreetmap.josm.tools.Predicate;
 import org.openstreetmap.josm.tools.Utils;
@@ -37 +38 @@
 
 public final class WikipediaApp {
+
+    public static Pattern WIKIDATA_PATTERN = Pattern.compile("Q\\d+");
 
     private WikipediaApp() {
@@ -201 +204 @@
     }
 
+    static String getLabelForWikidata(String wikidataId, String preferredLanguage) {
+        try {
+            CheckParameterUtil.ensureThat(WIKIDATA_PATTERN.matcher(wikidataId).matches(), "Invalid Wikidata ID given");
+            final String url = "https://www.wikidata.org/w/api.php" +
+                    "?action=wbgetentities" +
+                    "&props=labels" +
+                    "&ids=" + wikidataId +
+                    "&languages=" + preferredLanguage +
+                    "&languagefallback=en" +
+                    "&format=xml";
+            Main.info("Wikipedia: GET " + url);
+            try (final InputStream in = Utils.openURL(new URL(url))) {
+                final Document xml = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(in);
+                final Node label = (Node) XPathFactory.newInstance().newXPath().compile("//label").evaluate(xml, XPathConstants.NODE);
+                if (label == null) {
+                    return null;
+                } else {
+                    return (String) XPathFactory.newInstance().newXPath().compile("./@value").evaluate(label, XPathConstants.STRING);
+                }
+            }
+        } catch (Exception ex) {
+            throw new RuntimeException(ex);
+        }
+    }
+
     static Collection<WikipediaLangArticle> getInterwikiArticles(String wikipediaLang, String article) {
         try {

applications/editors/josm/plugins/wikipedia/src/org/wikipedia/WikipediaPlugin.java

@@ -21 +21 @@
         if (newFrame != null) {
             newFrame.addToggleDialog(new WikipediaToggleDialog());
+            newFrame.propertiesDialog.addCustomPropertiesCellRenderer(new WikidataTagCellRenderer());
         }
     }

applications/editors/josm/plugins/wikipedia/test/unit/org/wikipedia/WikipediaAppTest.java

@@ -143 +143 @@
         assertThat(map.size(), is(4));
     }
+
+    @Test
+    public void testGetLabelForWikidata() throws Exception {
+        assertThat(WikipediaApp.getLabelForWikidata("Q1741", "de"), is("Wien"));
+        assertThat(WikipediaApp.getLabelForWikidata("Q1741", "en"), is("Vienna"));
+        assertThat(WikipediaApp.getLabelForWikidata("Q" + Long.MAX_VALUE, "en"), nullValue());
+    }
+
+    @Test(expected = RuntimeException.class)
+    public void testGetLabelForWikidataInvalidId() throws Exception {
+        WikipediaApp.getLabelForWikidata("Qxyz", "en");
+    }
 }