Changeset 31811 in osm

Timestamp:

2015-12-11T22:41:01+01:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Fix sonar issues "Immutable field"

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryImage.java (modified) (2 diffs)
• actions/MapillaryExportAction.java (modified) (2 diffs)
• actions/MapillaryWalkAction.java (modified) (1 diff)
• gui/HyperlinkLabel.java (modified) (1 diff)
• gui/MapillaryExportDialog.java (modified) (1 diff)
• gui/MapillaryHistoryDialog.java (modified) (2 diffs)
• history/MapillaryRecord.java (modified) (2 diffs)
• history/commands/CommandDelete.java (modified) (2 diffs)
• io/download/MapillarySquareDownloadManagerThread.java (modified) (1 diff)
• io/export/MapillaryExportDownloadThread.java (modified) (1 diff)
• io/export/MapillaryExportManager.java (modified) (1 diff)
• mode/SelectMode.java (modified) (1 diff)
• oauth/OAuthPortListener.java (modified) (1 diff)
• oauth/UploadUtils.java (modified) (2 diffs)
• traffico/TrafficoSignElement.java (modified) (1 diff)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryImage.java

@@ -18 +18 @@
   private String user;
   /** Set of traffic signs in the image. */
-  private List<String> signs;
+  private final List<String> signs = new ArrayList<>();
   /** Where the picture was taken. */
   private String location;
@@ -37 +37 @@
     super(lat, lon, ca);
     this.key = key;
-    this.signs = new ArrayList<>();
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryExportAction.java

@@ -115 +115 @@
 
   private class OKAction implements ActionListener {
-    private JOptionPane pane;
+    private final JOptionPane pane;
 
     public OKAction(JOptionPane pane) {
@@ -128 +128 @@
 
   private class CancelAction implements ActionListener {
-    private JOptionPane pane;
+    private final JOptionPane pane;
 
     public CancelAction(JOptionPane pane) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryWalkAction.java

@@ -27 +27 @@
  *
  */
-public class MapillaryWalkAction extends JosmAction implements
-    MapillaryDataListener {
+public class MapillaryWalkAction extends JosmAction implements MapillaryDataListener {
 
   private static final long serialVersionUID = 3454223919402245818L;
 
   private WalkThread thread = null;
-  private ArrayList<WalkListener> listeners = new ArrayList<>();
+  private final ArrayList<WalkListener> listeners = new ArrayList<>();
 
   /**

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/HyperlinkLabel.java

@@ -114 +114 @@
     private static final long serialVersionUID = 1384054752970921552L;
 
-    private JMenuItem copy;
-    private JMenuItem copyTag;
-    private JMenuItem edit;
+    private final JMenuItem copy;
+    private final JMenuItem copyTag;
+    private final JMenuItem edit;
 
     public LinkPopUp() {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryExportDialog.java

@@ -147 +147 @@
     private static final long serialVersionUID = -9103251296651015563L;
     private String lastPath;
-    private MapillaryExportDialog dlg;
+    private final MapillaryExportDialog dlg;
 
     /**

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryHistoryDialog.java

@@ -56 +56 @@
   private static MapillaryHistoryDialog instance;
 
-  private transient UndoRedoSelectionListener undoSelectionListener;
-  private transient UndoRedoSelectionListener redoSelectionListener;
+  private final transient UndoRedoSelectionListener undoSelectionListener;
+  private final transient UndoRedoSelectionListener redoSelectionListener;
 
   private final DefaultTreeModel undoTreeModel = new DefaultTreeModel(
@@ -66 +66 @@
   private final JTree redoTree = new JTree(this.redoTreeModel);
 
-  private JSeparator separator = new JSeparator();
-  private Component spacer = Box.createRigidArea(new Dimension(0, 3));
-
-  private SideButton undoButton;
-  private SideButton redoButton;
-
-  private ConcurrentHashMap<Object, MapillaryCommand> map;
+  private final JSeparator separator = new JSeparator();
+  private final Component spacer = Box.createRigidArea(new Dimension(0, 3));
+
+  private final SideButton undoButton;
+  private final SideButton redoButton;
+
+  private final ConcurrentHashMap<Object, MapillaryCommand> map;
 
   private MapillaryHistoryDialog() {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/history/MapillaryRecord.java

@@ -19 +19 @@
   private static MapillaryRecord instance;
 
-  private ArrayList<MapillaryRecordListener> listeners;
+  private final ArrayList<MapillaryRecordListener> listeners = new ArrayList<>();
 
   /** The set of commands that have taken place or that have been undone. */
@@ -32 +32 @@
     this.commandList = new ArrayList<>();
     this.position = -1;
-    this.listeners = new ArrayList<>();
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/history/commands/CommandDelete.java

@@ -18 +18 @@
 public class CommandDelete extends MapillaryExecutableCommand {
 
-  private HashMap<MapillaryAbstractImage, Integer> changesHash;
+  private final HashMap<MapillaryAbstractImage, Integer> changesHash = new HashMap<>();
 
   /**
@@ -28 +28 @@
   public CommandDelete(List<MapillaryAbstractImage> images) {
     super(images);
-    this.changesHash = new HashMap<>();
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/download/MapillarySquareDownloadManagerThread.java

@@ -37 +37 @@
   private final String signQueryString;
 
-  private ThreadPoolExecutor downloadExecutor = new ThreadPoolExecutor(3, 5,
+  private final ThreadPoolExecutor downloadExecutor = new ThreadPoolExecutor(3, 5,
       25, TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(5));
-  private ThreadPoolExecutor completeExecutor = new ThreadPoolExecutor(3, 5,
+  private final ThreadPoolExecutor completeExecutor = new ThreadPoolExecutor(3, 5,
       25, TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(5));
-  private ThreadPoolExecutor signsExecutor = new ThreadPoolExecutor(3, 5, 25,
+  private final ThreadPoolExecutor signsExecutor = new ThreadPoolExecutor(3, 5, 25,
       TimeUnit.SECONDS, new ArrayBlockingQueue<Runnable>(5));
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/export/MapillaryExportDownloadThread.java

@@ -29 +29 @@
     ICachedLoaderListener {
 
-  private ArrayBlockingQueue<BufferedImage> queue;
-  private ArrayBlockingQueue<MapillaryAbstractImage> queueImages;
+  private final ArrayBlockingQueue<BufferedImage> queue;
+  private final ArrayBlockingQueue<MapillaryAbstractImage> queueImages;
 
-  private MapillaryImage image;
+  private final MapillaryImage image;
 
   /**

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/io/export/MapillaryExportManager.java

@@ -34 +34 @@
 public class MapillaryExportManager extends PleaseWaitRunnable {
 
-  private ArrayBlockingQueue<BufferedImage> queue;
-  private ArrayBlockingQueue<MapillaryAbstractImage> queueImages;
+  private final ArrayBlockingQueue<BufferedImage> queue;
+  private final ArrayBlockingQueue<MapillaryAbstractImage> queueImages;
 
   private final int amount;

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/mode/SelectMode.java

@@ -36 +36 @@
   private MapillaryAbstractImage closest;
   private MapillaryAbstractImage lastClicked;
-  private MapillaryRecord record;
+  private final MapillaryRecord record;
   private boolean nothingHighlighted;
   private boolean imageHighlighted = false;

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/OAuthPortListener.java

@@ -29 +29 @@
       I18n.tr("Login successful, return to JOSM.")
   );
-  private MapillaryLoginListener callback;
+  private final MapillaryLoginListener callback;
 
   public OAuthPortListener(MapillaryLoginListener loginCallback) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/UploadUtils.java

@@ -57 +57 @@
 
   private static class SequenceUploadThread extends Thread {
-    private List<MapillaryAbstractImage> images;
-    private UUID uuid;
-    private boolean delete;
+    private final List<MapillaryAbstractImage> images;
+    private final UUID uuid;
+    private final boolean delete;
     ThreadPoolExecutor ex;
 
@@ -101 +101 @@
   private static class SingleUploadThread extends Thread {
 
-    private MapillaryImportedImage image;
-    private UUID uuid;
+    private final MapillaryImportedImage image;
+    private final UUID uuid;
 
     private SingleUploadThread(MapillaryImportedImage image, UUID uuid) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/traffico/TrafficoSignElement.java

@@ -6 +6 @@
 public class TrafficoSignElement {
 
-  private Color color;
-  private char glyph;
+  private final Color color;
+  private final char glyph;
 
   public TrafficoSignElement(char glyph, Color c) {