Changeset 31789 in osm for applications/editors/josm/plugins/mapillary/src

Timestamp:

2015-12-02T17:06:43+01:00 (9 years ago)

Author:

floscher

Message:

[mapillary] Always place images without coordinates exactly in the center

Previously they were spread out horizontally, but that led to strange situations when importing many not-geotagged images:

• When dealing with more than say 20 imported images, or you were very much zoomed in, the images began to appear outside your viewport
• When you imported one batch, moved the viewport, then imported a second batch, the first image of the second batch already had an offset

File:

• applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/utils/MapillaryUtils.java (modified) (4 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/utils/MapillaryUtils.java

@@ -44 +44 @@
 
   private static double MIN_ZOOM_SQUARE_SIDE = 0.002;
-
-  private static int noTagsPics = 0;
 
   /**
@@ -328 +326 @@
    */
   public static MapillaryImportedImage readNoTags(File file, LatLon pos) {
-    double HORIZONTAL_DISTANCE = 0.0001;
-    double horDev;
-
-    if (noTagsPics % 2 == 0)
-      horDev = HORIZONTAL_DISTANCE * noTagsPics / 2;
-    else
-      horDev = -HORIZONTAL_DISTANCE * ((noTagsPics + 1) / 2);
-    noTagsPics++;
-
     ImageMetadata metadata = null;
     try {
@@ -351 +340 @@
               ExifTagConstants.EXIF_TAG_DATE_TIME_ORIGINAL);
       if (datetimeOriginal == null)
-        return new MapillaryImportedImage(pos.lat(), pos.lon() + horDev, 0,
+        return new MapillaryImportedImage(pos.lat(), pos.lon(), 0,
             file);
       else {
         try {
-          return new MapillaryImportedImage(pos.lat(), pos.lon() + horDev, 0,
+          return new MapillaryImportedImage(pos.lat(), pos.lon(), 0,
               file, datetimeOriginal.getStringValue());
         } catch (ImageReadException e) {
@@ -362 +351 @@
       }
     }
-    return new MapillaryImportedImage(pos.lat(), pos.lon() + horDev, 0, file);
+    return new MapillaryImportedImage(pos.lat(), pos.lon(), 0, file);
   }