Changeset 31460 in osm for applications/editors/josm/plugins/mapillary/test

Timestamp:

2015-08-06T16:55:15+02:00 (9 years ago)

Author:

nokutu

Message:

Created several new tests and improved comments.

Location:

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary

Files:

• AbstractTest.java (modified) (1 diff)
• ImportTest.java (modified) (2 diffs)
• MapillaryAbstractImageTest.java (modified) (1 diff)
• MapillaryDataTest.java (added)
• MapillarySequenceTest.java (added)
• oauth (added)
• oauth/UploadTest.java (moved) (moved from applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/UploadTest.java ) (2 diffs)
• utils/MapillaryUtilsTest.java (added)
• utils/TestUtil.java (modified) (1 diff)

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/AbstractTest.java

@@ -12 +12 @@
 public abstract class AbstractTest {
 
-  private static boolean started = false;
-
   /**
    * Initiates the basic parts of JOSM.

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/ImportTest.java

@@ -10 +10 @@
 import javax.imageio.IIOException;
 
-import org.apache.commons.imaging.common.RationalNumber;
-import org.apache.commons.imaging.formats.tiff.constants.GpsTagConstants;
 import org.openstreetmap.josm.data.coor.LatLon;
 import org.openstreetmap.josm.plugins.mapillary.actions.MapillaryImportAction;
-import org.openstreetmap.josm.plugins.mapillary.utils.MapillaryUtils;
 
 /**
@@ -51 +48 @@
     img.getImage();
   }
-
-  /**
-   * Test degMinSecToDouble method.
-   */
-  @Test
-  public void degMinSecToDoubleTest() {
-    RationalNumber[] num = new RationalNumber[3];
-    num[0] = new RationalNumber(1, 1);
-    num[1] = new RationalNumber(0, 1);
-    num[2] = new RationalNumber(0, 1);
-    String ref = GpsTagConstants.GPS_TAG_GPS_LATITUDE_REF_VALUE_NORTH;
-    assertEquals(1, MapillaryUtils.degMinSecToDouble(num, ref), 0.01);
-    ref = GpsTagConstants.GPS_TAG_GPS_LATITUDE_REF_VALUE_SOUTH;
-    assertEquals(-1, MapillaryUtils.degMinSecToDouble(num, ref), 0.01);
-    num[0] = new RationalNumber(180, 1);
-    assertEquals(-180, MapillaryUtils.degMinSecToDouble(num, ref), 0.01);
-    num[0] = new RationalNumber(190, 1);
-    assertEquals(170, MapillaryUtils.degMinSecToDouble(num, ref), 0.01);
-  }
 }

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImageTest.java

@@ -42 +42 @@
   }
 
-  private void testGetDate(String expected, MapillaryAbstractImage img,
+  private static void testGetDate(String expected, MapillaryAbstractImage img,
       boolean isoDates, boolean displayHour, boolean format24) {
     Main.pref.put("iso.dates", isoDates);

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/oauth/UploadTest.java

@@ -1 @@
-package org.openstreetmap.josm.plugins.mapillary;
+package org.openstreetmap.josm.plugins.mapillary.oauth;
 
 import static org.junit.Assert.assertEquals;
@@ -18 +18 @@
 import org.junit.Test;
 import org.openstreetmap.josm.data.coor.LatLon;
+import org.openstreetmap.josm.plugins.mapillary.AbstractTest;
+import org.openstreetmap.josm.plugins.mapillary.MapillaryImportedImage;
 import org.openstreetmap.josm.plugins.mapillary.actions.MapillaryImportAction;
 import org.openstreetmap.josm.plugins.mapillary.oauth.UploadUtils;
 import org.openstreetmap.josm.plugins.mapillary.utils.MapillaryUtils;
 
+/**
+ * Tests the {@link UploadUtils} class.
+ *
+ * @author nokutu
+ * @see UploadUtils
+ */
 public class UploadTest extends AbstractTest {
 
   /**
-   * Tests the updateFile method from {@link MapillaryImportAction} class.
+   * Tests the {@link UploadUtils#updateFile(MapillaryImportedImage)} method.
    */
   @Test

applications/editors/josm/plugins/mapillary/test/unit/org/openstreetmap/josm/plugins/mapillary/utils/TestUtil.java

@@ -1 +1 @@
 package org.openstreetmap.josm.plugins.mapillary.utils;
 
-import java.io.File;
 
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.projection.Projections;
-import org.openstreetmap.josm.plugins.PluginException;
-import org.openstreetmap.josm.plugins.PluginInformation;
 import org.openstreetmap.josm.plugins.mapillary.MapillaryLayer;
-import org.openstreetmap.josm.plugins.mapillary.MapillaryPlugin;
 import org.openstreetmap.josm.tools.I18n;