Changeset 31415 in osm for applications/editors/josm/plugins/mapillary/src

Timestamp:

2015-07-30T13:17:32+02:00 (9 years ago)

Author:

nokutu

Message:

Fixed several findbugs problems

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• MapillaryAbstractImage.java (modified) (2 diffs)
• MapillaryData.java (modified) (1 diff)
• MapillaryLayer.java (modified) (1 diff)
• actions/MapillaryImportAction.java (modified) (2 diffs)
• actions/MapillaryImportIntoSequenceAction.java (modified) (2 diffs)
• actions/MapillaryWalkAction.java (modified) (1 diff)
• actions/WalkThread.java (modified) (4 diffs)
• downloads/MapillarySequenceDownloadThread.java (modified) (3 diffs)
• gui/MapillaryFilterDialog.java (modified) (3 diffs)
• gui/MapillaryWalkDialog.java (modified) (1 diff)
• mode/SelectMode.java (modified) (1 diff)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryAbstractImage.java

@@ -281 +281 @@
    */
   public MapillaryAbstractImage next() {
-    synchronized (LOCK) {
-      if (this.getSequence() == null)
+    LOCK.lock();
+    try {
+      if (this.getSequence() == null) {
         return null;
+      }
       return this.getSequence().next(this);
+    } finally {
+      LOCK.unlock();
     }
   }
@@ -295 +299 @@
    */
   public MapillaryAbstractImage previous() {
-    synchronized (LOCK) {
-      if (this.getSequence() == null)
+    LOCK.lock();
+    try {
+      if (this.getSequence() == null) {
         return null;
+      }
       return this.getSequence().previous(this);
+    } finally {
+      LOCK.unlock();
     }
+
   }
 }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryData.java

@@ -57 +57 @@
    * Destroys the unique instance.
    */
-  public void destroy() {
+  public static void clearInstance() {
     INSTANCE = null;
   }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/MapillaryLayer.java

@@ -182 +182 @@
     if (Main.map.mapView.getEditLayer() != null)
       Main.map.mapView.getEditLayer().data.removeDataSetListener(this);
-    MapillaryData.INSTANCE = null;
-    MapillaryLayer.INSTANCE = null;
+    MapillaryData.clearInstance();
+    clearInstance();
     super.destroy();
+  }
+
+  /**
+   * Clears the unique instance of this class.
+   */
+  public static void clearInstance() {
+    INSTANCE = null;
   }
 

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportAction.java

@@ -75 +75 @@
         MapillaryLayer.getInstance();
         if (file.isDirectory()) {
+          if (file.listFiles() == null)
+            continue;
           for (int j = 0; j < file.listFiles().length; j++) {
             int k = file.listFiles()[j].getName().lastIndexOf('.');
@@ -87 +89 @@
               else if (extension.equals("png"))
                 readPNG(file.listFiles()[j]);
-            } catch (ImageReadException | IOException e1) {
+            } catch (ImageReadException | IOException | NullPointerException e1) {
               Main.error(e1);
             }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportIntoSequenceAction.java

@@ -77 +77 @@
       for (int i = 0; i < chooser.getSelectedFiles().length; i++) {
         File file = chooser.getSelectedFiles()[i];
+        if (file == null)
+          break;
         Main.pref.put("mapillary.start-directory", file.getParent());
         MapillaryLayer.getInstance();
@@ -89 +91 @@
               if (extension.equals("jpg") || extension.equals("jpeg"))
                 readJPG(file.listFiles()[j]);
-            } catch (ImageReadException e) {
-              Main.error(e);
-            } catch (IOException e) {
+            } catch (ImageReadException | NullPointerException | IOException e) {
               Main.error(e);
             }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryWalkAction.java

@@ -51 +51 @@
     JOptionPane pane = new JOptionPane(dialog, JOptionPane.PLAIN_MESSAGE,
         JOptionPane.OK_CANCEL_OPTION);
-    JDialog dlg = pane.createDialog(Main.parent, tr("Export images"));
+    JDialog dlg = pane.createDialog(Main.parent, tr("Walk mode"));
     dlg.setMinimumSize(new Dimension(400, 150));
     dlg.setVisible(true);

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/WalkThread.java

@@ -57 +57 @@
               break;
             image = image.next();
-            Utils.downloadPicture((MapillaryImage) image, Utils.PICTURE.THUMBNAIL);
+            Utils.downloadPicture((MapillaryImage) image,
+                Utils.PICTURE.THUMBNAIL);
           }
         }
@@ -96 +97 @@
           lastImage = MapillaryMainDialog.getInstance().mapillaryImageDisplay
               .getImage();
-          synchronized (lock) {
-            data.selectNext(followSelected);
-          }
+          lock.lock();
+          data.selectNext(followSelected);
+          lock.unlock();
         } catch (InterruptedException e) {
           return;
+        } finally {
+          lock.unlock();
         }
       }
@@ -111 +114 @@
   @Override
   public void interrupt() {
-    super.interrupt();
+    lock.lock();
+    try {
+      super.interrupt();
+    } catch (Exception e) {
+    } finally {
+      lock.unlock();
+    }
+
   }
 
@@ -123 +133 @@
       MapillaryAbstractImage newImage) {
     if (newImage != oldImage.next()) {
-      synchronized (lock) {
-        interrupt();
-      }
+      interrupt();
     }
   }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/downloads/MapillarySequenceDownloadThread.java

@@ -46 +46 @@
    * @param queryString
    */
-  public MapillarySequenceDownloadThread(ExecutorService ex,
-      String queryString) {
+  public MapillarySequenceDownloadThread(ExecutorService ex, String queryString) {
     this.queryString = queryString;
     this.ex = ex;
@@ -95 +94 @@
         }
 
+        LOCK.lock();
         MapillaryImage.LOCK.lock();
-        synchronized (LOCK) {
-          for (MapillaryImage img : finalImages) {
-            if (layer.getMapillaryData().getImages().contains(img)) {
-              // The image in finalImages is substituted by the one in the
-              // database, as they represent the same picture.
-              img = (MapillaryImage) layer.getMapillaryData().getImages()
-                  .get(layer.getMapillaryData().getImages().indexOf(img));
-              sequence.add(img);
-              ((MapillaryImage) layer.getMapillaryData().getImages()
-                  .get(layer.getMapillaryData().getImages().indexOf(img)))
-                  .setSequence(sequence);
-              finalImages.set(finalImages.indexOf(img), img);
-            } else {
-              img.setSequence(sequence);
-              sequence.add(img);
-            }
+        for (MapillaryImage img : finalImages) {
+          if (layer.getMapillaryData().getImages().contains(img)) {
+            // The image in finalImages is substituted by the one in the
+            // database, as they represent the same picture.
+            img = (MapillaryImage) layer.getMapillaryData().getImages()
+                .get(layer.getMapillaryData().getImages().indexOf(img));
+            sequence.add(img);
+            ((MapillaryImage) layer.getMapillaryData().getImages()
+                .get(layer.getMapillaryData().getImages().indexOf(img)))
+                .setSequence(sequence);
+            finalImages.set(finalImages.indexOf(img), img);
+          } else {
+            img.setSequence(sequence);
+            sequence.add(img);
           }
         }
         MapillaryImage.LOCK.unlock();
+        LOCK.unlock();
 
         layer.getMapillaryData().addWithoutUpdate(
@@ -122 +121 @@
       Main.error("Error reading the url " + URL + queryString
           + " might be a Mapillary problem.");
+    } finally {
+      LOCK.unlock();
+      MapillaryImage.LOCK.unlock();
     }
   }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryFilterDialog.java

@@ -203 +203 @@
       // Calculates the amount of days since the image was taken
       Long currentTime = currentTime();
-      if (time.getSelectedItem() == TIME_LIST[1]) {
+      if (time.getSelectedItem().equals(TIME_LIST[1])) {
         if (img.getCapturedAt() < currentTime
             - ((Integer) spinner.getValue()).longValue() * 365 * 24 * 60 * 60
@@ -211 +211 @@
         }
       }
-      if (time.getSelectedItem() == TIME_LIST[2]) {
+      if (time.getSelectedItem().equals(TIME_LIST[2])) {
         if (img.getCapturedAt() < currentTime
             - ((Integer) spinner.getValue()).longValue() * 30 * 24 * 60 * 60
@@ -219 +219 @@
         }
       }
-      if (time.getSelectedItem() == TIME_LIST[3]) {
+      if (time.getSelectedItem().equals(TIME_LIST[3])) {
         if (img.getCapturedAt() < currentTime
             - ((Integer) spinner.getValue()).longValue() * 60 * 60 * 1000) {

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryWalkDialog.java

@@ -30 +30 @@
   public MapillaryWalkDialog() {
     JPanel interval = new JPanel();
-    spin = new SpinnerNumberModel(3000, 100, 15000, 100);
+    spin = new SpinnerNumberModel(2000, 500, 10000, 500);
     interval.add(new JLabel("Interval (miliseconds): "));
     interval.add(new JSpinner(spin));

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/mode/SelectMode.java

@@ -173 +173 @@
 
     } else if (imageHighlighted && !nothingHighlighted
-        && Main.map.mapView != null
         && Main.map.mapView.getEditLayer().data != null
         && Main.map.mapView.getActiveLayer() instanceof OsmDataLayer) {