Changeset 31412 in osm for applications/editors

Timestamp:

2015-07-27T15:06:30+02:00 (9 years ago)

Author:

floscher

Message:

Fix some FindBugs warnings and one JavaDoc error

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• actions/MapillaryImportAction.java (modified) (1 diff)
• downloads/MapillarySequenceDownloadThread.java (modified) (1 diff)
• oauth/OAuthPortListener.java (modified) (2 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryImportAction.java

@@ -233 +233 @@
     result += degMinSec[2].doubleValue() / 3600; // seconds
 
-    if (ref == GpsTagConstants.GPS_TAG_GPS_LATITUDE_REF_VALUE_SOUTH
-        || ref == GpsTagConstants.GPS_TAG_GPS_LONGITUDE_REF_VALUE_WEST) {
+    if (GpsTagConstants.GPS_TAG_GPS_LATITUDE_REF_VALUE_SOUTH.equals(ref)
+        || GpsTagConstants.GPS_TAG_GPS_LONGITUDE_REF_VALUE_WEST.equals(ref)) {
       result *= -1;
     }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/downloads/MapillarySequenceDownloadThread.java

@@ -45 +45 @@
    * @param ex
    * @param queryString
-   * @param manager
    */
   public MapillarySequenceDownloadThread(ExecutorService ex,

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/oauth/OAuthPortListener.java

@@ -3 +3 @@
 import java.io.IOException;
 import java.io.InputStreamReader;
+import java.io.OutputStreamWriter;
 import java.io.PrintWriter;
 import java.net.BindException;
@@ -24 +25 @@
       ServerSocket serverSocket = new ServerSocket(8763);
       Socket clientSocket = serverSocket.accept();
-      PrintWriter out = new PrintWriter(clientSocket.getOutputStream(), true);
-      Scanner in = new Scanner(new InputStreamReader(
-          clientSocket.getInputStream()));
+      PrintWriter out = new PrintWriter(new OutputStreamWriter(clientSocket.getOutputStream(), "UTF-8"), true);
+      Scanner in = new Scanner(new InputStreamReader(clientSocket.getInputStream(), "UTF-8"));
       String s;
       String accessToken = null;