Changeset 31380 in osm for applications/editors/josm/plugins/mapillary/src

Timestamp:

2015-07-15T16:35:08+02:00 (9 years ago)

Author:

nokutu

Message:

Improved export GUI and when exporting an imported image, the EXIF tags that aren't used aren't deleted

Location:

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary

Files:

• actions/MapillaryExportAction.java (modified) (4 diffs)
• downloads/MapillaryExportWriterThread.java (modified) (3 diffs)
• gui/MapillaryExportDialog.java (modified) (3 diffs)

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/actions/MapillaryExportAction.java

@@ -5 +5 @@
 import java.awt.Dimension;
 import java.awt.event.ActionEvent;
+import java.awt.event.ActionListener;
 import java.awt.event.KeyEvent;
 import java.io.IOException;
@@ -10 +11 @@
 import java.util.List;
 
+import javax.swing.JButton;
 import javax.swing.JDialog;
 import javax.swing.JOptionPane;
@@ -44 +46 @@
   @Override
   public void actionPerformed(ActionEvent e) {
-    dialog = new MapillaryExportDialog();
-    JOptionPane pane = new JOptionPane(dialog, JOptionPane.PLAIN_MESSAGE,
-        JOptionPane.OK_CANCEL_OPTION);
+    JOptionPane pane = new JOptionPane();
+
+    JButton ok = new JButton("Ok");
+    ok.addActionListener(new OKAction(pane));
+    JButton cancel = new JButton(tr("Cancel"));
+    cancel.addActionListener(new CancelAction(pane));
+
+
+    dialog = new MapillaryExportDialog(ok);
+    pane.setMessage(dialog);
+    pane.setOptions(new JButton[] { ok, cancel });
+
     JDialog dlg = pane.createDialog(Main.parent, tr("Export images"));
     dlg.setMinimumSize(new Dimension(400, 150));
@@ -95 +106 @@
   }
 
+  private class OKAction implements ActionListener {
+    private JOptionPane pane;
+
+    public OKAction(JOptionPane pane) {
+      this.pane = pane;
+    }
+
+    @Override
+    public void actionPerformed(ActionEvent e) {
+      pane.setValue(JOptionPane.OK_OPTION);
+    }
+  }
+
+  private class CancelAction implements ActionListener {
+    private JOptionPane pane;
+
+    public CancelAction(JOptionPane pane) {
+      this.pane = pane;
+    }
+
+    @Override
+    public void actionPerformed(ActionEvent e) {
+      pane.setValue(JOptionPane.CANCEL_OPTION);
+    }
+  }
 }

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/downloads/MapillaryExportWriterThread.java

@@ -13 +13 @@
 import org.apache.commons.imaging.ImageReadException;
 import org.apache.commons.imaging.ImageWriteException;
+import org.apache.commons.imaging.Imaging;
+import org.apache.commons.imaging.common.ImageMetadata;
 import org.apache.commons.imaging.common.RationalNumber;
+import org.apache.commons.imaging.formats.jpeg.JpegImageMetadata;
 import org.apache.commons.imaging.formats.jpeg.exif.ExifRewriter;
+import org.apache.commons.imaging.formats.tiff.TiffImageMetadata;
 import org.apache.commons.imaging.formats.tiff.constants.ExifTagConstants;
 import org.apache.commons.imaging.formats.tiff.constants.GpsTagConstants;
@@ -67 +71 @@
         } else if (mimg instanceof MapillaryImage)
           finalPath = path + "/" + ((MapillaryImage) mimg).getKey();
-        else
-          finalPath = path + "/" + i;
+        else if (mimg instanceof MapillaryImportedImage)
+          finalPath = path + "/"
+              + ((MapillaryImportedImage) mimg).getFile().getName();
+        ;
         // Creates a temporal file that is going to be deleted after
         // writing the EXIF tags.
@@ -75 +81 @@
 
         // Write EXIF tags
-        TiffOutputSet outputSet = new TiffOutputSet();
-        TiffOutputDirectory exifDirectory = outputSet
-            .getOrCreateExifDirectory();
+        TiffOutputSet outputSet = null;
+        TiffOutputDirectory exifDirectory = null;
+        // If the image is imported, loads the rest of the EXIF data.
+        if (mimg instanceof MapillaryImportedImage) {
+          final ImageMetadata metadata = Imaging
+              .getMetadata(((MapillaryImportedImage) mimg).getFile());
+          final JpegImageMetadata jpegMetadata = (JpegImageMetadata) metadata;
+          if (null != jpegMetadata) {
+            final TiffImageMetadata exif = jpegMetadata.getExif();
+            if (null != exif) {
+              outputSet = exif.getOutputSet();
+            }
+          }
+        }
+        if (null == outputSet) {
+          outputSet = new TiffOutputSet();
+        }
+        exifDirectory = outputSet.getOrCreateExifDirectory();
+
+        exifDirectory
+            .removeField(GpsTagConstants.GPS_TAG_GPS_IMG_DIRECTION_REF);
         exifDirectory.add(GpsTagConstants.GPS_TAG_GPS_IMG_DIRECTION_REF,
             GpsTagConstants.GPS_TAG_GPS_IMG_DIRECTION_REF_VALUE_TRUE_NORTH);
+
+        exifDirectory.removeField(GpsTagConstants.GPS_TAG_GPS_IMG_DIRECTION);
         exifDirectory.add(GpsTagConstants.GPS_TAG_GPS_IMG_DIRECTION,
             RationalNumber.valueOf(mimg.getCa()));
-        if (mimg instanceof MapillaryImportedImage) {
+
+        exifDirectory.removeField(ExifTagConstants.EXIF_TAG_DATE_TIME_ORIGINAL);
+        if (mimg instanceof MapillaryImportedImage)
           exifDirectory.add(ExifTagConstants.EXIF_TAG_DATE_TIME_ORIGINAL,
               ((MapillaryImportedImage) mimg).getDate("yyyy/MM/dd hh:mm:ss"));
-        } else if (mimg instanceof MapillaryImage)
+        else if (mimg instanceof MapillaryImage)
           exifDirectory.add(ExifTagConstants.EXIF_TAG_DATE_TIME_ORIGINAL,
               ((MapillaryImage) mimg).getDate("yyyy/MM/dd hh/mm/ss"));

applications/editors/josm/plugins/mapillary/src/org/openstreetmap/josm/plugins/mapillary/gui/MapillaryExportDialog.java

@@ -48 +48 @@
   public JFileChooser chooser;
   protected String exportDirectory;
+  private JButton ok;
 
-  public MapillaryExportDialog() {
+  public MapillaryExportDialog(JButton ok) {
+    this.ok = ok;
+    ok.setEnabled(false);
+    
     setLayout(new BoxLayout(this, BoxLayout.PAGE_AXIS));
 
@@ -101 +105 @@
 
   /**
-   * Creates the folder choser GUI.
+   * Creates the folder chooser GUI.
    */
   @Override
@@ -115 +119 @@
       path.setText(chooser.getSelectedFile().toString());
       this.updateUI();
+      ok.setEnabled(true);
     }
   }