Changeset 30637 in osm

Timestamp:

2014-09-15T01:11:28+02:00 (10 years ago)

Author:

donvip

Message:

[josm_waydownloader] fix EDT violations

File:

• applications/editors/josm/plugins/waydownloader/src/org/openstreetmap/josm/plugins/waydownloader/WayDownloaderPlugin.java (modified) (4 diffs)

applications/editors/josm/plugins/waydownloader/src/org/openstreetmap/josm/plugins/waydownloader/WayDownloaderPlugin.java

@@ -28 +28 @@
 import org.openstreetmap.josm.gui.MainMenu;
 import org.openstreetmap.josm.gui.progress.PleaseWaitProgressMonitor;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.plugins.Plugin;
 import org.openstreetmap.josm.plugins.PluginInformation;
@@ -59 +60 @@
                     true);
         }
-
-        protected void showWarningMessage(String msg) {
-             if(msg == null) return;
-             JOptionPane.showMessageDialog(
-                    Main.parent,
-                    msg,
-                    tr("Warning"),
-                    JOptionPane.WARNING_MESSAGE
-             );
-        }
-
-        protected void showErrorMessage(String msg) {
-         if(msg == null) return;
-            JOptionPane.showMessageDialog(
-                    Main.parent,
-                    msg,
-                    tr("Error"),
-                    JOptionPane.ERROR_MESSAGE
-            );
-       }
-
-        protected void showInfoMessage(String msg) {
-             if(msg == null) return;
-               JOptionPane.showMessageDialog(
-                    Main.parent,
-                    msg,
-                    tr("Information"),
-                    JOptionPane.INFORMATION_MESSAGE
-               );
-          }
 
         /** Called when the WayDownloadAction action is triggered (e.g. user clicked the menu option) */
@@ -251 +222 @@
 
         @Override
-        protected void updateEnabledState(
-                Collection<? extends OsmPrimitive> selection) {
+        protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
             // do nothing
         }
@@ -328 +298 @@
         return false;
     }
+
+    private static void showWarningMessage(final String msg) {
+        if (msg != null) {
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override
+                public void run() {
+                    JOptionPane.showMessageDialog(
+                            Main.parent,
+                            msg,
+                            tr("Warning"),
+                            JOptionPane.WARNING_MESSAGE
+                        );
+                }
+            });
+        }
+    }
+
+    private static void showErrorMessage(final String msg) {
+        if (msg != null) {
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override
+                public void run() {
+                    JOptionPane.showMessageDialog(
+                            Main.parent,
+                            msg,
+                            tr("Error"),
+                            JOptionPane.ERROR_MESSAGE
+                        );
+                }
+            });
+        }
+    }
+
+    private static void showInfoMessage(final String msg) {
+        if (msg != null) {
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override
+                public void run() {
+                    JOptionPane.showMessageDialog(
+                            Main.parent,
+                            msg,
+                            tr("Information"),
+                            JOptionPane.INFORMATION_MESSAGE
+                        );
+                }
+            });
+        }
+    }
 }