Changeset 30634 in osm for applications/editors/josm/plugins/editgpx/src/org/openstreetmap

Timestamp:

2014-09-14T22:42:41+02:00 (10 years ago)

Author:

donvip

Message:

[josm_editgpx] fix #josm7102 - wrong dynamics of editgpx mode when removing layer

Location:

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx

Files:

• EditGpxLayer.java (modified) (2 diffs)
• EditGpxMode.java (modified) (8 diffs)
• GPXLayerImportAction.java (modified) (2 diffs)

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx/EditGpxLayer.java

@@ -32 +32 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 
-
 public class EditGpxLayer extends Layer {
 
@@ -51 +50 @@
     public void initializeImport() {
         try {
-            if(data.isEmpty()) {
+            if (data.isEmpty()) {
                 layerImport.activateImport();
             }
         } catch (Exception e) {
-            System.out.println(e.getMessage());
-            e.printStackTrace();
+            Main.error(e);
         }
     }

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx/EditGpxMode.java

@@ -21 +21 @@
 import org.openstreetmap.josm.gui.MapView.LayerChangeListener;
 import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.gui.layer.OsmDataLayer;
 import org.openstreetmap.josm.plugins.editgpx.data.EditGpxData;
 import org.openstreetmap.josm.plugins.editgpx.data.EditGpxTrack;
 import org.openstreetmap.josm.plugins.editgpx.data.EditGpxTrackSegment;
 import org.openstreetmap.josm.plugins.editgpx.data.EditGpxWayPoint;
-
 
 public class EditGpxMode extends MapMode implements LayerChangeListener {
@@ -40 +40 @@
     }
 
-    @Override public void enterMode() {
+    @Override
+    public void enterMode() {
         super.enterMode();
         Main.map.mapView.addMouseListener(this);
@@ -48 +49 @@
     }
 
-    @Override public void exitMode() {
+    @Override
+    public void exitMode() {
         super.exitMode();
         Main.map.mapView.removeMouseListener(this);
@@ -54 +56 @@
     }
 
-
-    @Override public void mousePressed(MouseEvent e) {
+    @Override
+    public void mousePressed(MouseEvent e) {
         pointPressed = new Point(e.getPoint());
     }
 
-
-    @Override public void mouseDragged(MouseEvent e) {
+    @Override
+    public void mouseDragged(MouseEvent e) {
         if ( (e.getModifiersEx() & InputEvent.BUTTON1_DOWN_MASK) ==  InputEvent.BUTTON1_DOWN_MASK) {
             //if button1 is hold, draw the rectangle.
@@ -67 +69 @@
     }
 
-    @Override public void mouseReleased(MouseEvent e) {
+    @Override
+    public void mouseReleased(MouseEvent e) {
         if (e.getButton() != MouseEvent.BUTTON1) {
             return;
@@ -93 +96 @@
         oldRect = null;
         Main.map.mapView.repaint();
-
     }
 
@@ -149 +151 @@
     }
 
-
     public void setFrame(MapFrame mapFrame) {
         frame = mapFrame;
@@ -177 +178 @@
         if (oldLayer instanceof EditGpxLayer) {
             currentEditLayer = null;
-            if(Main.map.mapMode instanceof EditGpxMode)
-                Main.map.selectSelectTool(false);
+            if (Main.map.mapMode instanceof EditGpxMode) {
+                if (Main.map.mapView.getActiveLayer() instanceof OsmDataLayer) {
+                    Main.map.selectSelectTool(false);
+                } else {
+                    Main.map.selectZoomTool(false);
+                }
+            }
         }
     }

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx/GPXLayerImportAction.java

@@ -31 +31 @@
 
 /**
- * Import GPX data from available layers
- *
+ * Import GPX data from available layers.
  *
  */
@@ -47 +46 @@
 
     /**
-     * shows a list of GPX layers. if user selects one the data from this layer is
-     * imported.
+     * shows a list of GPX layers. if user selects one the data from this layer is imported.
      */
     public void activateImport() {