Changeset 29727 in osm for applications/editors/josm/plugins/czechaddress/src

Timestamp:

2013-06-29T03:52:07+02:00 (12 years ago)

Author:

donvip

Message:

[josm_czechaddress] fix #josm6491 - Use of enter key in plugin dialogs

Location:

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress

Files:

• CzechAddressPlugin.java (modified) (3 diffs)
• actions/ConflictResolveAction.java (modified) (2 diffs)
• actions/GroupManipulatorAction.java (modified) (3 diffs)
• actions/ManagerAction.java (modified) (1 diff)
• actions/PointManipulatorAction.java (modified) (1 diff)
• actions/SplitAreaByEmptyWayAction.java (modified) (1 diff)
• gui/ConflictResolver.java (modified) (3 diffs)
• gui/FactoryDialog.java (modified) (4 diffs)
• gui/GroupManipulatorDialog.java (modified) (2 diffs)
• gui/LocationSelector.java (modified) (2 diffs)
• gui/ManagerDialog.java (modified) (1 diff)
• gui/PointManipulatorDialog.java (modified) (1 diff)
• gui/databaseeditors/EditorFactory.java (modified) (3 diffs)
• gui/databaseeditors/HouseEditor.java (modified) (1 diff)
• gui/databaseeditors/StreetEditor.java (modified) (2 diffs)
• gui/databaseeditors/SuburbEditor.java (modified) (2 diffs)

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/CzechAddressPlugin.java

@@ -26 +26 @@
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.preferences.PreferenceSetting;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.plugins.Plugin;
 import org.openstreetmap.josm.plugins.PluginInformation;
@@ -163 +164 @@
         ManagerDialog dialog = new ManagerDialog();
         if (dialog.countAutomaticRenameProposals() > 0)
-            dialog.setVisible(true);
+            dialog.showDialog();
     }
 
@@ -192 +193 @@
     public void pluginStatusChanged(int message) {
         if (message == MESSAGE_DATABASE_LOADED) {
-            czechMenu = Main.main.menu.addMenu(marktr("Adress"), KeyEvent.VK_Z, 4, ht("/Plugin/CzechAddress"));
-            menuItems.add(MainMenu.add(czechMenu, new PointManipulatorAction()));
-            menuItems.add(MainMenu.add(czechMenu, new GroupManipulatorAction()));
-            menuItems.add(MainMenu.add(czechMenu, new ConflictResolveAction()));
-            menuItems.add(MainMenu.add(czechMenu, new ManagerAction()));
-            menuItems.add(MainMenu.add(czechMenu, new HelpAction()));
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override public void run() {
+                    czechMenu = Main.main.menu.addMenu(marktr("Adress"), KeyEvent.VK_Z, 4, ht("/Plugin/CzechAddress"));
+                    menuItems.add(MainMenu.add(czechMenu, new PointManipulatorAction()));
+                    menuItems.add(MainMenu.add(czechMenu, new GroupManipulatorAction()));
+                    menuItems.add(MainMenu.add(czechMenu, new ConflictResolveAction()));
+                    menuItems.add(MainMenu.add(czechMenu, new ManagerAction()));
+                    menuItems.add(MainMenu.add(czechMenu, new HelpAction()));
+                }
+            });
             return;
         }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/actions/ConflictResolveAction.java

@@ -3 +3 @@
 import java.awt.event.ActionEvent;
 import java.awt.event.KeyEvent;
+
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.czechaddress.CzechAddressPlugin;
@@ -39 +40 @@
      */
     public void actionPerformed(ActionEvent e) {
-        ConflictResolver.getInstance().setVisible(true);
+        ConflictResolver.getInstance().showDialog();
     }
 }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/actions/GroupManipulatorAction.java

@@ -1 +1 @@
 package org.openstreetmap.josm.plugins.czechaddress.actions;
-
-import org.openstreetmap.josm.plugins.czechaddress.gui.GroupManipulatorDialog;
 
 import java.awt.event.ActionEvent;
@@ -8 +6 @@
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.plugins.czechaddress.CzechAddressPlugin;
+import org.openstreetmap.josm.plugins.czechaddress.gui.GroupManipulatorDialog;
 import org.openstreetmap.josm.tools.Shortcut;
 
@@ -41 +40 @@
     public void actionPerformed(ActionEvent e) {
         if (CzechAddressPlugin.getLocation() == null) return;
-        GroupManipulatorDialog.getInstence().setVisible(true);
+        GroupManipulatorDialog.getInstance().setVisible(true);
     }
 }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/actions/ManagerAction.java

@@ -25 +25 @@
     @Override
         public void actionPerformed(ActionEvent e) {
-        (new ManagerDialog()).setVisible(true);
+        new ManagerDialog().showDialog();
     }
 }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/actions/PointManipulatorAction.java

@@ -52 +52 @@
         if (CzechAddressPlugin.getLocation() == null) return;
 
-        PointManipulatorDialog dialog = new PointManipulatorDialog(primitive);
-        dialog.setVisible(true);
+        new PointManipulatorDialog(primitive).showDialog();
     }
 }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/actions/SplitAreaByEmptyWayAction.java

@@ -7 +7 @@
 import java.util.Collection;
 import java.util.Collections;
+import java.util.LinkedList;
 import java.util.List;
-import java.util.LinkedList;
 
 import javax.swing.JOptionPane;

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/ConflictResolver.java

@@ -8 +8 @@
 import java.util.logging.Level;
 import java.util.logging.Logger;
+
 import javax.swing.ComboBoxModel;
 import javax.swing.DefaultComboBoxModel;
-import javax.swing.event.ListDataListener;
 import javax.swing.Icon;
 import javax.swing.JButton;
 import javax.swing.event.ListDataEvent;
+import javax.swing.event.ListDataListener;
+
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
@@ -23 +25 @@
 import org.openstreetmap.josm.plugins.czechaddress.addressdatabase.House;
 import org.openstreetmap.josm.plugins.czechaddress.addressdatabase.Street;
+import org.openstreetmap.josm.plugins.czechaddress.gui.utils.UniversalListRenderer;
 import org.openstreetmap.josm.plugins.czechaddress.intelligence.Reasoner;
 import org.openstreetmap.josm.plugins.czechaddress.intelligence.ReasonerListener;
-import org.openstreetmap.josm.plugins.czechaddress.gui.utils.UniversalListRenderer;
 import org.openstreetmap.josm.tools.ImageProvider;
 
@@ -218 +220 @@
             mainField.setSelectedIndex(index);
             mainField.repaint();
-            setVisible(true);
+            showDialog();
         }
     }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/FactoryDialog.java

@@ -1 +1 @@
 package org.openstreetmap.josm.plugins.czechaddress.gui;
-
-import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.awt.Component;
@@ -21 +19 @@
 import org.openstreetmap.josm.data.osm.OsmPrimitive;
 import org.openstreetmap.josm.gui.dialogs.ToggleDialog;
+import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.plugins.czechaddress.CzechAddressPlugin;
 import org.openstreetmap.josm.plugins.czechaddress.MapUtils;
@@ -88 +87 @@
 
         if (message == MESSAGE_DATABASE_LOADED) {
-            relocateButton.setEnabled(true);
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override public void run() {
+                    relocateButton.setEnabled(true);
+                }
+            });
             return;
         }
@@ -95 +98 @@
             DataSet.addSelectionListener(this);
 
-            streetModel.setParent(CzechAddressPlugin.getLocation());
-            relocateButton.setText("Změnit místo");
-            streetComboBox.setEnabled(true);
-            houseList.setEnabled(true);
-            keepOddityCheckBox.setEnabled(true);
+            GuiHelper.runInEDTAndWait(new Runnable() {
+                @Override public void run() {
+                streetModel.setParent(CzechAddressPlugin.getLocation());
+                relocateButton.setText("Změnit místo");
+                streetComboBox.setEnabled(true);
+                houseList.setEnabled(true);
+                keepOddityCheckBox.setEnabled(true);
+                }
+            });
             return;
         }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/GroupManipulatorDialog.java

@@ -33 +33 @@
 
     private static GroupManipulatorDialog singleton = null;
-    public static GroupManipulatorDialog getInstence() {
+    public static GroupManipulatorDialog getInstance() {
         if (singleton == null)
             singleton = new GroupManipulatorDialog();
@@ -57 +57 @@
         setContent(mainPanel);
         setButtonIcons(new String[] {"ok.png", "cancel.png"});
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
         setDefaultCloseOperation(DISPOSE_ON_CLOSE);

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/LocationSelector.java

@@ -41 +41 @@
 
     public static ElementWithStreets selectLocation() {
-        LocationSelector ls = new LocationSelector();
-        ls.setVisible(true);
+        LocationSelector ls = (LocationSelector) new LocationSelector().showDialog();
 
         if (ls.getValue() == 1)
@@ -58 +57 @@
         setButtonIcons(new String[] {"ok.png", "cancel.png"});
         setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
 

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/ManagerDialog.java

@@ -74 +74 @@
         setContent(mainPanel);
         setButtonIcons(new String[] {"ok.png", "cancel.png"});
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
     }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/PointManipulatorDialog.java

@@ -82 +82 @@
         setContent(mainPanel, false);
         setButtonIcons(new String[] { "ok.png", "cancel.png" });
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
         setDefaultCloseOperation(DISPOSE_ON_CLOSE);

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/databaseeditors/EditorFactory.java

@@ -31 +31 @@
 
     public static boolean editStreet(Street street) {
-        StreetEditor dialog = new StreetEditor(street);
-        dialog.setVisible(true);
+        StreetEditor dialog = (StreetEditor) new StreetEditor(street).showDialog();
         if (dialog.getValue() == 1) {
             Reasoner r = Reasoner.getInstance();
@@ -49 +48 @@
 
     public static boolean editHouse(House house) {
-        HouseEditor dialog = new HouseEditor(house);
-        dialog.setVisible(true);
+        HouseEditor dialog = (HouseEditor) new HouseEditor(house).showDialog();
         if (dialog.getValue() == 1) {
             Reasoner r = Reasoner.getInstance();
@@ -66 +64 @@
 
     public static boolean editSuburb(Suburb suburb) {
-        SuburbEditor dialog = new SuburbEditor(suburb);
-        dialog.setVisible(true);
+        SuburbEditor dialog = (SuburbEditor) new SuburbEditor(suburb).showDialog();
         if (dialog.getValue() == 1) {
             suburb.setName(dialog.getSuburbName());

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/databaseeditors/HouseEditor.java

@@ -36 +36 @@
         setContent(mainPanel);
         this.setButtonIcons(new String[] {"ok.png", "cancel.png"});
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
     }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/databaseeditors/StreetEditor.java

@@ -2 +2 @@
 
 import javax.swing.DefaultComboBoxModel;
+
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.ExtendedDialog;
-import org.openstreetmap.josm.gui.preferences.PreferenceDialog;
 import org.openstreetmap.josm.plugins.czechaddress.addressdatabase.AddressElement;
 import org.openstreetmap.josm.plugins.czechaddress.addressdatabase.House;
@@ -47 +47 @@
         setContent(mainPanel);
         this.setButtonIcons(new String[] {"ok.png", "cancel.png"});
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
     }

applications/editors/josm/plugins/czechaddress/src/org/openstreetmap/josm/plugins/czechaddress/gui/databaseeditors/SuburbEditor.java

@@ -2 +2 @@
 
 import javax.swing.DefaultComboBoxModel;
+
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.gui.ExtendedDialog;
@@ -55 +56 @@
         setContent(mainPanel);
         this.setButtonIcons(new String[] {"ok.png", "cancel.png"});
+        setDefaultButton(1);
+        setCancelButton(2);
         setupDialog();
     }