Changeset 29644 in osm for applications/editors/josm/plugins

Timestamp:

2013-06-10T01:01:39+02:00 (11 years ago)

Author:

donvip

Message:

[josm_pdfimport, josm_merge-overlap] see #josm8775 - IllegalComponentStateException when remembering position of dialogs not displayed on screen

Location:

applications/editors/josm/plugins

Files:

• merge-overlap/src/mergeoverlap/MyCombinePrimitiveResolverDialog.java (modified) (1 diff)
• pdfimport/src/pdfimport/LoadPdfDialog.java (modified) (1 diff)

applications/editors/josm/plugins/merge-overlap/src/mergeoverlap/MyCombinePrimitiveResolverDialog.java

@@ -377 +377 @@
             setCancelled(false);
             btnApply.requestFocusInWindow();
-        } else {
+        } else if (isShowing()) { // Avoid IllegalComponentStateException like in #8775
             new WindowGeometry(this).remember(getClass().getName() + ".geometry");
         }

applications/editors/josm/plugins/pdfimport/src/pdfimport/LoadPdfDialog.java

@@ -512 +512 @@
                 public void setVisible(boolean visible) {
                         if (visible) {
-                        new WindowGeometry(
-                                getClass().getName() + ".geometry",
-                                WindowGeometry.centerOnScreen(new Dimension(400, 300))).applySafe(this);
-                        } else {
-                        new WindowGeometry(this).remember(getClass().getName() + ".geometry");
+                        new WindowGeometry(
+                                getClass().getName() + ".geometry",
+                                WindowGeometry.centerOnScreen(new Dimension(400, 300))).applySafe(this);
+                        } else if (isShowing()) { // Avoid IllegalComponentStateException like in #8775
+                        new WindowGeometry(this).remember(getClass().getName() + ".geometry");
                         }
                         super.setVisible(visible);