Changeset 29412 in osm for applications/editors/josm

Timestamp:

2013-03-27T20:56:51+01:00 (11 years ago)

Author:

zverik

Message:

iodb: save last layer offset, update min josm version, reduce max button count

Location:

applications/editors/josm/plugins/imagery_offset_db

Files:

• build.xml (modified) (1 diff)
• src/iodb/ImageryOffsetPlugin.java (modified) (2 diffs)
• src/iodb/ImageryOffsetWatcher.java (modified) (7 diffs)
• src/iodb/OffsetDialog.java (modified) (1 diff)

applications/editors/josm/plugins/imagery_offset_db/build.xml

@@ -32 +32 @@
     <property name="commit.message" value="Imagery Offset Database"/>
     <!-- enter the *lowest* JOSM version this plugin is currently compatible with -->
-    <property name="plugin.main.version" value="4549"/>
+    <property name="plugin.main.version" value="4666"/>
     <!--
       ************************************************

applications/editors/josm/plugins/imagery_offset_db/src/iodb/ImageryOffsetPlugin.java

@@ -5 +5 @@
 import javax.swing.JMenu;
 import org.openstreetmap.josm.Main;
+import org.openstreetmap.josm.data.Version;
 import org.openstreetmap.josm.plugins.Plugin;
 import org.openstreetmap.josm.plugins.PluginInformation;
@@ -31 +32 @@
         storeAction = new StoreImageryOffsetAction();
         
-        JMenu offsetMenu = Main.main.menu.addMenu(marktr("Offset"), KeyEvent.VK_O, 6, "help");
+        // before 5803 imagery menu was constantly regenerated, erasing extra items
+        // before 5729 it was regenerated only when the imagery list was modified (also bad)
+        int version = Version.getInstance().getVersion();
+        JMenu offsetMenu = version < 5803
+                ? Main.main.menu.addMenu(marktr("Offset"), KeyEvent.VK_O, 6, "help")
+                : Main.main.menu.imageryMenu;
         offsetMenu.add(getAction);
         offsetMenu.add(storeAction);
+        if( version >= 5803 ) // todo: check if this is needed
+            offsetMenu.addSeparator();
 
         // an ugly hack to add this plugin to the toolbar
-        Collection<String> toolbar = new LinkedList<String>(Main.toolbar.getToolString());
-        if( !toolbar.contains("getoffset") && Main.pref.getBoolean("iodb.modify.toolbar", true) ) {
-            toolbar.add("getoffset");
-            Main.pref.putCollection("toolbar", toolbar);
+        if( Main.pref.getBoolean("iodb.modify.toolbar", true) ) {
+            Collection<String> toolbar = new LinkedList<String>(Main.toolbar.getToolString());
+            if( !toolbar.contains("getoffset") ) {
+                toolbar.add("getoffset");
+                Main.pref.putCollection("toolbar", toolbar);
+                Main.toolbar.refreshToolbarControl();
+            }
             Main.pref.put("iodb.modify.toolbar", false);
-            Main.toolbar.refreshToolbarControl();
         }
     }

applications/editors/josm/plugins/imagery_offset_db/src/iodb/ImageryOffsetWatcher.java

@@ -7 +7 @@
 import org.openstreetmap.josm.gui.layer.ImageryLayer;
 import org.openstreetmap.josm.gui.layer.Layer;
+import org.openstreetmap.josm.tools.Destroyable;
 
 /**
@@ -15 +16 @@
  * @license WTFPL
  */
-public class ImageryOffsetWatcher implements MapView.ZoomChangeListener, MapView.LayerChangeListener {
+public class ImageryOffsetWatcher implements MapView.ZoomChangeListener, MapView.LayerChangeListener, Destroyable {
     private static final double THRESHOLD = 1e-8;
     private static ImageryOffsetWatcher instance;
@@ -118 +119 @@
                 data.lastDy = layer.getDy();
                 data.lastChecked = center;
+                storeLayerOffset(layer);
                 setOffsetGood(true);
             } else {
@@ -125 +127 @@
     }
 
+    /**
+     * Mark the current offset as good. This method is called by {@link OffsetDialog}
+     * to notify the watcher that an offset button has been clicked, and regardless of
+     * whether it has changed an offset, the currect imagery alignment is ok.
+     */
     public void markGood() {
         ImageryLayer layer = ImageryOffsetTools.getTopImageryLayer();
@@ -143 +150 @@
                 data.lastChecked = center;
             }
+            storeLayerOffset(layer);
         }
         setOffsetGood(true);
@@ -166 +174 @@
 
     public void layerAdded( Layer newLayer ) {
+        if( newLayer instanceof ImageryLayer )
+            loadLayerOffset((ImageryLayer)newLayer);
         checkOffset();
     }
@@ -171 +181 @@
     public void layerRemoved( Layer oldLayer ) {
         checkOffset();
+    }
+
+    /**
+     * Saves the current imagery layer offset to preferences. It is stored as a
+     * collection of ':'-separated strings: imagery_id:lat:lon:dx:dy. No need for
+     * projections: nobody uses them anyway.
+     */
+    private void storeLayerOffset( ImageryLayer layer ) {
+        String id = ImageryOffsetTools.getImageryID(layer);
+        if( !Main.pref.getBoolean("iodb.remember.offsets", true) || id == null )
+            return;
+        Collection<String> offsets = new LinkedList<String>(Main.pref.getCollection("iodb.stored.offsets"));
+        for( Iterator<String> iter = offsets.iterator(); iter.hasNext(); ) {
+            String[] offset = iter.next().split(":");
+            if( offset.length == 5 && offset[0].equals(id) )
+                iter.remove();
+        }
+        LatLon center = ImageryOffsetTools.getMapCenter();
+        offsets.add(id + ":" + center.lat() + ":" + center.lon() + ":" + layer.getDx() + ":" + layer.getDy());
+        Main.pref.putCollection("iodb.stored.offsets", offsets);
+    }
+
+    /**
+     * Loads the current imagery layer offset from preferences. 
+     */
+    private void loadLayerOffset( ImageryLayer layer ) {
+        String id = ImageryOffsetTools.getImageryID(layer);
+        if( !Main.pref.getBoolean("iodb.remember.offsets", true) || id == null )
+            return;
+        Collection<String> offsets = Main.pref.getCollection("iodb.stored.offsets");
+        for( String offset : offsets ) {
+            String[] parts = offset.split(":");
+            if( parts.length == 5 && parts[0].equals(id) ) {
+                double[] dparts = new double[4];
+                try {
+                    for( int i = 0; i < 4; i++ )
+                        dparts[i] = Double.parseDouble(parts[i+1]);
+                } catch( Exception e ) {
+                    continue;
+                }
+                LatLon lastPos = new LatLon(dparts[0], dparts[1]);
+                if( lastPos.greatCircleDistance(ImageryOffsetTools.getMapCenter()) < Math.max(maxDistance, 3.0) * 1000 ) {
+                    // apply offset
+                    layer.setOffset(dparts[2], dparts[3]);
+                    return;
+                }
+            }
+        }
     }
 

applications/editors/josm/plugins/imagery_offset_db/src/iodb/OffsetDialog.java

@@ -31 +31 @@
     protected static final String PREF_CALIBRATION = "iodb.show.calibration";
     protected static final String PREF_DEPRECATED = "iodb.show.deprecated";
-    private static final int MAX_OFFSETS = Main.main.pref.getInteger("iodb.max.offsets", 5);
+    private static final int MAX_OFFSETS = Main.main.pref.getInteger("iodb.max.offsets", 4);
 
     /**