Changeset 2896 in josm for trunk

Timestamp:

2010-01-27T20:49:59+01:00 (15 years ago)

Author:

jttt

Message:

Fixed #4057 JOSM loses data on save: Approx 20% data loss of ways but none of nodes/relations

File:

• trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/osm/QuadBuckets.java

@@ -15 +15 @@
 public class QuadBuckets<T extends OsmPrimitive> implements Collection<T>
 {
-    public static boolean debug = false;
-    static boolean consistency_testing = false;
+    private static boolean debug = false;
+    private static final boolean consistency_testing = false;
     /*
      * Functions prefixed with __ need locking before
      * being called.
      */
-    private Object split_lock = new Object();
+    private final Object split_lock = new Object();
 
     static void abort(String s)
@@ -75 +75 @@
             init(parent);
         }
-        synchronized boolean remove_content(T o)
-        {
-            boolean ret = this.content.remove(o);
-            if (this.content.size() == 0) {
-                this.content = null;
-            }
-            if (this.canRemove()) {
-                this.remove_from_parent();
-            }
-            return ret;
+        boolean remove_content(T o)
+        {
+            synchronized (split_lock) {
+                // If two threads try to remove item at the same time from different buckets of this QBLevel,
+                // it might happen that one thread removes bucket but don't remove parent because it still sees
+                // another bucket set. Second thread do the same. Due to thread memory caching, it's possible that
+                // changes made by threads will show up in children array too late, leading to QBLevel with all children
+                // set to null
+                boolean ret = this.content.remove(o);
+                if (this.content.size() == 0) {
+                    this.content = null;
+                }
+                if (this.canRemove()) {
+                    this.remove_from_parent();
+                }
+                return ret;
+            }
         }
         QBLevel[] newChildren()