Changeset 28620 in osm for applications/editors/josm

Timestamp:

2012-08-24T01:52:59+02:00 (12 years ago)

Author:

donvip

Message:

[josm_turnlanes] See #josm7980 - Fix memory leak

File:

• applications/editors/josm/plugins/turnlanes/src/org/openstreetmap/josm/plugins/turnlanes/gui/TurnLanesDialog.java (modified) (4 diffs)

applications/editors/josm/plugins/turnlanes/src/org/openstreetmap/josm/plugins/turnlanes/gui/TurnLanesDialog.java

@@ -18 +18 @@
 import javax.swing.JToggleButton;
 
-import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.actions.JosmAction;
 import org.openstreetmap.josm.data.SelectionChangedListener;
@@ -40 +39 @@
 import org.openstreetmap.josm.plugins.turnlanes.model.ModelContainer;
 
-public class TurnLanesDialog extends ToggleDialog {
+public class TurnLanesDialog extends ToggleDialog implements EditLayerChangeListener, SelectionChangedListener {
     private class EditAction extends JosmAction {
         private static final long serialVersionUID = 4114119073563457706L;
@@ -152 +151 @@
         super(tr("Turn Lanes"), "turnlanes.png", tr("Edit turn lanes"), null, 200);
         
-        MapView.addEditLayerChangeListener(new EditLayerChangeListener() {
-            @Override
-            public void editLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer) {
-                if (oldLayer != null) {
-                    oldLayer.data.removeDataSetListener(dataSetListener);
-                }
-                
-                if (newLayer != null) {
-                    newLayer.data.addDataSetListener(dataSetListener);
-                }
-            }
-        });
-        
-        DataSet.addSelectionListener(new SelectionChangedListener() {
-            @Override
-            public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
-                if (selected.equals(new HashSet<OsmPrimitive>(newSelection))) {
-                    return;
-                }
-                selected.clear();
-                selected.addAll(newSelection);
-                
-                refresh();
-            }
-        });
+        MapView.addEditLayerChangeListener(this);
+        DataSet.addSelectionListener(this);
         
         final JPanel buttonPanel = new JPanel(new GridLayout(1, 2, 4, 4));
@@ -216 +192 @@
         }
     }
+
+        @Override
+        public void editLayerChanged(OsmDataLayer oldLayer, OsmDataLayer newLayer) {
+        if (oldLayer != null) {
+            oldLayer.data.removeDataSetListener(dataSetListener);
+        }
+        
+        if (newLayer != null) {
+            newLayer.data.addDataSetListener(dataSetListener);
+        }
+        }
+
+        @Override
+        public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
+        if (selected.equals(new HashSet<OsmPrimitive>(newSelection))) {
+            return;
+        }
+        selected.clear();
+        selected.addAll(newSelection);
+        
+        refresh();
+        }
+
+        @Override
+        public void destroy() {
+                super.destroy();
+        MapView.removeEditLayerChangeListener(this);
+        DataSet.removeSelectionListener(this);
+        }
 }