Changeset 28612 in osm for applications/editors/josm/plugins/editgpx/src

Timestamp:

2012-08-24T01:20:13+02:00 (12 years ago)

Author:

donvip

Message:

[josm_editgpx] See #josm7980 - Fix memory leaks

Location:

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx

Files:

• EditGpxMode.java (modified) (2 diffs)
• EditGpxPlugin.java (modified) (1 diff)

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx/EditGpxMode.java

@@ -128 +128 @@
      */
     private void paintRect(Point p1, Point p2) {
-        Graphics g = frame.getGraphics();//Main.map.mapView.getGraphics();
+        if (frame != null) {
+            Graphics g = frame.getGraphics();
 
-        Rectangle r = oldRect;
-        if (r != null) {
-            //overwrite old rct
+            Rectangle r = oldRect;
+            if (r != null) {
+                //overwrite old rct
+                g.setXORMode(Color.BLACK);
+                g.setColor(Color.WHITE);
+                g.drawRect(r.x,r.y,r.width,r.height);
+            }
+
             g.setXORMode(Color.BLACK);
             g.setColor(Color.WHITE);
+            r = createRect(p1,p2);
             g.drawRect(r.x,r.y,r.width,r.height);
+            oldRect = r;
         }
-
-        g.setXORMode(Color.BLACK);
-        g.setColor(Color.WHITE);
-        r = createRect(p1,p2);
-        g.drawRect(r.x,r.y,r.width,r.height);
-        oldRect = r;
     }
 
@@ -178 +180 @@
     }
 
+    @Override
+    public void destroy() {
+        super.destroy();
+        MapView.removeLayerChangeListener(this);
+    }
 }

applications/editors/josm/plugins/editgpx/src/org/openstreetmap/josm/plugins/editgpx/EditGpxPlugin.java

@@ -47 +47 @@
     @Override
     public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) {
-        if(oldFrame == null && newFrame != null) {
-            mode.setFrame(newFrame);
-
-            if(Main.map != null)
+        mode.setFrame(newFrame);
+        if (oldFrame == null && newFrame != null) {
+            if (Main.map != null)
                 Main.map.addMapMode(btn);
         }