Changeset 25518 in osm for applications

Timestamp:

2011-03-05T12:49:25+01:00 (13 years ago)

Author:

hampelratte

Message:

Ticket #6034

Synchronized method updateLayer as it gets called by 2 different threads. This resulted in a race condition where the OsbLayer has been added two times to the layer dialog.

File:

• applications/editors/josm/plugins/openstreetbugs/src/org/openstreetmap/josm/plugins/osb/OsbPlugin.java (modified) (2 diffs)

applications/editors/josm/plugins/openstreetbugs/src/org/openstreetmap/josm/plugins/osb/OsbPlugin.java

@@ -240 +240 @@
     }
 
-    private void updateLayer(DataSet osbData) {
+    private synchronized void updateLayer(DataSet osbData) {
         if(layer == null) {
             layer = new OsbLayer(osbData, "OpenStreetBugs", dialog);
@@ -262 +262 @@
     public void layerRemoved(Layer oldLayer) {
         if(oldLayer == layer) {
-            MapView.removeLayerChangeListener(this);
-            MapView.removeLayerChangeListener(dialog);
             layer = null;
         }