Changeset 2501 in josm for trunk/src/org/openstreetmap

Timestamp:

2009-11-22T17:14:56+01:00 (15 years ago)

Author:

jttt

Message:

Added another tests to dataset consistency tester

File:

• trunk/src/org/openstreetmap/josm/data/osm/DatasetConsistencyTest.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/DatasetConsistencyTest.java

@@ -82 +82 @@
     }
 
+    private void checkReferredPrimitive(OsmPrimitive primitive, OsmPrimitive parent) {
+        if (dataSet.getPrimitiveById(primitive) == null) {
+            writer.println(String.format("%s is referenced by %s but not found in dataset", primitive, parent));
+        }
+        if (dataSet.getPrimitiveById(primitive) != primitive) {
+            writer.println(String.format("%s is different instance that reffered by %s", primitive, parent));
+        }
+        if (primitive.isDeleted()) {
+            writer.println(String.format("%s reffers to deleted primitive %s", parent, primitive));
+        }
+    }
+
+    private void refferedPrimitiveNotInDataset() {
+        for (Way way:dataSet.getWays()) {
+            for (Node node:way.getNodes()) {
+                checkReferredPrimitive(node, way);
+            }
+        }
+
+        for (Relation relation:dataSet.getRelations()) {
+            for (RelationMember member:relation.getMembers()) {
+                checkReferredPrimitive(member.getMember(), relation);
+            }
+        }
+    }
+
     public void runTest() {
-        checkReferrers();
-        checkCompleteWaysWithIncompleteNodes();
-        checkCompleteNodesWithoutCoordinates();
-        searchNodes();
-        searchWays();
+        try {
+            checkReferrers();
+            checkCompleteWaysWithIncompleteNodes();
+            checkCompleteNodesWithoutCoordinates();
+            searchNodes();
+            searchWays();
+            refferedPrimitiveNotInDataset();
+        } catch (Exception e) {
+            writer.println("Exception during dataset integrity test:");
+            e.printStackTrace(writer);
+        }
     }