Changeset 22688 in osm for applications

Timestamp:

2010-08-19T07:36:32+02:00 (14 years ago)

Author:

jttt

Message:

Fix memory leak

File:

• applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/ValidatorDialog.java (modified) (5 diffs)

applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/ValidatorDialog.java

@@ -84 +84 @@
     public ValidatorDialog(OSMValidatorPlugin plugin) {
         super(tr("Validation errors"), "validator", tr("Open the validation window."),
-        Shortcut.registerShortcut("subwindow:validator", tr("Toggle: {0}", tr("Validation errors")),
-        KeyEvent.VK_V, Shortcut.GROUP_LAYER, Shortcut.SHIFT_DEFAULT), 150);
+                Shortcut.registerShortcut("subwindow:validator", tr("Toggle: {0}", tr("Validation errors")),
+                        KeyEvent.VK_V, Shortcut.GROUP_LAYER, Shortcut.SHIFT_DEFAULT), 150);
 
         this.plugin = plugin;
@@ -123 +123 @@
         }
         add(buttonPanel, BorderLayout.SOUTH);
-        DataSet.selListeners.add(this);
+
+    }
+
+    @Override
+    public void showNotify() {
+        DataSet.addSelectionListener(this);
+        DataSet ds = Main.main.getCurrentDataSet();
+        if (ds != null) {
+            updateSelection(ds.getSelected());
+        }
+    }
+
+    @Override
+    public void hideNotify() {
+        DataSet.removeSelectionListener(this);
     }
 
@@ -447 +461 @@
     }
 
-    public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
+    public void updateSelection(Collection<? extends OsmPrimitive> newSelection) {
         if (!Main.pref.getBoolean(PreferenceEditor.PREF_FILTER_BY_SELECTION, false))
             return;
@@ -456 +470 @@
     }
 
+    public void selectionChanged(Collection<? extends OsmPrimitive> newSelection) {
+        updateSelection(newSelection);
+    }
+
     /**
      * Task for fixing a collection of {@see TestError}s. Can be run asynchronously.
@@ -482 +500 @@
         @Override
         protected void realRun() throws SAXException, IOException,
-                OsmTransferException {
+        OsmTransferException {
             ProgressMonitor monitor = getProgressMonitor();
             try {