Changeset 2249 in josm

Timestamp:

2009-10-05T21:36:56+02:00 (15 years ago)

Author:

jttt

Message:

Cache values for hasDirection() and isTagged ()

File:

• trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/data/osm/OsmPrimitive.java

@@ -41 +41 @@
     private static final int FLAG_FILTERED = 1 << 4;
     private static final int FLAG_SELECTED = 1 << 5;
+    private static final int FLAG_HAS_DIRECTIONS = 1 << 6;
+    private static final int FLAG_TAGGED = 1 << 7;
 
     /**
@@ -527 +529 @@
             this.keys = new HashMap<String, String>(keys);
         }
+        keysChangedImpl();
     }
 
@@ -550 +553 @@
         }
         mappaintStyle = null;
+        keysChangedImpl();
     }
     /**
@@ -564 +568 @@
         }
         mappaintStyle = null;
+        keysChangedImpl();
     }
 
@@ -574 +579 @@
         keys = null;
         mappaintStyle = null;
+        keysChangedImpl();
     }
 
@@ -610 +616 @@
     public final boolean hasKeys() {
         return keys != null && !keys.isEmpty();
+    }
+
+    private void keysChangedImpl() {
+        updateHasDirectionKeys();
+        updateTagged();
     }
 
@@ -675 +686 @@
     }
 
+    private void updateTagged() {
+        getUninterestingKeys();
+        if (keys != null) {
+            for (Entry<String,String> e : keys.entrySet()) {
+                if (!uninteresting.contains(e.getKey())) {
+                    flags |= FLAG_TAGGED;
+                    return;
+                }
+            }
+        }
+        flags &= ~FLAG_TAGGED;
+    }
+
     /**
      * true if this object is considered "tagged". To be "tagged", an object
@@ -682 +706 @@
      */
     public boolean isTagged() {
-        // TODO Cache value after keys are made private
-        getUninterestingKeys();
-        if (keys != null) {
-            for (Entry<String,String> e : keys.entrySet()) {
-                if (!uninteresting.contains(e.getKey()))
-                    return true;
-            }
-        }
-        return false;
-    }
-    /**
-     * true if this object has direction dependent tags (e.g. oneway)
-     */
-    public boolean hasDirectionKeys() {
-        // TODO Cache value after keys are made private
+        return (flags & FLAG_TAGGED) != 0;
+    }
+
+    private void updateHasDirectionKeys() {
         getDirectionKeys();
         if (keys != null) {
             for (Entry<String,String> e : keys.entrySet()) {
-                if (directionKeys.contains(e.getKey()))
-                    return true;
+                if (directionKeys.contains(e.getKey())) {
+                    flags |= FLAG_HAS_DIRECTIONS;
+                    return;
+                }
             }
         }
-        return false;
+        flags &= ~FLAG_HAS_DIRECTIONS;
+    }
+    /**
+     * true if this object has direction dependent tags (e.g. oneway)
+     */
+    public boolean hasDirectionKeys() {
+        return (flags & FLAG_HAS_DIRECTIONS) != 0;
     }