Changeset 21169 in osm

Timestamp:

2010-05-07T22:37:50+02:00 (15 years ago)

Author:

lambertus

Message:

'Fix the message text (and remove the now redundant message popup)'

Location:

applications/editors/josm/plugins/terracer

Files:

• build.xml (modified) (1 diff)
• src/terracer/HouseNumberInputDialog.java (modified) (6 diffs)
• src/terracer/HouseNumberInputHandler.java (modified) (1 diff)

applications/editors/josm/plugins/terracer/build.xml

@@ -32 +32 @@
 
 
-    <property name="commit.message" value="Remember the interpolation setting between restarts" />
+    <property name="commit.message" value="Fix the message text (and remove the now redundant message popup)" />
     <property name="plugin.main.version" value="3210" />
 

applications/editors/josm/plugins/terracer/src/terracer/HouseNumberInputDialog.java

@@ -17 +17 @@
 import java.awt.Frame;
 import java.awt.GridBagLayout;
+import java.awt.GridBagConstraints;
 import java.awt.GridLayout;
 import java.awt.event.ActionEvent;
@@ -105 +106 @@
         setupDialog();
         setVisible(true);
+        lo.requestFocus();
     }
 
@@ -126 +128 @@
     private Container getJContentPane() {
         if (jContentPane == null) {
-        
-            messageLabel = new JTextArea();
+            jContentPane = this.getContentPane();
+            jContentPane.setLayout(new BoxLayout(jContentPane, BoxLayout.Y_AXIS));
+            jContentPane.add(getInputPanel(), jContentPane);
+        }
+        return jContentPane;
+    }
+
+    /**
+     * This method initializes inputPanel
+     *
+     * @return javax.swing.JPanel
+     */
+    private JPanel getInputPanel() {
+        if (inputPanel == null) {
+
+                GridBagConstraints c = new GridBagConstraints();
+
+                messageLabel = new JTextArea();
             messageLabel.setText(DEFAULT_MESSAGE);
             messageLabel.setAutoscrolls(true);
@@ -135 +153 @@
             messageLabel.setBackground(new Color(238, 238, 238));
             messageLabel.setEditable(false);
+            messageLabel.setFocusable(false); // Needed so that lowest number can have focus immediately
             
-            jContentPane = this.getContentPane();
-            jContentPane.setLayout(new BoxLayout(jContentPane, BoxLayout.Y_AXIS));
-            jContentPane.add(messageLabel, jContentPane);
-            jContentPane.add(getInputPanel(), jContentPane);
-        }
-        return jContentPane;
-    }
-
-    /**
-     * This method initializes inputPanel
-     *
-     * @return javax.swing.JPanel
-     */
-    private JPanel getInputPanel() {
-        if (inputPanel == null) {
             interpolationLabel = new JLabel();
             interpolationLabel.setText(tr("Interpolation"));
@@ -170 +174 @@
             inputPanel = new JPanel();
             inputPanel.setLayout(new GridBagLayout());
+            c.fill = GridBagConstraints.HORIZONTAL;
+                        c.gridwidth = GridBagConstraints.REMAINDER;
+            inputPanel.add(messageLabel, c);
+            
             inputPanel.add(loLabel, GBC.std().insets(3,3,0,0));
             inputPanel.add(getLo(), GBC.eol().fill(GBC.HORIZONTAL).insets(5,3,0,0));
@@ -207 +215 @@
             lo = new JTextField();
             lo.setText("");
-            lo.requestFocus();
         }
         return lo;

applications/editors/josm/plugins/terracer/src/terracer/HouseNumberInputHandler.java

@@ -138 +138 @@
                 dialog.messageLabel.setForeground(Color.red);
                 dialog.messageLabel.setText(message.toString());
-                JOptionPane.showMessageDialog(null, message.toString(), tr("Error"), JOptionPane.ERROR_MESSAGE);
+                //JOptionPane.showMessageDialog(null, message.toString(), tr("Error"), JOptionPane.ERROR_MESSAGE);
 
             return false;