Changeset 19295 in josm for trunk/src/org/openstreetmap

Timestamp:

2025-01-28T13:46:36+01:00 (4 weeks ago)

Author:

stoecker

Message:

remove most of the new PMD messages

Location:

trunk/src/org/openstreetmap/josm

Files:

• data/SystemOfMeasurement.java (modified) (1 diff)
• data/gpx/GpxExtension.java (modified) (1 diff)
• data/validation/tests/UntaggedNode.java (modified) (1 diff)
• gui/conflict/pair/properties/PropertiesMergeModel.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/SystemOfMeasurement.java

@@ -305 +305 @@
                 .orElse(Locale.getDefault())
                 .getCountry();
-        switch (country) {
-            case "US":
-                // https://en.wikipedia.org/wiki/Metrication_in_the_United_States#Current_use
-                // Imperial units still used in transportation and Earth sciences
-                return IMPERIAL;
-            default:
-                return METRIC;
-        }
+        if (country == "US")
+            // https://en.wikipedia.org/wiki/Metrication_in_the_United_States#Current_use
+            // Imperial units still used in transportation and Earth sciences
+            return IMPERIAL;
+        else
+            return METRIC;
     }
 

trunk/src/org/openstreetmap/josm/data/gpx/GpxExtension.java

@@ -90 +90 @@
         case "josm":
             return new XMLNamespace("josm", XML_URI_EXTENSIONS_JOSM, XML_XSD_EXTENSIONS_JOSM);
-        }
-        return null;
+        default:
+            return null;
+        }
     }
 

trunk/src/org/openstreetmap/josm/data/validation/tests/UntaggedNode.java

@@ -112 +112 @@
         if (testError.getTester() instanceof UntaggedNode) {
             int code = testError.getCode();
-            switch (code) {
-            case UNTAGGED_NODE_BLANK:
-            case UNTAGGED_NODE_CREATED_BY:
-            case UNTAGGED_NODE_WATCH:
-            case UNTAGGED_NODE_SOURCE:
+            if (code == UNTAGGED_NODE_BLANK || code == UNTAGGED_NODE_CREATED_BY
+                || code == UNTAGGED_NODE_WATCH || code == UNTAGGED_NODE_SOURCE) {
                 return true;
             }

trunk/src/org/openstreetmap/josm/gui/conflict/pair/properties/PropertiesMergeModel.java

@@ -181 +181 @@
     public LatLon getMergedCoords() {
         switch (coordMergeDecision) {
-        case KEEP_MINE: return myCoords;
-        case KEEP_THEIR: return theirCoords;
-        case UNDECIDED: return null;
-        }
-        // should not happen
-        return null;
+        case KEEP_MINE:
+            return myCoords;
+        case KEEP_THEIR:
+            return theirCoords;
+        default:
+            return null;
+        }
     }
 
@@ -222 +223 @@
     public Boolean getMergedDeletedState() {
         switch (deletedMergeDecision) {
-        case KEEP_MINE: return myDeletedState;
-        case KEEP_THEIR: return theirDeletedState;
-        case UNDECIDED: return null;
-        }
-        // should not happen
-        return null;
+        case KEEP_MINE:
+            return myDeletedState;
+        case KEEP_THEIR:
+            return theirDeletedState;
+        default:
+            return null;
+        }
     }