Changeset 19286 in josm for trunk

Timestamp:

2025-01-17T11:48:11+01:00 (3 weeks ago)

Author:

taylor.smock

Message:

See #24075: Reduce memory allocations for TaggingPresetItem#matches

Make PMD happy again.

As noted in the comments for the for loop in question, this is a fairly
significant performance optimization. The for-each loop that PMD prefers has
significant penalties on hot code sections for ArrayList objects, which we use
extensively.

TBH, the JVM should probably do this optimization for (at minimum) ArrayList
objects.

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetItem.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetItem.java

@@ -180 +180 @@
              * Overall improvement: 7.6 hours to 4.5 hours for validating a Colorado pbf extract (40% improvement).
              */
-            for (int i = 0; i < items.size(); i++) { // READ ABOVE: DO NOT REPLACE WITH ENHANCED FOR LOOP WITHOUT PROFILING!
+            for (int i = 0; i < items.size(); i++) { // NOPMD READ ABOVE: DO NOT REPLACE WITH ENHANCED FOR LOOP WITHOUT PROFILING!
                 TaggingPresetItem item = items.get(i);
                 Boolean m = item.matches(tags);