Changeset 19229 in osm for applications/editors/josm/plugins/validator

Timestamp:

2009-12-28T13:26:27+01:00 (15 years ago)

Author:

guggis

Message:

'Fixed JOSM ticket #4220 - validator: check for FIXME=*'

Location:

applications/editors/josm/plugins/validator

Files:

• build.xml (modified) (1 diff)
• src/org/openstreetmap/josm/plugins/validator/tests/TagChecker.java (modified) (1 diff)
• test/org/openstreetmap/josm/plugins/validator/tests/TagCheckerTest.groovy (added)

applications/editors/josm/plugins/validator/build.xml

@@ -26 +26 @@
           ** update before publishing 
         -->
-        <property name="commit.message" value="Fixed JOSM ticket  #4231 - Validator: duplicate nodes test should round to OSM precision" />
+        <property name="commit.message" value="Fixed JOSM ticket #4220 - validator: check for FIXME=*" />
         <property name="plugin.main.version" value="2694" />
 

applications/editors/josm/plugins/validator/src/org/openstreetmap/josm/plugins/validator/tests/TagChecker.java

@@ -547 +547 @@
                 }
             }
-            if( checkFixmes && value != null && value.length() > 0 )
-            {
-                if( (value.contains("FIXME") || value.contains("check and delete") || key.contains("todo") || key.contains("fixme"))
-                && !withErrors.contains(p, "FIXME"))
-                {
-                    errors.add( new TestError(this, Severity.OTHER, tr("FIXMES"), FIXME, p) );
-                    withErrors.add(p, "FIXME");
-                }
-            }
+                        if (checkFixmes && value != null && value.length() > 0) {
+                                if ((value.toLowerCase().contains("FIXME")
+                                                || value.contains("check and delete")
+                                                || key.contains("todo") || key.toLowerCase().contains("fixme"))
+                                                && !withErrors.contains(p, "FIXME")) {
+                                        errors.add(new TestError(this, Severity.OTHER,
+                                                        tr("FIXMES"), FIXME, p));
+                                        withErrors.add(p, "FIXME");
+                                }
+                        }
         }
     }