Changeset 18964 in josm for trunk/src/org

Timestamp:

2024-01-30T15:58:03+01:00 (10 months ago)

Author:

GerdP

Message:

fix #23440: Validation results may not be refreshed on upload
The patch checks if the validator dialog is already showing. If yes, it is always updated.
An empty dialog is only suppressed when there was no dialog showing and there are no errors and the validation was triggered by the upload action.

File:

• trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java

@@ -136 +136 @@
         }
 
-        if (!GraphicsEnvironment.isHeadless() && MainApplication.getMap() != null && (!beforeUpload || !errors.isEmpty())) {
+        if (!GraphicsEnvironment.isHeadless() && MainApplication.getMap() != null) {
+            MapFrame map = MainApplication.getMap();
             // update GUI on Swing EDT
             GuiHelper.runInEDT(() -> {
-                MapFrame map = MainApplication.getMap();
+                // see #23440 why this is inside the EDT
+                if (!map.validatorDialog.isShowing() && errors.isEmpty() && beforeUpload)
+                    return;
                 map.validatorDialog.unfurlDialog();
                 map.validatorDialog.tree.setErrors(errors);