Changeset 18952 in josm for trunk/src/org/openstreetmap

Timestamp:

2024-01-23T14:05:10+01:00 (10 months ago)

Author:

GerdP

Message:

see #23430: Resetting preference validator.selectionFilter results in broken validator

• improve performance: only call tree.setFilter() when really needed, as it always triggers buildTree()

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/ValidatorDialog.java

@@ -589 +589 @@
      */
     public void updateSelection(Collection<? extends OsmPrimitive> newSelection) {
-        if (newSelection.isEmpty() || !Config.getPref().getBoolean(ValidatorPrefHelper.PREF_FILTER_BY_SELECTION, false))
+        if (!Config.getPref().getBoolean(ValidatorPrefHelper.PREF_FILTER_BY_SELECTION, false)) {
+            if (tree.getFilter() != null)
+                tree.setFilter(null);
+            return;
+        }
+
+        if (newSelection.isEmpty())
             tree.setFilter(null);
         else
@@ -739 +745 @@
             updateSelection(ds.getAllSelected());
         }
-
     }