Changeset 18947 in josm

Timestamp:

2024-01-19T14:24:48+01:00 (10 months ago)

Author:

GerdP

Message:

fix memory leak, ImgDisplay.destroy() was only called when at least one image was viewed

Location:

trunk/src/org/openstreetmap/josm/gui/layer/geoimage

Files:

• ImageDisplay.java (modified) (2 diffs)
• ImageViewerDialog.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageDisplay.java

@@ -117 +117 @@
     private UpdateImageThread updateImageThreadInstance;
 
+    private boolean destroyed;
+
     private class UpdateImageThread extends Thread {
         private boolean restart;
@@ -620 +622 @@
     @Override
     public void destroy() {
-        removeMouseListener(imgMouseListener);
-        removeMouseWheelListener(imgMouseListener);
-        removeMouseMotionListener(imgMouseListener);
-        Config.getPref().removePreferenceChangeListener(this);
-        if (imageProcessor instanceof ImageryFilterSettings) {
-            ((ImageryFilterSettings) imageProcessor).removeFilterChangeListener(this);
-        }
+        if (!destroyed) {
+            removeMouseListener(imgMouseListener);
+            removeMouseWheelListener(imgMouseListener);
+            removeMouseMotionListener(imgMouseListener);
+            Config.getPref().removePreferenceChangeListener(this);
+            if (imageProcessor instanceof ImageryFilterSettings) {
+                ((ImageryFilterSettings) imageProcessor).removeFilterChangeListener(this);
+            }
+        }
+        destroyed = true;
     }
 

trunk/src/org/openstreetmap/josm/gui/layer/geoimage/ImageViewerDialog.java

@@ -411 +411 @@
         cancelLoadingImage();
         super.destroy();
+        // make sure that Image Display is destroyed here, it might not be a component
+        imgDisplay.destroy();
         // Ensure that this dialog is removed from memory
         destroyInstance();