Changeset 18850 in josm

Timestamp:

2023-10-03T17:30:44+02:00 (16 months ago)

Author:

taylor.smock

Message:

Fix #23187: Don't show validation results panel when no issues will be shown

File:

• trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/ValidationTask.java

@@ -94 +94 @@
         if (canceled) return;
 
-        if (!GraphicsEnvironment.isHeadless() && MainApplication.getMap() != null) {
+        // Remove any low severity issues if they are not desired.
+        if (!(Boolean.TRUE.equals(ValidatorPrefHelper.PREF_OTHER.get()) &&
+                (!this.beforeUpload || Boolean.TRUE.equals(ValidatorPrefHelper.PREF_OTHER_UPLOAD.get())))) {
+            // Use >= just in case we add additional levels.
+            this.errors.removeIf(error -> error.getSeverity().getLevel() >= Severity.OTHER.getLevel());
+        }
+
+        if (!GraphicsEnvironment.isHeadless() && MainApplication.getMap() != null && (!beforeUpload || !errors.isEmpty())) {
             // update GUI on Swing EDT
             GuiHelper.runInEDT(() -> {
@@ -108 +115 @@
         }
         if (this.onFinish != null) {
-            // Remove any low severity issues if they are not desired.
-            if (!(Boolean.TRUE.equals(ValidatorPrefHelper.PREF_OTHER.get()) &&
-                    (!this.beforeUpload || Boolean.TRUE.equals(ValidatorPrefHelper.PREF_OTHER_UPLOAD.get())))) {
-                // Use >= just in case we add additional levels.
-                this.errors.removeIf(error -> error.getSeverity().getLevel() >= Severity.OTHER.getLevel());
-            }
             this.onFinish.accept(this.errors);
         }