Changeset 18843 in josm for trunk/resources/data/validator

Timestamp:

2023-09-25T18:00:35+02:00 (14 months ago)

Author:

taylor.smock

Message:

Fix #23184: Add/ignore popular tags

Add

• generator:solar:tracking: See ​osmwiki:Key:generator:solar:tracking
• natural=earth_bank: See ​osmwiki:Tag:natural=earth_bank
  • Icon drawn by taylor.smock
• highway=busway: See ​osmwiki:Tag:highway=busway
  • Icon from merging way_residential.svg and bus.svg
• school:gender: See ​osmwiki:Key:school:gender
• craft=electronics_repair: See ​osmwiki:Tag:electronics_repair
  • Icon drawn by taylor.smock
• place=municipality: See ​osmwiki:Tag:place=municipality
  • municipality.svg is largely copied from city.svg, color modified

Ignore

• check_date:?*: Used by surveying applications (fix #23182)
• boundary=religious_administration: Not well documented

Replace

• landuse=reservoir: Deprecated by ​osmwiki:Proposal:Reservoir_(2020) and replaced by ​osmwiki:water=reservoir (fix #23185)
  • tailings_pond.svg is a modified reservoir.svg icon; ​osmwiki:Tag:man_made=tailings_pond is a replacement for landuse=reservoir + reservoir_type=tailings.

This additionally fixes an issue discovered by gaben in #23183, whereby
values_from="java.util.Locale#getISOCountries" could have some values
translated. This was fixed by adding a values_context attribute; in this case,
I used "country codes".

Location:

trunk/resources/data/validator

Files:

• deprecated.mapcss (modified) (1 diff)
• ignoretags.cfg (modified) (2 diffs)

trunk/resources/data/validator/deprecated.mapcss

@@ -73 +73 @@
   fixAdd: "wetland=marsh";
 }
+#23185
+*[landuse=reservoir][!reservoir_type],
+*[landuse=reservoir][reservoir_type=water_storage] {
+  group: tr("deprecated tagging");
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "natural=water + water=reservoir";
+  fixAdd: "natural=water";
+  fixAdd: "water=reservoir";
+  fixRemove: "reservoir_type";
+}
+*[landuse=reservoir][reservoir_type=tailings] {
+  group: tr("deprecated tagging");
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "man_made=tailings_pond";
+  fixAdd: "man_made=tailings_pond";
+  fixRemove: "reservoir_type";
+  fixRemove: "reservoir_type";
+}
+*[landuse=reservoir][reservoir_type=evaporator] {
+  group: tr("deprecated tagging");
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "basin=evaporation or landuse=salt_pond";
+}
+*[landuse=reservoir][reservoir_type=sewage] {
+  group: tr("deprecated tagging");
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "natural=water + water=wastewater or landuse=basin + basin=settling or man_made=basin + basin=settling";
+}
+
 *[highway=byway] {
   throwWarning: tr("{0} is deprecated", "{0.tag}");

trunk/resources/data/validator/ignoretags.cfg

@@ -50 +50 @@
 S:taxon:
 S:colour:
+; check_date and check_date:* is used by some surveying applications
+S:check_date
 ;
 ; Ignore valid and semi-valid keys that equal...
@@ -792 +794 @@
 ; orchard=meadow_orchard seems to be more of a boolean value, "also happens to be a meadow". Don't know how we want to handle it.
 K:orchard=meadow_orchard
+; boundary=religious_administration is not well documented (2023-09-21)
+K:boundary=religious_administration
 ; Streetside parking tags (see #22901 22901.patch for starting icons)
 ; There is an external preset for these tags