Changeset 18782 in josm for trunk/src

Timestamp:

2023-07-26T18:14:37+02:00 (12 months ago)

Author:

taylor.smock

Message:

Fix #23024: Set foreground color for feedback warning label (patch by Larsossum, modified)

This fixes an issue where a dark colour theme would use a light-coloured
foreground when we set the background colour to a light colour.

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• io/UploadTextComponentValidator.java (modified) (1 diff)
• widgets/AbstractTextComponentValidator.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/io/UploadTextComponentValidator.java

@@ -49 +49 @@
         if (!Objects.equals(msg, feedback.getText())) {
             feedback.setText(msg);
-            feedback.setForeground(null);
+            feedback.setForeground(WARNING_FOREGROUND);
             feedback.setBackground(WARNING_BACKGROUND);
             feedback.setBorder(WARNING_BORDER);

trunk/src/org/openstreetmap/josm/gui/widgets/AbstractTextComponentValidator.java

@@ -46 +46 @@
     protected static final Color WARNING_COLOR = new NamedColorProperty(marktr("Input validation: warning"), new Color(0xFFA500)).get();
     protected static final Border WARNING_BORDER = BorderFactory.createLineBorder(WARNING_COLOR, 1);
+    protected static final Color WARNING_FOREGROUND = new NamedColorProperty(
+            marktr("Input validation: warning foreground"), Color.BLACK).get();
     protected static final Color WARNING_BACKGROUND = new NamedColorProperty(
             marktr("Input validation: warning background"), new Color(0xFFEDCC)).get();