Changeset 18776 in josm for trunk/test

Timestamp:

2023-07-10T22:19:01+02:00 (20 months ago)

Author:

taylor.smock

Message:

See #23049, fix an issue where tests might visit the entire dataset during upload

File:

• trunk/test/unit/org/openstreetmap/josm/actions/upload/ValidateUploadHookTest.java (modified) (4 diffs)

trunk/test/unit/org/openstreetmap/josm/actions/upload/ValidateUploadHookTest.java

@@ -6 +6 @@
 
 import java.util.Collections;
+import java.util.stream.Stream;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
@@ -12 +13 @@
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.junit.jupiter.params.ParameterizedTest;
-import org.junit.jupiter.params.provider.ValueSource;
+import org.junit.jupiter.params.provider.Arguments;
+import org.junit.jupiter.params.provider.MethodSource;
 import org.openstreetmap.josm.TestUtils;
 import org.openstreetmap.josm.data.APIDataSet;
@@ -48 +50 @@
     }
 
+    static Stream<Arguments> testUploadOtherErrors() {
+        return Stream.of(
+                Arguments.of(true, true),
+                Arguments.of(true, false),
+                Arguments.of(false, false),
+                Arguments.of(false, true)
+        );
+    }
+
     @ParameterizedTest
-    @ValueSource(booleans = {true, false})
-    void testUploadOtherErrors(boolean otherEnabled) {
-        ValidatorPrefHelper.PREF_OTHER_UPLOAD.put(otherEnabled);
+    @MethodSource
+    void testUploadOtherErrors(boolean otherUploadEnabled, boolean otherEnabled) {
+        ValidatorPrefHelper.PREF_OTHER.put(otherEnabled);
+        ValidatorPrefHelper.PREF_OTHER_UPLOAD.put(otherUploadEnabled);
         final DataSet ds = new DataSet();
         final Way building = TestUtils.newWay("building=yes", new Node(new LatLon(33.2287665, -111.8259225)),
@@ -74 +86 @@
                 };
         new ValidateUploadHook().checkUpload(new APIDataSet(ds));
-        assertEquals(!otherEnabled, mocker.getInvocationLog().isEmpty());
+        assertEquals(!(otherEnabled && otherUploadEnabled), mocker.getInvocationLog().isEmpty());
     }
 }