Changeset 18692 in josm

Timestamp:

2023-03-14T20:35:09+01:00 (20 months ago)

Author:

taylor.smock

Message:

Fix #21965: Reuse same instance of "<different>" for consistency (patch by gaben)

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/properties/PropertiesDialog.java (modified) (9 diffs)
• dialogs/properties/RelationRoleEditor.java (modified) (2 diffs)
• dialogs/properties/TagEditHelper.java (modified) (4 diffs)
• tagging/ac/MaxLengthDocumentFilter.java (modified) (4 diffs)
• tagging/presets/items/KeyedItem.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -2 +2 @@
 package org.openstreetmap.josm.gui.dialogs.properties;
 
+import static org.openstreetmap.josm.actions.search.SearchAction.searchStateless;
 import static org.openstreetmap.josm.tools.I18n.tr;
 
@@ -109 +110 @@
 import org.openstreetmap.josm.gui.tagging.presets.TaggingPresetType;
 import org.openstreetmap.josm.gui.tagging.presets.TaggingPresets;
+import org.openstreetmap.josm.gui.tagging.presets.items.KeyedItem;
 import org.openstreetmap.josm.gui.util.AbstractTag2LinkPopupListener;
 import org.openstreetmap.josm.gui.util.HighlightHelper;
@@ -355 +357 @@
         tagRowSorter.setComparator(1, (o1, o2) -> {
             if (o1 instanceof Map && o2 instanceof Map) {
-                final String v1 = ((Map) o1).size() == 1 ? (String) ((Map) o1).keySet().iterator().next() : tr("<different>");
-                final String v2 = ((Map) o2).size() == 1 ? (String) ((Map) o2).keySet().iterator().next() : tr("<different>");
+                final String v1 = ((Map) o1).size() == 1 ? (String) ((Map) o1).keySet().iterator().next() : KeyedItem.DIFFERENT_I18N;
+                final String v2 = ((Map) o2).size() == 1 ? (String) ((Map) o2).keySet().iterator().next() : KeyedItem.DIFFERENT_I18N;
                 return AlphanumComparator.getInstance().compare(v1, v2);
             } else {
@@ -773 +775 @@
             tagData.addRow(new Object[]{e.getKey(), e.getValue()});
             tags.put(e.getKey(), e.getValue().size() == 1
-                    ? e.getValue().keySet().iterator().next() : tr("<different>"));
+                    ? e.getValue().keySet().iterator().next() : KeyedItem.DIFFERENT_I18N);
         }
 
@@ -1200 +1202 @@
                         roleString = r.getRole();
                     } else if (!roleString.equals(r.getRole())) {
-                        roleString = tr("<different>");
+                        roleString = KeyedItem.DIFFERENT_I18N;
                         break;
                     }
@@ -1210 +1212 @@
         @Override
         public String toString() {
-            return "MemberInfo{" +
-                    "roles='" + roleString + '\'' +
-                    ", positions='" + positionString + '\'' +
-                    '}';
+            return String.format("MemberInfo{roles='%s', positions='%s'}", roleString, positionString);
         }
     }
@@ -1466 +1465 @@
                 return;
             final SearchSetting ss = createSearchSetting(key, sel, sameType);
-            org.openstreetmap.josm.actions.search.SearchAction.searchStateless(ss);
+            searchStateless(ss);
         }
     }
@@ -1489 +1488 @@
                 t = "type:relation ";
             }
-            String token = new StringBuilder(t).append(val).toString();
+            String token = t + val;
             if (consideredTokens.add(token)) {
                 s.append(sep).append('(').append(t).append(SearchCompiler.buildSearchStringForTag(key, val)).append(')');
@@ -1510 +1509 @@
             try {
                 tagRowSorter.convertRowIndexToModel(tagTable.getSelectedRow());
-            } catch (IndexOutOfBoundsException ignore) {
-                Logging.trace(ignore);
+            } catch (IndexOutOfBoundsException e) {
+                Logging.trace(e);
                 Logging.trace("Clearing tagTable selection");
                 tagTable.clearSelection();

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/RelationRoleEditor.java

@@ -15 +15 @@
 import org.openstreetmap.josm.data.osm.RelationMember;
 import org.openstreetmap.josm.gui.MainApplication;
+import org.openstreetmap.josm.gui.tagging.presets.items.KeyedItem;
 import org.openstreetmap.josm.tools.Utils;
 
@@ -42 +43 @@
                 formatter.formatAsHtmlUnorderedList(relation)),
                 oldRole);
-        if (newRole == null || oldRole.equals(newRole) || tr("<different>").equals(newRole)) {
+        if (newRole == null || oldRole.equals(newRole) || KeyedItem.DIFFERENT_I18N.equals(newRole)) {
             return;
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -89 +89 @@
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompListener;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletionManager;
+import org.openstreetmap.josm.gui.tagging.presets.items.KeyedItem;
 import org.openstreetmap.josm.gui.util.GuiHelper;
 import org.openstreetmap.josm.gui.util.WindowGeometry;
@@ -538 +539 @@
             List<AutoCompletionItem> valueList = autocomplete.getTagValues(getAutocompletionKeys(key), usedValuesAwareComparator);
 
-            final String selection = m.size() != 1 ? tr("<different>") : m.entrySet().iterator().next().getKey();
+            final String selection = m.size() != 1 ? KeyedItem.DIFFERENT_I18N : m.entrySet().iterator().next().getKey();
 
             values = new AutoCompComboBox<>();
@@ -586 +587 @@
                 value = null; // delete the key instead
             }
-            if (key.equals(newkey) && tr("<different>").equals(value))
+            if (key.equals(newkey) && KeyedItem.DIFFERENT_I18N.equals(value))
                 return;
             if (key.equals(newkey) || value == null) {
@@ -606 +607 @@
                 Collection<Command> commands = new ArrayList<>();
                 commands.add(new ChangePropertyCommand(sel, key, null));
-                if (value.equals(tr("<different>"))) {
+                if (value.equals(KeyedItem.DIFFERENT_I18N)) {
                     String newKey = newkey;
                     sel.stream()

trunk/src/org/openstreetmap/josm/gui/tagging/ac/MaxLengthDocumentFilter.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
 package org.openstreetmap.josm.gui.tagging.ac;
-
-import static org.openstreetmap.josm.tools.I18n.tr;
 
 import javax.swing.text.AttributeSet;
@@ -8 +6 @@
 import javax.swing.text.DocumentFilter;
 import javax.swing.text.StyleConstants;
+
+import org.openstreetmap.josm.gui.tagging.presets.items.KeyedItem;
 
 /**
@@ -16 +16 @@
     /** the document will not accept text longer than this. -1 to disable */
     private int maxLength = -1;
-    private static final String DIFFERENT = tr("<different>");
 
     /**
      * Sets the maximum text length.
      *
-     * @param length the maximum no. of charactes allowed in this document. -1 to disable
+     * @param length the maximum no. of characters allowed in this document. -1 to disable
      */
     public void setMaxLength(int length) {
@@ -45 +44 @@
     private boolean mustInsertOrReplace(FilterBypass fb, int length, String string, AttributeSet attr) {
         int newLen = fb.getDocument().getLength() - length + ((string == null) ? 0 : string.length());
-        return (maxLength == -1 || newLen <= maxLength || DIFFERENT.equals(string) ||
+        return (maxLength == -1 || newLen <= maxLength || KeyedItem.DIFFERENT_I18N.equals(string) ||
                 // allow longer text while composing characters or it will be hard to compose
                 // the last characters before the limit

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/KeyedItem.java

@@ -30 +30 @@
     protected static final String DIFFERENT = "<different>";
     /** Translation of {@code "<different>"}. */
-    protected static final String DIFFERENT_I18N = tr(DIFFERENT);
+    public static final String DIFFERENT_I18N = tr("<different>");
 
     /** True if the default value should also be set on primitives that already have tags.  */