Changeset 18671 in josm

Timestamp:

2023-02-21T16:15:39+01:00 (21 months ago)

Author:

taylor.smock

Message:

See #20768: Ensure that removing an OAuth 1.0 token actually removes the token

Location:

trunk

Files:

• src/org/openstreetmap/josm/data/oauth/OAuthAccessTokenHolder.java (modified) (2 diffs)
• test/unit/org/openstreetmap/josm/gui/preferences/server/OAuthAuthenticationPreferencesPanelTest.java (added)

trunk/src/org/openstreetmap/josm/data/oauth/OAuthAccessTokenHolder.java

@@ -121 +121 @@
      */
     public IOAuthToken getAccessToken(String api, OAuthVersion version) {
-        api = URI.create(api).getHost();
-        if (this.tokenMap.containsKey(api)) {
+        // Sometimes the api might be sent as the host
+        api = Optional.ofNullable(URI.create(api).getHost()).orElse(api);
+        if (this.tokenMap.containsKey(api) && this.tokenMap.get(api).containsKey(version)) {
             Map<OAuthVersion, IOAuthToken> map = this.tokenMap.get(api);
             return map.get(version);
@@ -236 +237 @@
                 if (this.accessTokenKey != null && this.accessTokenSecret != null) {
                     cm.storeOAuthAccessToken(new OAuthToken(accessTokenKey, accessTokenSecret));
+                } else {
+                    cm.storeOAuthAccessToken(null);
                 }
                 for (Map.Entry<String, Map<OAuthVersion, IOAuthToken>> entry : this.tokenMap.entrySet()) {