Changeset 18576 in josm

Timestamp:

2022-10-17T18:26:42+02:00 (2 years ago)

Author:

taylor.smock

Message:

PropertiesDialog: Fix sonarlint issues

File:

• trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/PropertiesDialog.java

@@ -149 +149 @@
 implements DataSelectionListener, ActiveLayerChangeListener, PropertyChangeListener, 
         DataSetListenerAdapter.Listener, TaggingPresetListener, PrimitiveHoverListener {
-    private final BooleanProperty PROP_DISPLAY_DISCARDABLE_KEYS = new BooleanProperty("display.discardable-keys", false);
+    private static final BooleanProperty PROP_DISPLAY_DISCARDABLE_KEYS = new BooleanProperty("display.discardable-keys", false);
 
     /**
@@ -582 +582 @@
         if (!layer.isLocked()) {
             List<RelationMember> members = ((MemberInfo) membershipData.getValueAt(row, 1)).role.stream()
-                    .filter(rm -> rm instanceof RelationMember)
-                    .map(rm -> (RelationMember) rm)
+                    .filter(RelationMember.class::isInstance)
+                    .map(RelationMember.class::cast)
                     .collect(Collectors.toList());
             RelationEditor.getEditor(layer, relation, members).setVisible(true);
@@ -610 +610 @@
         SelectionEventManager.getInstance().addSelectionListenerForEdt(this);
         MainApplication.getLayerManager().addActiveLayerChangeListener(this);
-        if (PROP_PREVIEW_ON_HOVER.get())
+        if (Boolean.TRUE.equals(PROP_PREVIEW_ON_HOVER.get()))
             MainApplication.getMap().mapView.addPrimitiveHoverListener(this);
         for (JosmAction action : josmActions) {
@@ -679 +679 @@
     public void primitiveHovered(PrimitiveHoverEvent e) {
         Collection<? extends IPrimitive> selection = OsmDataManager.getInstance().getInProgressISelection();
-        if (PROP_PREVIEW_ON_HOVER_PRIORITIZE_SELECTION.get() && !selection.isEmpty())
+        if (Boolean.TRUE.equals(PROP_PREVIEW_ON_HOVER_PRIORITIZE_SELECTION.get()) && !selection.isEmpty())
             return;
 
@@ -690 +690 @@
 
     private void autoresizeTagTable() {
-        if (PROP_AUTORESIZE_TAGS_TABLE.get()) {
+        if (Boolean.TRUE.equals(PROP_AUTORESIZE_TAGS_TABLE.get())) {
             // resize table's columns to fit content
             TableHelper.computeColumnsWidth(tagTable);
@@ -853 +853 @@
     public void preferenceChanged(PreferenceChangeEvent e) {
         super.preferenceChanged(e);
-        if (PROP_DISPLAY_DISCARDABLE_KEYS.getKey().equals(e.getKey())) {
-            if (MainApplication.getLayerManager().getActiveData() != null) {
-                updateSelection();
-            }
+        if (PROP_DISPLAY_DISCARDABLE_KEYS.getKey().equals(e.getKey()) && MainApplication.getLayerManager().getActiveData() != null) {
+            updateSelection();
         }
     }