Changeset 18552 in josm for trunk/resources/data/validator

Timestamp:

2022-09-08T15:27:14+02:00 (2 years ago)

Author:

taylor.smock

Message:

Fix #21396: Add/ignore popular tags

• Ignores
  • maxspeed:type
• Ignores in TODO section (now sorted)
  • advertising=board
  • amenity=loading_dock
  • amenity=parcel_locker
  • amenity=payment_terminal
  • barrier=sliding_gate
  • boundary=forest_compartment
  • craft=grinding_mill
  • emergency=access_point
  • healthcare:speciality=general
  • hedge=hedge_bank
  • historic=bomb_crater
  • indoor=area
  • leisure=sports_hall
  • man_made=courtyard
  • man_made=gantry
  • military=trench
  • natural=crevasse
  • path=crossing
  • railway=proposed
  • road_marking=solid_stop_line
  • oneway (F::oneway/S:oneway:), but indicates that this might need better software support
• Issues:
  • Suggest paving_stones:length/paving_stones:width for paving_stones:30
  • Indicate type="turnlanes:turns" is deprecated
• Preset updates
  • Modify lit to be more than yes/no
  • Add rock to surfaces
  • Add none to religions (other_religions)
  • Add locked (text="Usually locked" -- there is probably better wording for this)
  • Add pavilion to building
  • Add shop as a possible value for entrance
  • Add product as an optional key for man_made=works. With all currently documented values.
  • Add fuel to possible values for vending

Location:

trunk/resources/data/validator

Files:

• deprecated.mapcss (modified) (1 diff)
• highway.mapcss (modified) (1 diff)
• ignoretags.cfg (modified) (2 diffs)

trunk/resources/data/validator/deprecated.mapcss

@@ -2400 +2400 @@
 }
 
+/* Replaced by type=connectivity */
+*[type="turnlanes:turns"] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "type=connectivity";
+  group: tr("deprecated tagging");
+}
+
 /* When tags are deprecated they should be added to ignoretags.cfg too. */

trunk/resources/data/validator/highway.mapcss

@@ -208 +208 @@
   assertNoMatch: "way highway=trunk";
 }
+
+/* #21396 comment 39 */
+*[surface=~/^paving_stones:(\d+)$/] {
+  throwWarning: tr("{0} with trailing number", "paving_stones");
+  group: tr("questionable value (ending with a number)");
+  suggestAlternative: "paving_stones:length";
+  suggestAlternative: "paving_stones:width";
+}

trunk/resources/data/validator/ignoretags.cfg

@@ -104 +104 @@
 E:interval
 E:maxspeed
+E:maxspeed:type
 E:maxstay
 E:maxweight:signed
@@ -732 +733 @@
 E:voltage-low
 E:toilet
+K:type=turnlanes:turns
+K:surface=paving_stones:30
 ;
 ; Tags not yet decided (to remove from this section when added or moved up when deprecated) 
-; see josm tickets: 17770 15309 15774 16315 16658 16793 19982
-;
-K:service=irrigation
-K:man_made=tunnel
+; see josm tickets: 17770 15309 15774 16315 16658 16793 19982 21396
+;
+K:advertising=board
 K:amenity=childcare
-K:landuse=logging
-K:indoor=wall
-K:indoor=room
-K:indoor=corridor
-K:highway=corridor
+K:amenity=loading_dock
+K:amenity=parcel_locker
+K:amenity=payment_terminal
+K:barrier=sliding_gate
+K:boundary=forest_compartment
+K:craft=grinding_mill
 K:crossing=zebra
+K:emergency=access_point
+K:golf=cartpath
+K:healthcare:speciality=general
 K:healthcare=alternative
+K:healthcare=centre
+K:healthcare=clinic
 K:healthcare=dentist
 K:healthcare=doctor
 K:healthcare=hospital
 K:healthcare=pharmacy
-K:healthcare=clinic
-K:healthcare=centre
 K:healthcare=physiotherapist
 K:healthcare=yes
-K:golf=cartpath
+K:hedge=hedge_bank
+K:highway=corridor
+K:historic=bomb_crater
+K:indoor=area
+K:indoor=corridor
+K:indoor=room
+K:indoor=wall
+K:landuse=logging
+; See #21964/#21907 for WIP patch for leisure=sports_hall
+K:leisure=sports_hall
+K:man_made=courtyard
+K:man_made=gantry
+K:man_made=tunnel
 K:man_made=water_tap
+K:military=trench
+K:natural=crevasse
+K:path=crossing
+K:railway=proposed
 K:railway=tram_crossing
 K:railway=tram_level_crossing
+K:road_marking=solid_stop_line
+K:service=irrigation
+
+; These tags should probably have better software support, but maybe they can be in the appropriate section in this file.
+; Examples: oneway:moped and cycleway:right:oneway.
+F::oneway
+S:oneway: