Changeset 18519 in josm

Timestamp:

2022-07-14T16:33:31+02:00 (2 years ago)

Author:

taylor.smock

Message:

Fix #21630: Drop the "Riverbank" template (patch by zelonewolf)

TagInfo(1) shows that usage of waterway=riverbank has cratered over
the past year. As of writing, the total number of objects with
waterway=riverbank is less than 5,000 objects, and due to the significant
drop in usage, can be considered to be deprecated instead of
in use.

(1) ​taginfo:tags/waterway=riverbank#chronology

Location:

trunk/resources/data

Files:

• defaultpresets.xml (modified) (3 diffs)
• validator/deprecated.mapcss (modified) (1 diff)
• validator/ignoretags.cfg (modified) (1 diff)

trunk/resources/data/defaultpresets.xml

@@ -2206 +2206 @@
             <link wiki="Tag:natural=water" />
             <space />
-            <label text="A body of standing water, such as a lake or pond." />
+            <label text="A body of water, such as a lake, pond or river." />
             <space />
             <key key="natural" value="water" />
@@ -2226 +2226 @@
             </combo>
             <check key="salt" text="Salt Water" disable_off="true" />
-            <check key="intermittent" text="Intermittent (contains not permanently water)" disable_off="true" />
+            <check key="intermittent" text="Intermittent (does not permanently contain water)" disable_off="true" />
             <check key="tidal" text="In the tidal range" disable_off="true" />
             <text key="ele" text="Elevation (meters)" length="10" />
@@ -2240 +2240 @@
             <text key="name" text="Name" />
         </item> <!-- Coastline -->
-        <item name="Riverbank" icon="presets/nautical/waterway_riverbank.svg" type="closedway,multipolygon" preset_name_label="true">
-            <link wiki="Tag:waterway=riverbank" />
-            <space />
-            <key key="waterway" value="riverbank" />
-            <text key="name" text="Name" />
-            <check key="intermittent" text="Intermittent (contains not permanently water)" disable_off="true" />
-            <check key="tidal" text="In the tidal range" disable_off="true" />
-        </item> <!-- Riverbank -->
         <separator/>
         <item name="Wetland" icon="presets/landuse/wetland.svg" type="closedway,multipolygon" preset_name_label="true">

trunk/resources/data/validator/deprecated.mapcss

@@ -2088 +2088 @@
 }
 
+/* #21630 */
+*[waterway=riverbank][!natural][!water],
+*[waterway=riverbank][natural=water][!water],
+*[waterway=riverbank][!natural][water=river],
+*[waterway=riverbank][natural=water][water=river] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "natural=water + water=river";
+  group: tr("deprecated tagging");
+  fixAdd: "natural=water";
+  fixAdd: "water=river";
+  fixRemove: "waterway";
+  assertMatch: "way waterway=riverbank";
+  assertMatch: "way waterway=riverbank natural=water";
+  assertMatch: "way waterway=riverbank water=river";
+  assertMatch: "way waterway=riverbank natural=water water=river";
+  assertNoMatch: "way waterway=riverbank natural=shingle";
+  assertNoMatch: "way waterway=riverbank water=lake";
+  assertNoMatch: "way waterway=riverbank natural=water water=lake";
+  assertNoMatch: "way waterway=riverbank natural=shingle water=river";
+}
+*[waterway=riverbank][natural][natural!=water],
+*[waterway=riverbank][water][water!=river] {
+  throwWarning: tr("{0} is deprecated", "{0.tag}");
+  suggestAlternative: "natural=water + water=river";
+  group: tr("deprecated tagging");
+  assertMatch: "way waterway=riverbank natural=shingle";
+  assertMatch: "way waterway=riverbank water=lake";
+  assertNoMatch: "way waterway=riverbank";
+  assertNoMatch: "way waterway=riverbank natural=water";
+  assertNoMatch: "way waterway=riverbank water=river";
+  assertNoMatch: "way waterway=riverbank natural=water water=river";
+}
+
 node[amenity=bench][capacity][!seats],
 way[amenity=bench][capacity][!seats] {

trunk/resources/data/validator/ignoretags.cfg

@@ -690 +690 @@
 E:exit_to
 K:water=riverbank
+K:waterway=riverbank
 K:stream=intermittent
 K:shop=lamps