Changeset 18478 in josm for trunk/test/unit/org/openstreetmap

Timestamp:

2022-06-08T22:20:53+02:00 (2 years ago)

Author:

taylor.smock

Message:

Really fix failing tests in VectorDataSetTest

The test failed ~50% of the time (it depended upon the HashSet ordering).
We now use an ArrayList instead, and a the optimization that caused the
failure is not as significant anymore (node search is significantly cheaper
since r18465).

File:

• trunk/test/unit/org/openstreetmap/josm/data/vector/VectorDataSetTest.java (modified) (2 diffs)

trunk/test/unit/org/openstreetmap/josm/data/vector/VectorDataSetTest.java

@@ -14 +14 @@
 import org.awaitility.Durations;
 import org.junit.jupiter.api.BeforeEach;
-import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.RepeatedTest;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import org.openstreetmap.josm.TestUtils;
@@ -99 +99 @@
     }
 
-    @Test
+    /**
+     * This failed about 1/2 times.
+     * It tests for node deduplication.
+     */
+    @RepeatedTest(10)
     void testNodeDeduplication() {
         final VectorDataSet dataSet = this.layer.getData();