Changeset 18316 in josm for trunk/src/org

Timestamp:

2021-11-08T09:19:36+01:00 (3 years ago)

Author:

GerdP

Message:

fix #20982: Douglas-Peucker implementation is wrong
The Douglas-Peucker implementation should calculate the distance to the segment between the end nodes, not the distance to the line through those nodes.

File:

• trunk/src/org/openstreetmap/josm/actions/SimplifyWayAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/SimplifyWayAction.java

@@ -37 +37 @@
 import org.openstreetmap.josm.data.SystemOfMeasurement;
 import org.openstreetmap.josm.data.UndoRedoHandler;
+import org.openstreetmap.josm.data.coor.EastNorth;
 import org.openstreetmap.josm.data.osm.DataSet;
 import org.openstreetmap.josm.data.osm.Node;
@@ -405 +406 @@
         Node fromN = wnew.get(from);
         Node toN = wnew.get(to);
-
+        EastNorth p1 = fromN.getEastNorth();
+        EastNorth p2 = toN.getEastNorth();
         // Get max xte
         int imax = -1;
@@ -411 +413 @@
         for (int i = from + 1; i < to; i++) {
             Node n = wnew.get(i);
+            EastNorth p = n.getEastNorth();
+            double ldx = p2.getX() - p1.getX();
+            double ldy = p2.getY() - p1.getY();
+            double offset;
+            //segment zero length
+            if (ldx == 0 && ldy == 0)
+                offset = 0;
+            else {
+                double pdx = p.getX() - p1.getX();
+                double pdy = p.getY() - p1.getY();
+                offset = (pdx * ldx + pdy * ldy) / (ldx * ldx + ldy * ldy);
+            }
+            final double distRad;
             // CHECKSTYLE.OFF: SingleSpaceSeparator
-            double xte = Math.abs(Ellipsoid.WGS84.a
-                    * xtd(fromN.lat() * Math.PI / 180, fromN.lon() * Math.PI / 180, toN.lat() * Math.PI / 180,
-                            toN.lon() * Math.PI / 180,     n.lat() * Math.PI / 180,   n.lon() * Math.PI / 180));
+            if (offset <= 0) {
+                distRad = dist(fromN.lat() * Math.PI / 180, fromN.lon() * Math.PI / 180,
+                                   n.lat() * Math.PI / 180,     n.lon() * Math.PI / 180);
+            } else if (offset >= 1) {
+                distRad = dist(toN.lat() * Math.PI / 180, toN.lon() * Math.PI / 180,
+                                 n.lat() * Math.PI / 180,   n.lon() * Math.PI / 180);
+            } else {
+                distRad = xtd(fromN.lat() * Math.PI / 180, fromN.lon() * Math.PI / 180,
+                                toN.lat() * Math.PI / 180,   toN.lon() * Math.PI / 180,
+                                  n.lat() * Math.PI / 180,     n.lon() * Math.PI / 180);
+            }
             // CHECKSTYLE.ON: SingleSpaceSeparator
+            double xte = Math.abs(distRad);
             if (xte > xtemax) {
                 xtemax = xte;
@@ -421 +445 @@
             }
         }
-
-        if (imax != -1 && xtemax >= threshold) {
+        if (imax != -1 && Ellipsoid.WGS84.a * xtemax >= threshold) {
             // Segment cannot be simplified - try shorter segments
             buildSimplifiedNodeList(wnew, from, imax, threshold, simplifiedNodes);