Changeset 18313 in josm for trunk/src/org/openstreetmap

Timestamp:

2021-11-06T23:09:06+01:00 (3 years ago)

Author:

Don-vip

Message:

fix #21509 - fix potential NPEs related to comboboxes

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• dialogs/properties/TagEditHelper.java (modified) (1 diff)
• tagging/presets/items/Text.java (modified) (3 diffs)
• widgets/HistoryComboBox.java (modified) (1 diff)
• widgets/JosmComboBox.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/dialogs/properties/TagEditHelper.java

@@ -434 +434 @@
      */
     public static String getEditItem(AutoCompComboBox<AutoCompletionItem> cb) {
-        return Utils.removeWhiteSpaces(cb.getEditor().getItem().toString());
+        return Utils.removeWhiteSpaces(cb.getEditorItemAsString());
     }
 

trunk/src/org/openstreetmap/josm/gui/tagging/presets/items/Text.java

@@ -4 +4 @@
 import static org.openstreetmap.josm.tools.I18n.tr;
 
-import java.util.ArrayList;
 import java.awt.Color;
 import java.awt.Component;
@@ -11 +10 @@
 import java.text.NumberFormat;
 import java.text.ParseException;
+import java.util.ArrayList;
 import java.util.Collection;
 import java.util.Collections;
@@ -223 +223 @@
     private static String getValue(Component comp) {
         if (comp instanceof JosmComboBox) {
-            return ((JosmComboBox<?>) comp).getEditor().getItem().toString();
+            return ((JosmComboBox<?>) comp).getEditorItemAsString();
         } else if (comp instanceof JosmTextField) {
             return ((JosmTextField) comp).getText();

trunk/src/org/openstreetmap/josm/gui/widgets/HistoryComboBox.java

@@ -29 +29 @@
      */
     public void addCurrentItemToHistory() {
-        String newItem = getModel().addTopElement(getEditor().getItem().toString());
-        getModel().setSelectedItem(newItem);
+        String item = getEditorItemAsString();
+        if (item != null) {
+            getModel().setSelectedItem(getModel().addTopElement(item));
+        }
     }
 }

trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

@@ -170 +170 @@
     public JosmTextField getEditorComponent() {
         return (JosmTextField) (editor == null ? null : editor.getEditorComponent());
+    }
+
+    /**
+     * Returns the string representation of current edited item, or null.
+     * @return the string representation of current edited item, or null
+     * @since 18313
+     */
+    public String getEditorItemAsString() {
+        return editor != null && editor.getItem() != null ? editor.getItem().toString() : null;
     }